diff options
author | Jan Kara <jack@suse.cz> | 2012-03-13 22:24:54 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2012-03-13 22:24:54 -0400 |
commit | 96c866782b5e0cbdcd8e4d921d0a893278430830 (patch) | |
tree | 00a822f18c9583977c03918ccdcb766c707d8a06 /fs/jbd2 | |
parent | 79feb521a44705262d15cc819a4117a447b11ea7 (diff) |
jbd2: fix BH_JWrite setting in checkpointing code
BH_JWrite bit should be set when buffer is written to the journal. So
checkpointing shouldn't set this bit when writing out buffer. This didn't
cause any observable bug since BH_JWrite bit is used only for debugging
purposes but it's good to have this consistent.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/jbd2')
-rw-r--r-- | fs/jbd2/checkpoint.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c index 7f7ee5b90402..546c3b300eef 100644 --- a/fs/jbd2/checkpoint.c +++ b/fs/jbd2/checkpoint.c | |||
@@ -266,7 +266,6 @@ __flush_batch(journal_t *journal, int *batch_count) | |||
266 | 266 | ||
267 | for (i = 0; i < *batch_count; i++) { | 267 | for (i = 0; i < *batch_count; i++) { |
268 | struct buffer_head *bh = journal->j_chkpt_bhs[i]; | 268 | struct buffer_head *bh = journal->j_chkpt_bhs[i]; |
269 | clear_buffer_jwrite(bh); | ||
270 | BUFFER_TRACE(bh, "brelse"); | 269 | BUFFER_TRACE(bh, "brelse"); |
271 | __brelse(bh); | 270 | __brelse(bh); |
272 | } | 271 | } |
@@ -340,7 +339,6 @@ static int __process_buffer(journal_t *journal, struct journal_head *jh, | |||
340 | BUFFER_TRACE(bh, "queue"); | 339 | BUFFER_TRACE(bh, "queue"); |
341 | get_bh(bh); | 340 | get_bh(bh); |
342 | J_ASSERT_BH(bh, !buffer_jwrite(bh)); | 341 | J_ASSERT_BH(bh, !buffer_jwrite(bh)); |
343 | set_buffer_jwrite(bh); | ||
344 | journal->j_chkpt_bhs[*batch_count] = bh; | 342 | journal->j_chkpt_bhs[*batch_count] = bh; |
345 | __buffer_relink_io(jh); | 343 | __buffer_relink_io(jh); |
346 | jbd_unlock_bh_state(bh); | 344 | jbd_unlock_bh_state(bh); |