aboutsummaryrefslogtreecommitdiffstats
path: root/fs/jbd2/transaction.c
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2013-06-04 12:10:11 -0400
committerTheodore Ts'o <tytso@mit.edu>2013-06-04 12:10:11 -0400
commit2f387f849b6a5be5b4b914c43a8af0406279db11 (patch)
tree19e82529652e0aa8990b2283216f4c357dd1f7be /fs/jbd2/transaction.c
parentb34090e5e22a02fba0e4473056cce9420ad9dd0b (diff)
jbd2: remove outdated comment
The comment about credit estimates isn't true anymore. We do what the comment describes now. Reviewed-by: Zheng Liu <wenqing.lz@taobao.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/jbd2/transaction.c')
-rw-r--r--fs/jbd2/transaction.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 6f4248dd8759..60361c634b5d 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -283,16 +283,6 @@ repeat:
283 * reduce the free space arbitrarily. Be careful to account for 283 * reduce the free space arbitrarily. Be careful to account for
284 * those buffers when checkpointing. 284 * those buffers when checkpointing.
285 */ 285 */
286
287 /*
288 * @@@ AKPM: This seems rather over-defensive. We're giving commit
289 * a _lot_ of headroom: 1/4 of the journal plus the size of
290 * the committing transaction. Really, we only need to give it
291 * committing_transaction->t_outstanding_credits plus "enough" for
292 * the log control blocks.
293 * Also, this test is inconsistent with the matching one in
294 * jbd2_journal_extend().
295 */
296 if (__jbd2_log_space_left(journal) < jbd_space_needed(journal)) { 286 if (__jbd2_log_space_left(journal) < jbd_space_needed(journal)) {
297 jbd_debug(2, "Handle %p waiting for checkpoint...\n", handle); 287 jbd_debug(2, "Handle %p waiting for checkpoint...\n", handle);
298 atomic_sub(nblocks, &transaction->t_outstanding_credits); 288 atomic_sub(nblocks, &transaction->t_outstanding_credits);