diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2006-03-26 04:37:24 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-26 11:56:56 -0500 |
commit | fa3536cc144c1298f2ed9416c33f3b77fa2cd37a (patch) | |
tree | 5484541319b86ae7dac0def4db7925f7cc7008e7 /fs/inotify.c | |
parent | 878a9f30d7b13015f3aa4534d7877d985f150183 (diff) |
[PATCH] Use __read_mostly on some hot fs variables
I discovered on oprofile hunting on a SMP platform that dentry lookups were
slowed down because d_hash_mask, d_hash_shift and dentry_hashtable were in
a cache line that contained inodes_stat. So each time inodes_stats is
changed by a cpu, other cpus have to refill their cache line.
This patch moves some variables to the __read_mostly section, in order to
avoid false sharing. RCU dentry lookups can go full speed.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/inotify.c')
-rw-r--r-- | fs/inotify.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/fs/inotify.c b/fs/inotify.c index a61e93e17853..f48a3dae0712 100644 --- a/fs/inotify.c +++ b/fs/inotify.c | |||
@@ -39,15 +39,15 @@ | |||
39 | 39 | ||
40 | static atomic_t inotify_cookie; | 40 | static atomic_t inotify_cookie; |
41 | 41 | ||
42 | static kmem_cache_t *watch_cachep; | 42 | static kmem_cache_t *watch_cachep __read_mostly; |
43 | static kmem_cache_t *event_cachep; | 43 | static kmem_cache_t *event_cachep __read_mostly; |
44 | 44 | ||
45 | static struct vfsmount *inotify_mnt; | 45 | static struct vfsmount *inotify_mnt __read_mostly; |
46 | 46 | ||
47 | /* these are configurable via /proc/sys/fs/inotify/ */ | 47 | /* these are configurable via /proc/sys/fs/inotify/ */ |
48 | int inotify_max_user_instances; | 48 | int inotify_max_user_instances __read_mostly; |
49 | int inotify_max_user_watches; | 49 | int inotify_max_user_watches __read_mostly; |
50 | int inotify_max_queued_events; | 50 | int inotify_max_queued_events __read_mostly; |
51 | 51 | ||
52 | /* | 52 | /* |
53 | * Lock ordering: | 53 | * Lock ordering: |