diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/hpfs | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/hpfs')
-rw-r--r-- | fs/hpfs/super.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c index fc77965be841..437a32e9deac 100644 --- a/fs/hpfs/super.c +++ b/fs/hpfs/super.c | |||
@@ -99,11 +99,16 @@ int hpfs_stop_cycles(struct super_block *s, int key, int *c1, int *c2, | |||
99 | static void hpfs_put_super(struct super_block *s) | 99 | static void hpfs_put_super(struct super_block *s) |
100 | { | 100 | { |
101 | struct hpfs_sb_info *sbi = hpfs_sb(s); | 101 | struct hpfs_sb_info *sbi = hpfs_sb(s); |
102 | |||
103 | lock_kernel(); | ||
104 | |||
102 | kfree(sbi->sb_cp_table); | 105 | kfree(sbi->sb_cp_table); |
103 | kfree(sbi->sb_bmp_dir); | 106 | kfree(sbi->sb_bmp_dir); |
104 | unmark_dirty(s); | 107 | unmark_dirty(s); |
105 | s->s_fs_info = NULL; | 108 | s->s_fs_info = NULL; |
106 | kfree(sbi); | 109 | kfree(sbi); |
110 | |||
111 | unlock_kernel(); | ||
107 | } | 112 | } |
108 | 113 | ||
109 | unsigned hpfs_count_one_bitmap(struct super_block *s, secno secno) | 114 | unsigned hpfs_count_one_bitmap(struct super_block *s, secno secno) |