diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-09-27 04:49:40 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:10 -0400 |
| commit | 1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b (patch) | |
| tree | fade83955f75e718e39153d6f81d221403338bed /fs/hfsplus | |
| parent | f52720ca5f48574e347dff35ffe6b389ace61537 (diff) | |
[PATCH] Really ignore kmem_cache_destroy return value
* Rougly half of callers already do it by not checking return value
* Code in drivers/acpi/osl.c does the following to be sure:
(void)kmem_cache_destroy(cache);
* Those who check it printk something, however, slab_error already printed
the name of failed cache.
* XFS BUGs on failed kmem_cache_destroy which is not the decision
low-level filesystem driver should make. Converted to ignore.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/hfsplus')
| -rw-r--r-- | fs/hfsplus/super.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index d279d5924f28..194eede52fa4 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c | |||
| @@ -493,8 +493,7 @@ static int __init init_hfsplus_fs(void) | |||
| 493 | static void __exit exit_hfsplus_fs(void) | 493 | static void __exit exit_hfsplus_fs(void) |
| 494 | { | 494 | { |
| 495 | unregister_filesystem(&hfsplus_fs_type); | 495 | unregister_filesystem(&hfsplus_fs_type); |
| 496 | if (kmem_cache_destroy(hfsplus_inode_cachep)) | 496 | kmem_cache_destroy(hfsplus_inode_cachep); |
| 497 | printk(KERN_ERR "hfsplus_inode_cache: not all structures were freed\n"); | ||
| 498 | } | 497 | } |
| 499 | 498 | ||
| 500 | module_init(init_hfsplus_fs) | 499 | module_init(init_hfsplus_fs) |