diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/hfsplus | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/hfsplus')
-rw-r--r-- | fs/hfsplus/super.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index 40bdab79dae8..9b292dcc39c8 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c | |||
@@ -199,6 +199,9 @@ static void hfsplus_put_super(struct super_block *sb) | |||
199 | dprint(DBG_SUPER, "hfsplus_put_super\n"); | 199 | dprint(DBG_SUPER, "hfsplus_put_super\n"); |
200 | if (!sb->s_fs_info) | 200 | if (!sb->s_fs_info) |
201 | return; | 201 | return; |
202 | |||
203 | lock_kernel(); | ||
204 | |||
202 | if (sb->s_dirt) | 205 | if (sb->s_dirt) |
203 | hfsplus_write_super(sb); | 206 | hfsplus_write_super(sb); |
204 | if (!(sb->s_flags & MS_RDONLY) && HFSPLUS_SB(sb).s_vhdr) { | 207 | if (!(sb->s_flags & MS_RDONLY) && HFSPLUS_SB(sb).s_vhdr) { |
@@ -220,6 +223,8 @@ static void hfsplus_put_super(struct super_block *sb) | |||
220 | unload_nls(HFSPLUS_SB(sb).nls); | 223 | unload_nls(HFSPLUS_SB(sb).nls); |
221 | kfree(sb->s_fs_info); | 224 | kfree(sb->s_fs_info); |
222 | sb->s_fs_info = NULL; | 225 | sb->s_fs_info = NULL; |
226 | |||
227 | unlock_kernel(); | ||
223 | } | 228 | } |
224 | 229 | ||
225 | static int hfsplus_statfs(struct dentry *dentry, struct kstatfs *buf) | 230 | static int hfsplus_statfs(struct dentry *dentry, struct kstatfs *buf) |