diff options
author | Christoph Hellwig <hch@lst.de> | 2009-04-28 12:00:26 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:06 -0400 |
commit | 8c85e125124a473d6f3e9bb187b0b84207f81d91 (patch) | |
tree | d883424a156c00c55193e46567efdffddb6ef6b9 /fs/hfs | |
parent | 517bfae28353e996160518add4d00033d3886e61 (diff) |
remove ->write_super call in generic_shutdown_super
We just did a full fs writeout using sync_filesystem before, and if
that's not enough for the filesystem it can perform it's own writeout
in ->put_super, which many filesystems already do.
Move a call to foofs_write_super into every foofs_put_super for now to
guarantee identical behaviour until it's cleaned up by the individual
filesystem maintainers.
Exceptions:
- affs already has identical copy & pasted code at the beginning of
affs_put_super so no need to do it twice.
- xfs does the right thing without it and I have changes pending for
the xfs tree touching this are so I don't really need conflicts
here..
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/hfs')
-rw-r--r-- | fs/hfs/super.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/hfs/super.c b/fs/hfs/super.c index a36bb749926d..e071e6d06463 100644 --- a/fs/hfs/super.c +++ b/fs/hfs/super.c | |||
@@ -65,6 +65,8 @@ static void hfs_write_super(struct super_block *sb) | |||
65 | */ | 65 | */ |
66 | static void hfs_put_super(struct super_block *sb) | 66 | static void hfs_put_super(struct super_block *sb) |
67 | { | 67 | { |
68 | if (sb->s_dirt) | ||
69 | hfs_write_super(sb); | ||
68 | hfs_mdb_close(sb); | 70 | hfs_mdb_close(sb); |
69 | /* release the MDB's resources */ | 71 | /* release the MDB's resources */ |
70 | hfs_mdb_put(sb); | 72 | hfs_mdb_put(sb); |