diff options
author | Phillip Lougher <plougher@redhat.com> | 2011-11-02 16:38:01 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-11-02 19:06:59 -0400 |
commit | 434a964daa14b9db083ce20404a4a2add54d037a (patch) | |
tree | fedba22e5bc94798d96a6b895f3129043b807a15 /fs/hfs | |
parent | 3069083cc8def2ffad8520f0f24c6f95f140aac5 (diff) |
hfs: fix hfs_find_init() sb->ext_tree NULL ptr oops
Clement Lecigne reports a filesystem which causes a kernel oops in
hfs_find_init() trying to dereference sb->ext_tree which is NULL.
This proves to be because the filesystem has a corrupted MDB extent
record, where the extents file does not fit into the first three extents
in the file record (the first blocks).
In hfs_get_block() when looking up the blocks for the extent file
(HFS_EXT_CNID), it fails the first blocks special case, and falls
through to the extent code (which ultimately calls hfs_find_init())
which is in the process of being initialised.
Hfs avoids this scenario by always having the extents b-tree fitting
into the first blocks (the extents B-tree can't have overflow extents).
The fix is to check at mount time that the B-tree fits into first
blocks, i.e. fail if HFS_I(inode)->alloc_blocks >=
HFS_I(inode)->first_blocks
Note, the existing commit 47f365eb57573 ("hfs: fix oops on mount with
corrupted btree extent records") becomes subsumed into this as a special
case, but only for the extents B-tree (HFS_EXT_CNID), it is perfectly
acceptable for the catalog B-Tree file to grow beyond three extents,
with the remaining extent descriptors in the extents overfow.
This fixes CVE-2011-2203
Reported-by: Clement LECIGNE <clement.lecigne@netasq.com>
Signed-off-by: Phillip Lougher <plougher@redhat.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/hfs')
-rw-r--r-- | fs/hfs/btree.c | 20 |
1 files changed, 15 insertions, 5 deletions
diff --git a/fs/hfs/btree.c b/fs/hfs/btree.c index 3ebc437736fe..1cbdeea1db44 100644 --- a/fs/hfs/btree.c +++ b/fs/hfs/btree.c | |||
@@ -46,11 +46,26 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke | |||
46 | case HFS_EXT_CNID: | 46 | case HFS_EXT_CNID: |
47 | hfs_inode_read_fork(tree->inode, mdb->drXTExtRec, mdb->drXTFlSize, | 47 | hfs_inode_read_fork(tree->inode, mdb->drXTExtRec, mdb->drXTFlSize, |
48 | mdb->drXTFlSize, be32_to_cpu(mdb->drXTClpSiz)); | 48 | mdb->drXTFlSize, be32_to_cpu(mdb->drXTClpSiz)); |
49 | if (HFS_I(tree->inode)->alloc_blocks > | ||
50 | HFS_I(tree->inode)->first_blocks) { | ||
51 | printk(KERN_ERR "hfs: invalid btree extent records\n"); | ||
52 | unlock_new_inode(tree->inode); | ||
53 | goto free_inode; | ||
54 | } | ||
55 | |||
49 | tree->inode->i_mapping->a_ops = &hfs_btree_aops; | 56 | tree->inode->i_mapping->a_ops = &hfs_btree_aops; |
50 | break; | 57 | break; |
51 | case HFS_CAT_CNID: | 58 | case HFS_CAT_CNID: |
52 | hfs_inode_read_fork(tree->inode, mdb->drCTExtRec, mdb->drCTFlSize, | 59 | hfs_inode_read_fork(tree->inode, mdb->drCTExtRec, mdb->drCTFlSize, |
53 | mdb->drCTFlSize, be32_to_cpu(mdb->drCTClpSiz)); | 60 | mdb->drCTFlSize, be32_to_cpu(mdb->drCTClpSiz)); |
61 | |||
62 | if (!HFS_I(tree->inode)->first_blocks) { | ||
63 | printk(KERN_ERR "hfs: invalid btree extent records " | ||
64 | "(0 size).\n"); | ||
65 | unlock_new_inode(tree->inode); | ||
66 | goto free_inode; | ||
67 | } | ||
68 | |||
54 | tree->inode->i_mapping->a_ops = &hfs_btree_aops; | 69 | tree->inode->i_mapping->a_ops = &hfs_btree_aops; |
55 | break; | 70 | break; |
56 | default: | 71 | default: |
@@ -59,11 +74,6 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke | |||
59 | } | 74 | } |
60 | unlock_new_inode(tree->inode); | 75 | unlock_new_inode(tree->inode); |
61 | 76 | ||
62 | if (!HFS_I(tree->inode)->first_blocks) { | ||
63 | printk(KERN_ERR "hfs: invalid btree extent records (0 size).\n"); | ||
64 | goto free_inode; | ||
65 | } | ||
66 | |||
67 | mapping = tree->inode->i_mapping; | 77 | mapping = tree->inode->i_mapping; |
68 | page = read_mapping_page(mapping, 0, NULL); | 78 | page = read_mapping_page(mapping, 0, NULL); |
69 | if (IS_ERR(page)) | 79 | if (IS_ERR(page)) |