aboutsummaryrefslogtreecommitdiffstats
path: root/fs/gfs2
diff options
context:
space:
mode:
authorSteven Whitehouse <swhiteho@redhat.com>2013-10-03 13:43:20 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2013-10-04 04:49:29 -0400
commitbef292a72daf215c00aa20f68603de181afbb4d3 (patch)
treed705f0c7b126c6901a6be8a0a203d63fbb61f8c2 /fs/gfs2
parent26e43a15d44a02e380904ac6113fe0f2f1ddea8a (diff)
GFS2: Remove obsolete quota tunable
There is no need for a paramater which relates to the internals of quota to be exposed to users. The only possible use would be to turn it up so large that the memory allocation fails. So lets remove it and set it to a sensible value which ensures that we don't ask for multipage allocations. Currently the size of struct gfs2_holder means that the caluclated value is identical to the previous default value, so there should be no functional change. Signed-off-by: Steven Whitehouse <swhiteho@redhat.com> Cc: Abhijith Das <adas@redhat.com>
Diffstat (limited to 'fs/gfs2')
-rw-r--r--fs/gfs2/incore.h1
-rw-r--r--fs/gfs2/ops_fstype.c1
-rw-r--r--fs/gfs2/quota.c2
-rw-r--r--fs/gfs2/sys.c2
4 files changed, 1 insertions, 5 deletions
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 082c8fa7fab9..37b3cd795d6c 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -537,7 +537,6 @@ struct gfs2_tune {
537 537
538 unsigned int gt_logd_secs; 538 unsigned int gt_logd_secs;
539 539
540 unsigned int gt_quota_simul_sync; /* Max quotavals to sync at once */
541 unsigned int gt_quota_warn_period; /* Secs between quota warn msgs */ 540 unsigned int gt_quota_warn_period; /* Secs between quota warn msgs */
542 unsigned int gt_quota_scale_num; /* Numerator */ 541 unsigned int gt_quota_scale_num; /* Numerator */
543 unsigned int gt_quota_scale_den; /* Denominator */ 542 unsigned int gt_quota_scale_den; /* Denominator */
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 19ff5e8c285c..8e40fda985d6 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -51,7 +51,6 @@ static void gfs2_tune_init(struct gfs2_tune *gt)
51{ 51{
52 spin_lock_init(&gt->gt_spin); 52 spin_lock_init(&gt->gt_spin);
53 53
54 gt->gt_quota_simul_sync = 64;
55 gt->gt_quota_warn_period = 10; 54 gt->gt_quota_warn_period = 10;
56 gt->gt_quota_scale_num = 1; 55 gt->gt_quota_scale_num = 1;
57 gt->gt_quota_scale_den = 1; 56 gt->gt_quota_scale_den = 1;
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index fd1ec5243d2e..658abe26a098 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -1140,7 +1140,7 @@ int gfs2_quota_sync(struct super_block *sb, int type)
1140{ 1140{
1141 struct gfs2_sbd *sdp = sb->s_fs_info; 1141 struct gfs2_sbd *sdp = sb->s_fs_info;
1142 struct gfs2_quota_data **qda; 1142 struct gfs2_quota_data **qda;
1143 unsigned int max_qd = gfs2_tune_get(sdp, gt_quota_simul_sync); 1143 unsigned int max_qd = PAGE_SIZE/sizeof(struct gfs2_holder);
1144 unsigned int num_qd; 1144 unsigned int num_qd;
1145 unsigned int x; 1145 unsigned int x;
1146 int error = 0; 1146 int error = 0;
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index aa5c48044966..d09f6edda0ff 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -587,7 +587,6 @@ TUNE_ATTR(max_readahead, 0);
587TUNE_ATTR(complain_secs, 0); 587TUNE_ATTR(complain_secs, 0);
588TUNE_ATTR(statfs_slow, 0); 588TUNE_ATTR(statfs_slow, 0);
589TUNE_ATTR(new_files_jdata, 0); 589TUNE_ATTR(new_files_jdata, 0);
590TUNE_ATTR(quota_simul_sync, 1);
591TUNE_ATTR(statfs_quantum, 1); 590TUNE_ATTR(statfs_quantum, 1);
592TUNE_ATTR_3(quota_scale, quota_scale_show, quota_scale_store); 591TUNE_ATTR_3(quota_scale, quota_scale_show, quota_scale_store);
593 592
@@ -597,7 +596,6 @@ static struct attribute *tune_attrs[] = {
597 &tune_attr_max_readahead.attr, 596 &tune_attr_max_readahead.attr,
598 &tune_attr_complain_secs.attr, 597 &tune_attr_complain_secs.attr,
599 &tune_attr_statfs_slow.attr, 598 &tune_attr_statfs_slow.attr,
600 &tune_attr_quota_simul_sync.attr,
601 &tune_attr_statfs_quantum.attr, 599 &tune_attr_statfs_quantum.attr,
602 &tune_attr_quota_scale.attr, 600 &tune_attr_quota_scale.attr,
603 &tune_attr_new_files_jdata.attr, 601 &tune_attr_new_files_jdata.attr,