diff options
| author | Christoph Hellwig <hch@lst.de> | 2011-01-14 07:07:30 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-01-17 02:25:30 -0500 |
| commit | 64c23e86873ee410554d6d1c76b60da47025e96f (patch) | |
| tree | b30c5ff8782ebfdec6956d7834f796731fd3a1d4 /fs/gfs2 | |
| parent | eb745dbccce56f1bbe3f80b95ad2a325145171c2 (diff) | |
make the feature checks in ->fallocate future proof
Instead of various home grown checks that might need updates for new
flags just check for any bit outside the mask of the features supported
by the filesystem. This makes the check future proof for any newly
added flag.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/ops_inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 040b5a2e6556..c09528c07f3d 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c | |||
| @@ -1426,7 +1426,7 @@ static long gfs2_fallocate(struct inode *inode, int mode, loff_t offset, | |||
| 1426 | next = (next + 1) << sdp->sd_sb.sb_bsize_shift; | 1426 | next = (next + 1) << sdp->sd_sb.sb_bsize_shift; |
| 1427 | 1427 | ||
| 1428 | /* We only support the FALLOC_FL_KEEP_SIZE mode */ | 1428 | /* We only support the FALLOC_FL_KEEP_SIZE mode */ |
| 1429 | if (mode && (mode != FALLOC_FL_KEEP_SIZE)) | 1429 | if (mode & ~FALLOC_FL_KEEP_SIZE) |
| 1430 | return -EOPNOTSUPP; | 1430 | return -EOPNOTSUPP; |
| 1431 | 1431 | ||
| 1432 | offset = (offset >> sdp->sd_sb.sb_bsize_shift) << | 1432 | offset = (offset >> sdp->sd_sb.sb_bsize_shift) << |