diff options
author | Bob Peterson <rpeterso@redhat.com> | 2008-01-28 12:24:35 -0500 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2008-03-31 05:39:57 -0400 |
commit | 7eabb77e65c559d9c284da232b9ba5354898028a (patch) | |
tree | b5df9c7ca0317abde3b76e56dc8f6c0050d9558e /fs/gfs2 | |
parent | d0109bfa84d6603becac8c2e87b3716f557f2039 (diff) |
[GFS2] Misc fixups
This patch contains two small fixups that didn't fit elsewhere.
They are: (1) get rid of temp variable in find_metapath.
(2) Remove vestigial "ret" variable from gfs2_writepage_common.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2')
-rw-r--r-- | fs/gfs2/bmap.c | 3 | ||||
-rw-r--r-- | fs/gfs2/ops_address.c | 4 |
2 files changed, 2 insertions, 5 deletions
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index e8e48b690cef..e84e3845a394 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c | |||
@@ -305,11 +305,10 @@ static void find_metapath(struct gfs2_inode *ip, u64 block, | |||
305 | struct metapath *mp) | 305 | struct metapath *mp) |
306 | { | 306 | { |
307 | struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode); | 307 | struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode); |
308 | u64 b = block; | ||
309 | unsigned int i; | 308 | unsigned int i; |
310 | 309 | ||
311 | for (i = ip->i_height; i--;) | 310 | for (i = ip->i_height; i--;) |
312 | mp->mp_list[i] = do_div(b, sdp->sd_inptrs); | 311 | mp->mp_list[i] = do_div(block, sdp->sd_inptrs); |
313 | 312 | ||
314 | } | 313 | } |
315 | 314 | ||
diff --git a/fs/gfs2/ops_address.c b/fs/gfs2/ops_address.c index ac772b6d9dbb..7523999afc53 100644 --- a/fs/gfs2/ops_address.c +++ b/fs/gfs2/ops_address.c | |||
@@ -1,6 +1,6 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | 2 | * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. |
3 | * Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved. | 3 | * Copyright (C) 2004-2008 Red Hat, Inc. All rights reserved. |
4 | * | 4 | * |
5 | * This copyrighted material is made available to anyone wishing to use, | 5 | * This copyrighted material is made available to anyone wishing to use, |
6 | * modify, copy, or redistribute it subject to the terms and conditions | 6 | * modify, copy, or redistribute it subject to the terms and conditions |
@@ -104,11 +104,9 @@ static int gfs2_writepage_common(struct page *page, | |||
104 | loff_t i_size = i_size_read(inode); | 104 | loff_t i_size = i_size_read(inode); |
105 | pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT; | 105 | pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT; |
106 | unsigned offset; | 106 | unsigned offset; |
107 | int ret = -EIO; | ||
108 | 107 | ||
109 | if (gfs2_assert_withdraw(sdp, gfs2_glock_is_held_excl(ip->i_gl))) | 108 | if (gfs2_assert_withdraw(sdp, gfs2_glock_is_held_excl(ip->i_gl))) |
110 | goto out; | 109 | goto out; |
111 | ret = 0; | ||
112 | if (current->journal_info) | 110 | if (current->journal_info) |
113 | goto redirty; | 111 | goto redirty; |
114 | /* Is the page fully outside i_size? (truncate in progress) */ | 112 | /* Is the page fully outside i_size? (truncate in progress) */ |