aboutsummaryrefslogtreecommitdiffstats
path: root/fs/gfs2/ops_super.c
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2006-09-27 04:50:31 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2006-09-28 08:32:24 -0400
commitbba9dfd83587017de1c55a94c077983e0dfa0251 (patch)
tree8af76134269374850dea490ee1020cb92f4fdb9b /fs/gfs2/ops_super.c
parent185a257f2f73bcd89050ad02da5bedbc28fc43fa (diff)
[GFS2] inode_diet: Replace inode.u.generic_ip with inode.i_private (gfs)
The following patches reduce the size of the VFS inode structure by 28 bytes on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction in the inode size on a UP kernel that is configured in a production mode (i.e., with no spinlock or other debugging functions enabled; if you want to save memory taken up by in-core inodes, the first thing you should do is disable the debugging options; they are responsible for a huge amount of bloat in the VFS inode structure). This patch: The filesystem or device-specific pointer in the inode is inside a union, which is pretty pointless given that all 30+ users of this field have been using the void pointer. Get rid of the union and rename it to i_private, with a comment to explain who is allowed to use the void pointer. This is just a cleanup, but it allows us to reuse the union 'u' for something something where the union will actually be used. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: Steven Whitehouse <swhiteho@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org>
Diffstat (limited to 'fs/gfs2/ops_super.c')
-rw-r--r--fs/gfs2/ops_super.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/gfs2/ops_super.c b/fs/gfs2/ops_super.c
index 8cfda6452139..06f06f7773d0 100644
--- a/fs/gfs2/ops_super.c
+++ b/fs/gfs2/ops_super.c
@@ -53,7 +53,7 @@ static int gfs2_write_inode(struct inode *inode, int sync)
53 struct gfs2_inode *ip = GFS2_I(inode); 53 struct gfs2_inode *ip = GFS2_I(inode);
54 54
55 /* Check this is a "normal" inode */ 55 /* Check this is a "normal" inode */
56 if (inode->u.generic_ip) { 56 if (inode->i_private) {
57 if (current->flags & PF_MEMALLOC) 57 if (current->flags & PF_MEMALLOC)
58 return 0; 58 return 0;
59 if (sync) 59 if (sync)
@@ -280,7 +280,7 @@ static void gfs2_clear_inode(struct inode *inode)
280 * serves to contain an address space (see rgrp.c, meta_io.c) 280 * serves to contain an address space (see rgrp.c, meta_io.c)
281 * which therefore doesn't have its own glocks. 281 * which therefore doesn't have its own glocks.
282 */ 282 */
283 if (inode->u.generic_ip) { 283 if (inode->i_private) {
284 struct gfs2_inode *ip = GFS2_I(inode); 284 struct gfs2_inode *ip = GFS2_I(inode);
285 gfs2_glock_inode_squish(inode); 285 gfs2_glock_inode_squish(inode);
286 gfs2_assert(inode->i_sb->s_fs_info, ip->i_gl->gl_state == LM_ST_UNLOCKED); 286 gfs2_assert(inode->i_sb->s_fs_info, ip->i_gl->gl_state == LM_ST_UNLOCKED);
@@ -381,7 +381,7 @@ static void gfs2_delete_inode(struct inode *inode)
381 struct gfs2_holder gh; 381 struct gfs2_holder gh;
382 int error; 382 int error;
383 383
384 if (!inode->u.generic_ip) 384 if (!inode->i_private)
385 goto out; 385 goto out;
386 386
387 error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, LM_FLAG_TRY_1CB | GL_NOCACHE, &gh); 387 error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, LM_FLAG_TRY_1CB | GL_NOCACHE, &gh);