diff options
author | Steven Whitehouse <swhiteho@redhat.com> | 2010-08-11 04:37:53 -0400 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2010-09-20 06:18:16 -0400 |
commit | ff8f33c8b30d7b7efdcf2548c7f6e64db6a89b29 (patch) | |
tree | a21bad4d2b48f743dd96277b1c966c35aefe1ce2 /fs/gfs2/ops_inode.c | |
parent | 2422084a94fcd5038406261b331672a13c92c050 (diff) |
GFS2: New truncate sequence
This updates GFS2's truncate code to use the new truncate
sequence correctly. This is a stepping stone to being
able to remove ip->i_disksize in favour of using i_size
everywhere now that the two sizes are always identical.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/gfs2/ops_inode.c')
-rw-r--r-- | fs/gfs2/ops_inode.c | 26 |
1 files changed, 1 insertions, 25 deletions
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 1009be2c9737..1d3f2fb466bd 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c | |||
@@ -1071,30 +1071,6 @@ int gfs2_permission(struct inode *inode, int mask) | |||
1071 | return error; | 1071 | return error; |
1072 | } | 1072 | } |
1073 | 1073 | ||
1074 | /* | ||
1075 | * XXX(truncate): the truncate_setsize calls should be moved to the end. | ||
1076 | */ | ||
1077 | static int setattr_size(struct inode *inode, struct iattr *attr) | ||
1078 | { | ||
1079 | struct gfs2_inode *ip = GFS2_I(inode); | ||
1080 | struct gfs2_sbd *sdp = GFS2_SB(inode); | ||
1081 | int error; | ||
1082 | |||
1083 | if (attr->ia_size != ip->i_disksize) { | ||
1084 | error = gfs2_trans_begin(sdp, 0, sdp->sd_jdesc->jd_blocks); | ||
1085 | if (error) | ||
1086 | return error; | ||
1087 | truncate_setsize(inode, attr->ia_size); | ||
1088 | gfs2_trans_end(sdp); | ||
1089 | } | ||
1090 | |||
1091 | error = gfs2_truncatei(ip, attr->ia_size); | ||
1092 | if (error && (inode->i_size != ip->i_disksize)) | ||
1093 | i_size_write(inode, ip->i_disksize); | ||
1094 | |||
1095 | return error; | ||
1096 | } | ||
1097 | |||
1098 | static int setattr_chown(struct inode *inode, struct iattr *attr) | 1074 | static int setattr_chown(struct inode *inode, struct iattr *attr) |
1099 | { | 1075 | { |
1100 | struct gfs2_inode *ip = GFS2_I(inode); | 1076 | struct gfs2_inode *ip = GFS2_I(inode); |
@@ -1195,7 +1171,7 @@ static int gfs2_setattr(struct dentry *dentry, struct iattr *attr) | |||
1195 | goto out; | 1171 | goto out; |
1196 | 1172 | ||
1197 | if (attr->ia_valid & ATTR_SIZE) | 1173 | if (attr->ia_valid & ATTR_SIZE) |
1198 | error = setattr_size(inode, attr); | 1174 | error = gfs2_setattr_size(inode, attr->ia_size); |
1199 | else if (attr->ia_valid & (ATTR_UID | ATTR_GID)) | 1175 | else if (attr->ia_valid & (ATTR_UID | ATTR_GID)) |
1200 | error = setattr_chown(inode, attr); | 1176 | error = setattr_chown(inode, attr); |
1201 | else if ((attr->ia_valid & ATTR_MODE) && IS_POSIXACL(inode)) | 1177 | else if ((attr->ia_valid & ATTR_MODE) && IS_POSIXACL(inode)) |