aboutsummaryrefslogtreecommitdiffstats
path: root/fs/gfs2/eaops.c
diff options
context:
space:
mode:
authorSteven Whitehouse <swhiteho@redhat.com>2006-06-14 15:32:57 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2006-06-14 15:32:57 -0400
commitfeaa7bba026c181ce071d5a4884f7f9dd26207a1 (patch)
treec858deb225917265cb07820730e9764674d133e8 /fs/gfs2/eaops.c
parent22da645fd6675b7abc55cf937ddf6132f343e5b9 (diff)
[GFS2] Fix unlinked file handling
This patch fixes the way we have been dealing with unlinked, but still open files. It removes all limits (other than memory for inodes, as per every other filesystem) on numbers of these which we can support on GFS2. It also means that (like other fs) its the responsibility of the last process to close the file to deallocate the storage, rather than the person who did the unlinking. Note that with GFS2, those two events might take place on different nodes. Also there are a number of other changes: o We use the Linux inode subsystem as it was intended to be used, wrt allocating GFS2 inodes o The Linux inode cache is now the point which we use for local enforcement of only holding one copy of the inode in core at once (previous to this we used the glock layer). o We no longer use the unlinked "special" file. We just ignore it completely. This makes unlinking more efficient. o We now use the 4th block allocation state. The previously unused state is used to track unlinked but still open inodes. o gfs2_inoded is no longer needed o Several fields are now no longer needed (and removed) from the in core struct gfs2_inode o Several fields are no longer needed (and removed) from the in core superblock There are a number of future possible optimisations and clean ups which have been made possible by this patch. Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/eaops.c')
-rw-r--r--fs/gfs2/eaops.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/fs/gfs2/eaops.c b/fs/gfs2/eaops.c
index 1c5ac3160b3b..b7e6a37cab6e 100644
--- a/fs/gfs2/eaops.c
+++ b/fs/gfs2/eaops.c
@@ -58,7 +58,7 @@ unsigned int gfs2_ea_name2type(const char *name, char **truncated_name)
58 58
59static int user_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er) 59static int user_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er)
60{ 60{
61 struct inode *inode = ip->i_vnode; 61 struct inode *inode = &ip->i_inode;
62 int error = permission(inode, MAY_READ, NULL); 62 int error = permission(inode, MAY_READ, NULL);
63 if (error) 63 if (error)
64 return error; 64 return error;
@@ -68,7 +68,7 @@ static int user_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er)
68 68
69static int user_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er) 69static int user_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er)
70{ 70{
71 struct inode *inode = ip->i_vnode; 71 struct inode *inode = &ip->i_inode;
72 72
73 if (S_ISREG(inode->i_mode) || 73 if (S_ISREG(inode->i_mode) ||
74 (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) { 74 (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
@@ -83,7 +83,7 @@ static int user_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er)
83 83
84static int user_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er) 84static int user_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er)
85{ 85{
86 struct inode *inode = ip->i_vnode; 86 struct inode *inode = &ip->i_inode;
87 87
88 if (S_ISREG(inode->i_mode) || 88 if (S_ISREG(inode->i_mode) ||
89 (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) { 89 (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
@@ -103,7 +103,7 @@ static int system_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er)
103 !capable(CAP_SYS_ADMIN)) 103 !capable(CAP_SYS_ADMIN))
104 return -EPERM; 104 return -EPERM;
105 105
106 if (ip->i_sbd->sd_args.ar_posix_acl == 0 && 106 if (GFS2_SB(&ip->i_inode)->sd_args.ar_posix_acl == 0 &&
107 (GFS2_ACL_IS_ACCESS(er->er_name, er->er_name_len) || 107 (GFS2_ACL_IS_ACCESS(er->er_name, er->er_name_len) ||
108 GFS2_ACL_IS_DEFAULT(er->er_name, er->er_name_len))) 108 GFS2_ACL_IS_DEFAULT(er->er_name, er->er_name_len)))
109 return -EOPNOTSUPP; 109 return -EOPNOTSUPP;
@@ -172,7 +172,7 @@ static int system_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er)
172 172
173static int security_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er) 173static int security_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er)
174{ 174{
175 struct inode *inode = ip->i_vnode; 175 struct inode *inode = &ip->i_inode;
176 int error = permission(inode, MAY_READ, NULL); 176 int error = permission(inode, MAY_READ, NULL);
177 if (error) 177 if (error)
178 return error; 178 return error;
@@ -182,7 +182,7 @@ static int security_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er)
182 182
183static int security_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er) 183static int security_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er)
184{ 184{
185 struct inode *inode = ip->i_vnode; 185 struct inode *inode = &ip->i_inode;
186 int error = permission(inode, MAY_WRITE, NULL); 186 int error = permission(inode, MAY_WRITE, NULL);
187 if (error) 187 if (error)
188 return error; 188 return error;
@@ -192,7 +192,7 @@ static int security_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er)
192 192
193static int security_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er) 193static int security_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er)
194{ 194{
195 struct inode *inode = ip->i_vnode; 195 struct inode *inode = &ip->i_inode;
196 int error = permission(inode, MAY_WRITE, NULL); 196 int error = permission(inode, MAY_WRITE, NULL);
197 if (error) 197 if (error)
198 return error; 198 return error;