diff options
author | Theodore Ts'o <tytso@mit.edu> | 2006-09-27 04:50:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:17 -0400 |
commit | 8e18e2941c53416aa219708e7dcad21fb4bd6794 (patch) | |
tree | 44118f8b09556193ac93e0b71aecfa3e1d4bc182 /fs/fuse | |
parent | 6a1d9805ec506d8b9d04450997707da5f643d87c (diff) |
[PATCH] inode_diet: Replace inode.u.generic_ip with inode.i_private
The following patches reduce the size of the VFS inode structure by 28 bytes
on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction
in the inode size on a UP kernel that is configured in a production mode
(i.e., with no spinlock or other debugging functions enabled; if you want to
save memory taken up by in-core inodes, the first thing you should do is
disable the debugging options; they are responsible for a huge amount of bloat
in the VFS inode structure).
This patch:
The filesystem or device-specific pointer in the inode is inside a union,
which is pretty pointless given that all 30+ users of this field have been
using the void pointer. Get rid of the union and rename it to i_private, with
a comment to explain who is allowed to use the void pointer. This is just a
cleanup, but it allows us to reuse the union 'u' for something something where
the union will actually be used.
[judith@osdl.org: powerpc build fix]
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Judith Lebzelter <judith@osdl.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/fuse')
-rw-r--r-- | fs/fuse/control.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/fuse/control.c b/fs/fuse/control.c index 46fe60b2da23..79ec1f23d4d2 100644 --- a/fs/fuse/control.c +++ b/fs/fuse/control.c | |||
@@ -23,7 +23,7 @@ static struct fuse_conn *fuse_ctl_file_conn_get(struct file *file) | |||
23 | { | 23 | { |
24 | struct fuse_conn *fc; | 24 | struct fuse_conn *fc; |
25 | mutex_lock(&fuse_mutex); | 25 | mutex_lock(&fuse_mutex); |
26 | fc = file->f_dentry->d_inode->u.generic_ip; | 26 | fc = file->f_dentry->d_inode->i_private; |
27 | if (fc) | 27 | if (fc) |
28 | fc = fuse_conn_get(fc); | 28 | fc = fuse_conn_get(fc); |
29 | mutex_unlock(&fuse_mutex); | 29 | mutex_unlock(&fuse_mutex); |
@@ -98,7 +98,7 @@ static struct dentry *fuse_ctl_add_dentry(struct dentry *parent, | |||
98 | inode->i_op = iop; | 98 | inode->i_op = iop; |
99 | inode->i_fop = fop; | 99 | inode->i_fop = fop; |
100 | inode->i_nlink = nlink; | 100 | inode->i_nlink = nlink; |
101 | inode->u.generic_ip = fc; | 101 | inode->i_private = fc; |
102 | d_add(dentry, inode); | 102 | d_add(dentry, inode); |
103 | return dentry; | 103 | return dentry; |
104 | } | 104 | } |
@@ -150,7 +150,7 @@ void fuse_ctl_remove_conn(struct fuse_conn *fc) | |||
150 | 150 | ||
151 | for (i = fc->ctl_ndents - 1; i >= 0; i--) { | 151 | for (i = fc->ctl_ndents - 1; i >= 0; i--) { |
152 | struct dentry *dentry = fc->ctl_dentry[i]; | 152 | struct dentry *dentry = fc->ctl_dentry[i]; |
153 | dentry->d_inode->u.generic_ip = NULL; | 153 | dentry->d_inode->i_private = NULL; |
154 | d_drop(dentry); | 154 | d_drop(dentry); |
155 | dput(dentry); | 155 | dput(dentry); |
156 | } | 156 | } |