diff options
author | Maxim Patlasov <mpatlasov@parallels.com> | 2013-03-21 10:02:28 -0400 |
---|---|---|
committer | Miklos Szeredi <mszeredi@suse.cz> | 2013-04-17 06:31:45 -0400 |
commit | 0aada88476a33690c9569b094191ce92a38e6541 (patch) | |
tree | 4aef3365654d4751154dc825731af721661fcef2 /fs/fuse/dev.c | |
parent | 796523fb24028639c007f71e02ca21730f7c0af6 (diff) |
fuse: skip blocking on allocations of synchronous requests
A task may have at most one synchronous request allocated. So these
requests need not be otherwise limited.
The patch re-works fuse_get_req() to follow this idea.
Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Diffstat (limited to 'fs/fuse/dev.c')
-rw-r--r-- | fs/fuse/dev.c | 30 |
1 files changed, 20 insertions, 10 deletions
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 39c2fe3ba93d..d692b85115bd 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c | |||
@@ -130,21 +130,30 @@ static void fuse_req_init_context(struct fuse_req *req) | |||
130 | req->in.h.pid = current->pid; | 130 | req->in.h.pid = current->pid; |
131 | } | 131 | } |
132 | 132 | ||
133 | static bool fuse_block_alloc(struct fuse_conn *fc, bool for_background) | ||
134 | { | ||
135 | return !fc->initialized || (for_background && fc->blocked); | ||
136 | } | ||
137 | |||
133 | static struct fuse_req *__fuse_get_req(struct fuse_conn *fc, unsigned npages, | 138 | static struct fuse_req *__fuse_get_req(struct fuse_conn *fc, unsigned npages, |
134 | bool for_background) | 139 | bool for_background) |
135 | { | 140 | { |
136 | struct fuse_req *req; | 141 | struct fuse_req *req; |
137 | sigset_t oldset; | ||
138 | int intr; | ||
139 | int err; | 142 | int err; |
140 | |||
141 | atomic_inc(&fc->num_waiting); | 143 | atomic_inc(&fc->num_waiting); |
142 | block_sigs(&oldset); | 144 | |
143 | intr = wait_event_interruptible(fc->blocked_waitq, !fc->blocked); | 145 | if (fuse_block_alloc(fc, for_background)) { |
144 | restore_sigs(&oldset); | 146 | sigset_t oldset; |
145 | err = -EINTR; | 147 | int intr; |
146 | if (intr) | 148 | |
147 | goto out; | 149 | block_sigs(&oldset); |
150 | intr = wait_event_interruptible(fc->blocked_waitq, | ||
151 | !fuse_block_alloc(fc, for_background)); | ||
152 | restore_sigs(&oldset); | ||
153 | err = -EINTR; | ||
154 | if (intr) | ||
155 | goto out; | ||
156 | } | ||
148 | 157 | ||
149 | err = -ENOTCONN; | 158 | err = -ENOTCONN; |
150 | if (!fc->connected) | 159 | if (!fc->connected) |
@@ -239,7 +248,7 @@ struct fuse_req *fuse_get_req_nofail_nopages(struct fuse_conn *fc, | |||
239 | struct fuse_req *req; | 248 | struct fuse_req *req; |
240 | 249 | ||
241 | atomic_inc(&fc->num_waiting); | 250 | atomic_inc(&fc->num_waiting); |
242 | wait_event(fc->blocked_waitq, !fc->blocked); | 251 | wait_event(fc->blocked_waitq, fc->initialized); |
243 | req = fuse_request_alloc(0); | 252 | req = fuse_request_alloc(0); |
244 | if (!req) | 253 | if (!req) |
245 | req = get_reserved_req(fc, file); | 254 | req = get_reserved_req(fc, file); |
@@ -2106,6 +2115,7 @@ int fuse_dev_release(struct inode *inode, struct file *file) | |||
2106 | spin_lock(&fc->lock); | 2115 | spin_lock(&fc->lock); |
2107 | fc->connected = 0; | 2116 | fc->connected = 0; |
2108 | fc->blocked = 0; | 2117 | fc->blocked = 0; |
2118 | fc->initialized = 1; | ||
2109 | end_queued_requests(fc); | 2119 | end_queued_requests(fc); |
2110 | end_polls(fc); | 2120 | end_polls(fc); |
2111 | wake_up_all(&fc->blocked_waitq); | 2121 | wake_up_all(&fc->blocked_waitq); |