diff options
author | Nick Piggin <npiggin@suse.de> | 2007-05-06 17:49:04 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-07 15:12:51 -0400 |
commit | 6fe6900e1e5b6fa9e5c59aa5061f244fe3f467e2 (patch) | |
tree | 8bbfe5072279227cc50a941ad4813908082426a1 /fs/freevxfs/vxfs_subr.c | |
parent | 714b8171af9c930a59a0da8f6fe50518e70ab035 (diff) |
mm: make read_cache_page synchronous
Ensure pages are uptodate after returning from read_cache_page, which allows
us to cut out most of the filesystem-internal PageUptodate calls.
I didn't have a great look down the call chains, but this appears to fixes 7
possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in
ecryptfs, 1 in jffs2, and a possible cleared data overwritten with readpage in
block2mtd. All depending on whether the filler is async and/or can return
with a !uptodate page.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/freevxfs/vxfs_subr.c')
-rw-r--r-- | fs/freevxfs/vxfs_subr.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/freevxfs/vxfs_subr.c b/fs/freevxfs/vxfs_subr.c index decac62efe57..ed8f0b0dd880 100644 --- a/fs/freevxfs/vxfs_subr.c +++ b/fs/freevxfs/vxfs_subr.c | |||
@@ -74,10 +74,7 @@ vxfs_get_page(struct address_space *mapping, u_long n) | |||
74 | pp = read_mapping_page(mapping, n, NULL); | 74 | pp = read_mapping_page(mapping, n, NULL); |
75 | 75 | ||
76 | if (!IS_ERR(pp)) { | 76 | if (!IS_ERR(pp)) { |
77 | wait_on_page_locked(pp); | ||
78 | kmap(pp); | 77 | kmap(pp); |
79 | if (!PageUptodate(pp)) | ||
80 | goto fail; | ||
81 | /** if (!PageChecked(pp)) **/ | 78 | /** if (!PageChecked(pp)) **/ |
82 | /** vxfs_check_page(pp); **/ | 79 | /** vxfs_check_page(pp); **/ |
83 | if (PageError(pp)) | 80 | if (PageError(pp)) |