diff options
author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2014-02-12 15:51:09 -0500 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2014-02-17 18:02:21 -0500 |
commit | add1f0995454374d90c9d6b2c420d2fba3d0a4e3 (patch) | |
tree | 8659ba52925b00f7843bb806f29c5cf4bae76348 /fs/file.c | |
parent | ae1670339c95c3ff96ab10582506cf827c5fecc8 (diff) |
fs: Substitute rcu_access_pointer() for rcu_dereference_raw()
(Trivial patch.)
If the code is looking at the RCU-protected pointer itself, but not
dereferencing it, the rcu_dereference() functions can be downgraded to
rcu_access_pointer(). This commit makes this downgrade in __alloc_fd(),
which simply compares the RCU-protected pointer against NULL with no
dereferencing.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Diffstat (limited to 'fs/file.c')
-rw-r--r-- | fs/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -497,7 +497,7 @@ repeat: | |||
497 | error = fd; | 497 | error = fd; |
498 | #if 1 | 498 | #if 1 |
499 | /* Sanity check */ | 499 | /* Sanity check */ |
500 | if (rcu_dereference_raw(fdt->fd[fd]) != NULL) { | 500 | if (rcu_access_pointer(fdt->fd[fd]) != NULL) { |
501 | printk(KERN_WARNING "alloc_fd: slot %d not NULL!\n", fd); | 501 | printk(KERN_WARNING "alloc_fd: slot %d not NULL!\n", fd); |
502 | rcu_assign_pointer(fdt->fd[fd], NULL); | 502 | rcu_assign_pointer(fdt->fd[fd], NULL); |
503 | } | 503 | } |