aboutsummaryrefslogtreecommitdiffstats
path: root/fs/fcntl.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2009-09-23 18:57:01 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2009-09-24 10:21:01 -0400
commit06f1631a1671bce2d59d58cb1debdf23e1803ebf (patch)
treed1c5cc02d8ceff4c50c098dce957ad63a09e84a5 /fs/fcntl.c
parent4a30debfb778240a4b1767d4b0c5a5b25ab97160 (diff)
signals: send_sigio: use do_send_sig_info() to avoid check_kill_permission()
group_send_sig_info()->check_kill_permission() assumes that current is the sender and uses current_cred(). This is not true in send_sigio_to_task() case. From the security pov the sender is not current, but the task which did fcntl(F_SETOWN), that is why we have sigio_perm() which uses the right creds to check. Fortunately, send_sigio() always sends either SEND_SIG_PRIV or SI_FROMKERNEL() signal, so check_kill_permission() does nothing. But still it would be tidier to avoid this bogus security check and save a couple of cycles. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: stephane eranian <eranian@googlemail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Roland McGrath <roland@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/fcntl.c')
-rw-r--r--fs/fcntl.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/fcntl.c b/fs/fcntl.c
index ae413086db97..50a988993262 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -461,11 +461,11 @@ static void send_sigio_to_task(struct task_struct *p,
461 else 461 else
462 si.si_band = band_table[reason - POLL_IN]; 462 si.si_band = band_table[reason - POLL_IN];
463 si.si_fd = fd; 463 si.si_fd = fd;
464 if (!group_send_sig_info(signum, &si, p)) 464 if (!do_send_sig_info(signum, &si, p, true))
465 break; 465 break;
466 /* fall-through: fall back on the old plain SIGIO signal */ 466 /* fall-through: fall back on the old plain SIGIO signal */
467 case 0: 467 case 0:
468 group_send_sig_info(SIGIO, SEND_SIG_PRIV, p); 468 do_send_sig_info(SIGIO, SEND_SIG_PRIV, p, true);
469 } 469 }
470} 470}
471 471