[PATCH] fat: fix slab cache leak

This patch plugs a slab cache leak in fat module initialization.

Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 14 insertions, 5 deletions

diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 8ccee8415488..3e31c4a736f1 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1331,12 +1331,21 @@ void __exit fat_cache_destroy(void);
 
 static int __init init_fat_fs(void)
 {
-        int ret;
+        int err;
 
-        ret = fat_cache_init();
-        if (ret < 0)
-                return ret;
-        return fat_init_inodecache();
+        err = fat_cache_init();
+        if (err)
+                return err;
+
+        err = fat_init_inodecache();
+        if (err)
+                goto failed;
+
+        return 0;
+
+failed:
+        fat_cache_destroy();
+        return err;
 }
 
 static void __exit exit_fat_fs(void)