diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/fat | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/fat')
-rw-r--r-- | fs/fat/inode.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 4978621511bf..2b88c93af227 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -451,6 +451,8 @@ static void fat_put_super(struct super_block *sb) | |||
451 | { | 451 | { |
452 | struct msdos_sb_info *sbi = MSDOS_SB(sb); | 452 | struct msdos_sb_info *sbi = MSDOS_SB(sb); |
453 | 453 | ||
454 | lock_kernel(); | ||
455 | |||
454 | if (sb->s_dirt) | 456 | if (sb->s_dirt) |
455 | fat_write_super(sb); | 457 | fat_write_super(sb); |
456 | 458 | ||
@@ -470,6 +472,8 @@ static void fat_put_super(struct super_block *sb) | |||
470 | 472 | ||
471 | sb->s_fs_info = NULL; | 473 | sb->s_fs_info = NULL; |
472 | kfree(sbi); | 474 | kfree(sbi); |
475 | |||
476 | unlock_kernel(); | ||
473 | } | 477 | } |
474 | 478 | ||
475 | static struct kmem_cache *fat_inode_cachep; | 479 | static struct kmem_cache *fat_inode_cachep; |