diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-11 17:35:03 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:09 -0400 |
commit | ebc1ac164560a241d9bf1b7519062910c3f90a01 (patch) | |
tree | db17fd3043b15f8269cce2c2d00213814022fc30 /fs/fat/inode.c | |
parent | 01ba687577647beef6c5f2ea59bfb56fac9fcde2 (diff) |
->write_super lock_super pushdown
Push down lock_super into ->write_super instances and remove it from the
caller.
Following filesystem don't need ->s_lock in ->write_super and are skipped:
* bfs, nilfs2 - no other uses of s_lock and have internal locks in
->write_super
* ext2 - uses BKL in ext2_write_super and has internal calls without s_lock
* reiserfs - no other uses of s_lock as has reiserfs_write_lock (BKL) in
->write_super
* xfs - no other uses of s_lock and uses internal lock (buffer lock on
superblock buffer) to serialize ->write_super. Also xfs_fs_write_super
is superflous and will go away in the next merge window
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/fat/inode.c')
-rw-r--r-- | fs/fat/inode.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 2b88c93af227..2292cbf7d364 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -441,10 +441,12 @@ static void fat_clear_inode(struct inode *inode) | |||
441 | 441 | ||
442 | static void fat_write_super(struct super_block *sb) | 442 | static void fat_write_super(struct super_block *sb) |
443 | { | 443 | { |
444 | lock_super(sb); | ||
444 | sb->s_dirt = 0; | 445 | sb->s_dirt = 0; |
445 | 446 | ||
446 | if (!(sb->s_flags & MS_RDONLY)) | 447 | if (!(sb->s_flags & MS_RDONLY)) |
447 | fat_clusters_flush(sb); | 448 | fat_clusters_flush(sb); |
449 | unlock_super(sb); | ||
448 | } | 450 | } |
449 | 451 | ||
450 | static void fat_put_super(struct super_block *sb) | 452 | static void fat_put_super(struct super_block *sb) |