diff options
author | Namjae Jeon <namjae.jeon@samsung.com> | 2013-02-02 09:52:28 -0500 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk.kim@samsung.com> | 2013-02-11 17:15:02 -0500 |
commit | ec7b1f2dd180afb1ce23aa44a7451e59bf2f3eb3 (patch) | |
tree | 2f9a08b3f69b1ee5fa2ec2dfba8ef0d7268f33df /fs/f2fs | |
parent | 48600e44c18e4eb0f7c02ec8633c4c56aef292f0 (diff) |
f2fs: name gc task as per the block device
Currently GC task is started for each f2fs formatted/mounted device.
But, when we check the task list, using 'ps', there is no distinguishing
factor between the tasks. So, name the task as per the block device just
like the flusher threads.
Also, remove the macro GC_THREAD_NAME and instead use the name: f2fs_gc
to avoid name length truncation, as the command length is 16
-> TASK_COMM_LEN 16 and example name like:
f2fs_gc_task:8:16 -> this exceeds name length
Before Patch for 2 F2FS formatted partitions:
root 28061 0.0 0.0 0 0 ? S 10:31 0:00 [f2fs_gc_task]
root 28087 0.0 0.0 0 0 ? S 10:32 0:00 [f2fs_gc_task]
After Patch:
root 16756 0.0 0.0 0 0 ? S 14:57 0:00 [f2fs_gc-8:18]
root 16765 0.0 0.0 0 0 ? S 14:57 0:00 [f2fs_gc-8:19]
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs/f2fs')
-rw-r--r-- | fs/f2fs/gc.c | 3 | ||||
-rw-r--r-- | fs/f2fs/gc.h | 1 |
2 files changed, 2 insertions, 2 deletions
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 8d293cb685ba..b1e498503e59 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c | |||
@@ -90,6 +90,7 @@ static int gc_thread_func(void *data) | |||
90 | int start_gc_thread(struct f2fs_sb_info *sbi) | 90 | int start_gc_thread(struct f2fs_sb_info *sbi) |
91 | { | 91 | { |
92 | struct f2fs_gc_kthread *gc_th; | 92 | struct f2fs_gc_kthread *gc_th; |
93 | dev_t dev = sbi->sb->s_bdev->bd_dev; | ||
93 | 94 | ||
94 | if (!test_opt(sbi, BG_GC)) | 95 | if (!test_opt(sbi, BG_GC)) |
95 | return 0; | 96 | return 0; |
@@ -100,7 +101,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi) | |||
100 | sbi->gc_thread = gc_th; | 101 | sbi->gc_thread = gc_th; |
101 | init_waitqueue_head(&sbi->gc_thread->gc_wait_queue_head); | 102 | init_waitqueue_head(&sbi->gc_thread->gc_wait_queue_head); |
102 | sbi->gc_thread->f2fs_gc_task = kthread_run(gc_thread_func, sbi, | 103 | sbi->gc_thread->f2fs_gc_task = kthread_run(gc_thread_func, sbi, |
103 | GC_THREAD_NAME); | 104 | "f2fs_gc-%u:%u", MAJOR(dev), MINOR(dev)); |
104 | if (IS_ERR(gc_th->f2fs_gc_task)) { | 105 | if (IS_ERR(gc_th->f2fs_gc_task)) { |
105 | kfree(gc_th); | 106 | kfree(gc_th); |
106 | return -ENOMEM; | 107 | return -ENOMEM; |
diff --git a/fs/f2fs/gc.h b/fs/f2fs/gc.h index b026d9354ccd..3abdf83b5c16 100644 --- a/fs/f2fs/gc.h +++ b/fs/f2fs/gc.h | |||
@@ -8,7 +8,6 @@ | |||
8 | * it under the terms of the GNU General Public License version 2 as | 8 | * it under the terms of the GNU General Public License version 2 as |
9 | * published by the Free Software Foundation. | 9 | * published by the Free Software Foundation. |
10 | */ | 10 | */ |
11 | #define GC_THREAD_NAME "f2fs_gc_task" | ||
12 | #define GC_THREAD_MIN_WB_PAGES 1 /* | 11 | #define GC_THREAD_MIN_WB_PAGES 1 /* |
13 | * a threshold to determine | 12 | * a threshold to determine |
14 | * whether IO subsystem is idle | 13 | * whether IO subsystem is idle |