diff options
author | Chao Yu <chao2.yu@samsung.com> | 2014-07-03 06:58:39 -0400 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2014-07-31 02:28:37 -0400 |
commit | b3582c68920105e29d219714d8a6fbde25a43379 (patch) | |
tree | 200ab9ca194921c8baad9954fee36eee072a772f /fs/f2fs/checkpoint.c | |
parent | 65b85ccce03f17b3098273192b20885f3fead820 (diff) |
f2fs: reduce competition among node page writes
We do not need to block on ->node_write among different node page writers e.g.
fsync/flush, unless we have a node page writer from write_checkpoint.
So it's better use rw_semaphore instead of mutex type for ->node_write to
promote performance.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/checkpoint.c')
-rw-r--r-- | fs/f2fs/checkpoint.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index cea20b810f44..6aeed5bada52 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c | |||
@@ -762,10 +762,10 @@ retry_flush_dents: | |||
762 | * until finishing nat/sit flush. | 762 | * until finishing nat/sit flush. |
763 | */ | 763 | */ |
764 | retry_flush_nodes: | 764 | retry_flush_nodes: |
765 | mutex_lock(&sbi->node_write); | 765 | down_write(&sbi->node_write); |
766 | 766 | ||
767 | if (get_pages(sbi, F2FS_DIRTY_NODES)) { | 767 | if (get_pages(sbi, F2FS_DIRTY_NODES)) { |
768 | mutex_unlock(&sbi->node_write); | 768 | up_write(&sbi->node_write); |
769 | sync_node_pages(sbi, 0, &wbc); | 769 | sync_node_pages(sbi, 0, &wbc); |
770 | goto retry_flush_nodes; | 770 | goto retry_flush_nodes; |
771 | } | 771 | } |
@@ -774,7 +774,7 @@ retry_flush_nodes: | |||
774 | 774 | ||
775 | static void unblock_operations(struct f2fs_sb_info *sbi) | 775 | static void unblock_operations(struct f2fs_sb_info *sbi) |
776 | { | 776 | { |
777 | mutex_unlock(&sbi->node_write); | 777 | up_write(&sbi->node_write); |
778 | f2fs_unlock_all(sbi); | 778 | f2fs_unlock_all(sbi); |
779 | } | 779 | } |
780 | 780 | ||