aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2009-09-29 15:51:30 -0400
committerTheodore Ts'o <tytso@mit.edu>2009-09-29 15:51:30 -0400
commit90576c0b9a0b5323fc4bd7f23f49be0d234f36d1 (patch)
treed4a1ab6f923f1c9c7c87f13a828db72c1f4412c1 /fs/ext4
parentd3d1faf6a74496ea4435fd057c6a2cad49f3e523 (diff)
ext4, jbd2: Drop unneeded printks at mount and unmount time
There are a number of kernel printk's which are printed when an ext4 filesystem is mounted and unmounted. Disable them to economize space in the system logs. In addition, disabling the mballoc stats by default saves a number of unneeded atomic operations for every block allocation or deallocation. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
-rw-r--r--fs/ext4/extents.c2
-rw-r--r--fs/ext4/mballoc.c2
-rw-r--r--fs/ext4/mballoc.h2
-rw-r--r--fs/ext4/super.c17
4 files changed, 7 insertions, 16 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 10a63096a95a..10539e364283 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2380,6 +2380,7 @@ void ext4_ext_init(struct super_block *sb)
2380 */ 2380 */
2381 2381
2382 if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS)) { 2382 if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS)) {
2383#if defined(AGGRESSIVE_TEST) || defined(CHECK_BINSEARCH) || defined(EXTENTS_STATS)
2383 printk(KERN_INFO "EXT4-fs: file extents enabled"); 2384 printk(KERN_INFO "EXT4-fs: file extents enabled");
2384#ifdef AGGRESSIVE_TEST 2385#ifdef AGGRESSIVE_TEST
2385 printk(", aggressive tests"); 2386 printk(", aggressive tests");
@@ -2391,6 +2392,7 @@ void ext4_ext_init(struct super_block *sb)
2391 printk(", stats"); 2392 printk(", stats");
2392#endif 2393#endif
2393 printk("\n"); 2394 printk("\n");
2395#endif
2394#ifdef EXTENTS_STATS 2396#ifdef EXTENTS_STATS
2395 spin_lock_init(&EXT4_SB(sb)->s_ext_stats_lock); 2397 spin_lock_init(&EXT4_SB(sb)->s_ext_stats_lock);
2396 EXT4_SB(sb)->s_ext_min = 1 << 30; 2398 EXT4_SB(sb)->s_ext_min = 1 << 30;
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index c73d43995b13..3e2320e66721 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2712,8 +2712,6 @@ int ext4_mb_init(struct super_block *sb, int needs_recovery)
2712 2712
2713 if (sbi->s_journal) 2713 if (sbi->s_journal)
2714 sbi->s_journal->j_commit_callback = release_blocks_on_commit; 2714 sbi->s_journal->j_commit_callback = release_blocks_on_commit;
2715
2716 printk(KERN_INFO "EXT4-fs: mballoc enabled\n");
2717 return 0; 2715 return 0;
2718} 2716}
2719 2717
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index 188d3d709b24..14f25f253112 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -84,7 +84,7 @@ extern u8 mb_enable_debug;
84 * with 'ext4_mb_stats' allocator will collect stats that will be 84 * with 'ext4_mb_stats' allocator will collect stats that will be
85 * shown at umount. The collecting costs though! 85 * shown at umount. The collecting costs though!
86 */ 86 */
87#define MB_DEFAULT_STATS 1 87#define MB_DEFAULT_STATS 0
88 88
89/* 89/*
90 * files smaller than MB_DEFAULT_STREAM_THRESHOLD are served 90 * files smaller than MB_DEFAULT_STREAM_THRESHOLD are served
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 3f7e7010c098..e5b206a043a5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1673,13 +1673,6 @@ static int ext4_setup_super(struct super_block *sb, struct ext4_super_block *es,
1673 EXT4_INODES_PER_GROUP(sb), 1673 EXT4_INODES_PER_GROUP(sb),
1674 sbi->s_mount_opt); 1674 sbi->s_mount_opt);
1675 1675
1676 if (EXT4_SB(sb)->s_journal) {
1677 ext4_msg(sb, KERN_INFO, "%s journal on %s",
1678 EXT4_SB(sb)->s_journal->j_inode ? "internal" :
1679 "external", EXT4_SB(sb)->s_journal->j_devname);
1680 } else {
1681 ext4_msg(sb, KERN_INFO, "no journal");
1682 }
1683 return res; 1676 return res;
1684} 1677}
1685 1678
@@ -2885,12 +2878,12 @@ no_journal:
2885 "available"); 2878 "available");
2886 } 2879 }
2887 2880
2888 if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) { 2881 if (test_opt(sb, DELALLOC) &&
2882 (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA)) {
2889 ext4_msg(sb, KERN_WARNING, "Ignoring delalloc option - " 2883 ext4_msg(sb, KERN_WARNING, "Ignoring delalloc option - "
2890 "requested data journaling mode"); 2884 "requested data journaling mode");
2891 clear_opt(sbi->s_mount_opt, DELALLOC); 2885 clear_opt(sbi->s_mount_opt, DELALLOC);
2892 } else if (test_opt(sb, DELALLOC)) 2886 }
2893 ext4_msg(sb, KERN_INFO, "delayed allocation enabled");
2894 2887
2895 err = ext4_setup_system_zone(sb); 2888 err = ext4_setup_system_zone(sb);
2896 if (err) { 2889 if (err) {
@@ -3202,9 +3195,7 @@ static int ext4_load_journal(struct super_block *sb,
3202 return -EINVAL; 3195 return -EINVAL;
3203 } 3196 }
3204 3197
3205 if (journal->j_flags & JBD2_BARRIER) 3198 if (!(journal->j_flags & JBD2_BARRIER))
3206 ext4_msg(sb, KERN_INFO, "barriers enabled");
3207 else
3208 ext4_msg(sb, KERN_INFO, "barriers disabled"); 3199 ext4_msg(sb, KERN_INFO, "barriers disabled");
3209 3200
3210 if (!really_read_only && test_opt(sb, UPDATE_JOURNAL)) { 3201 if (!really_read_only && test_opt(sb, UPDATE_JOURNAL)) {