diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-01 13:57:49 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-01 13:57:49 -0400 |
commit | 395d73413c5656c6d7706ae91dcb441f9b7e3074 (patch) | |
tree | 7fadabe996f70d7918583fa2312d4fad19397fcb /fs/ext4 | |
parent | c226fd659fa7b6a7b038df5ae6856a68514bacde (diff) | |
parent | 06705bff9114531a997a7d0c2520bea0f2927410 (diff) |
Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
* 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: (33 commits)
ext4: Regularize mount options
ext4: fix locking typo in mballoc which could cause soft lockup hangs
ext4: fix typo which causes a memory leak on error path
jbd2: Update locking coments
ext4: Rename pa_linear to pa_type
ext4: add checks of block references for non-extent inodes
ext4: Check for an valid i_mode when reading the inode from disk
ext4: Use WRITE_SYNC for commits which are caused by fsync()
ext4: Add auto_da_alloc mount option
ext4: Use struct flex_groups to calculate get_orlov_stats()
ext4: Use atomic_t's in struct flex_groups
ext4: remove /proc tuning knobs
ext4: Add sysfs support
ext4: Track lifetime disk writes
ext4: Fix discard of inode prealloc space with delayed allocation.
ext4: Automatically allocate delay allocated blocks on rename
ext4: Automatically allocate delay allocated blocks on close
ext4: add EXT4_IOC_ALLOC_DA_BLKS ioctl
ext4: Simplify delalloc code by removing mpage_da_writepages()
ext4: Save stack space by removing fake buffer heads
...
Diffstat (limited to 'fs/ext4')
-rw-r--r-- | fs/ext4/balloc.c | 14 | ||||
-rw-r--r-- | fs/ext4/dir.c | 16 | ||||
-rw-r--r-- | fs/ext4/ext4.h | 91 | ||||
-rw-r--r-- | fs/ext4/ext4_extents.h | 1 | ||||
-rw-r--r-- | fs/ext4/ext4_i.h | 6 | ||||
-rw-r--r-- | fs/ext4/ext4_sb.h | 14 | ||||
-rw-r--r-- | fs/ext4/extents.c | 127 | ||||
-rw-r--r-- | fs/ext4/file.c | 7 | ||||
-rw-r--r-- | fs/ext4/ialloc.c | 273 | ||||
-rw-r--r-- | fs/ext4/inode.c | 424 | ||||
-rw-r--r-- | fs/ext4/ioctl.c | 17 | ||||
-rw-r--r-- | fs/ext4/mballoc.c | 158 | ||||
-rw-r--r-- | fs/ext4/mballoc.h | 8 | ||||
-rw-r--r-- | fs/ext4/namei.c | 164 | ||||
-rw-r--r-- | fs/ext4/resize.c | 8 | ||||
-rw-r--r-- | fs/ext4/super.c | 327 |
16 files changed, 1085 insertions, 570 deletions
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index 38f40d55899c..53c72ad85877 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
@@ -55,7 +55,8 @@ static int ext4_block_in_group(struct super_block *sb, ext4_fsblk_t block, | |||
55 | } | 55 | } |
56 | 56 | ||
57 | static int ext4_group_used_meta_blocks(struct super_block *sb, | 57 | static int ext4_group_used_meta_blocks(struct super_block *sb, |
58 | ext4_group_t block_group) | 58 | ext4_group_t block_group, |
59 | struct ext4_group_desc *gdp) | ||
59 | { | 60 | { |
60 | ext4_fsblk_t tmp; | 61 | ext4_fsblk_t tmp; |
61 | struct ext4_sb_info *sbi = EXT4_SB(sb); | 62 | struct ext4_sb_info *sbi = EXT4_SB(sb); |
@@ -63,10 +64,6 @@ static int ext4_group_used_meta_blocks(struct super_block *sb, | |||
63 | int used_blocks = sbi->s_itb_per_group + 2; | 64 | int used_blocks = sbi->s_itb_per_group + 2; |
64 | 65 | ||
65 | if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG)) { | 66 | if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG)) { |
66 | struct ext4_group_desc *gdp; | ||
67 | struct buffer_head *bh; | ||
68 | |||
69 | gdp = ext4_get_group_desc(sb, block_group, &bh); | ||
70 | if (!ext4_block_in_group(sb, ext4_block_bitmap(sb, gdp), | 67 | if (!ext4_block_in_group(sb, ext4_block_bitmap(sb, gdp), |
71 | block_group)) | 68 | block_group)) |
72 | used_blocks--; | 69 | used_blocks--; |
@@ -177,7 +174,7 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
177 | */ | 174 | */ |
178 | mark_bitmap_end(group_blocks, sb->s_blocksize * 8, bh->b_data); | 175 | mark_bitmap_end(group_blocks, sb->s_blocksize * 8, bh->b_data); |
179 | } | 176 | } |
180 | return free_blocks - ext4_group_used_meta_blocks(sb, block_group); | 177 | return free_blocks - ext4_group_used_meta_blocks(sb, block_group, gdp); |
181 | } | 178 | } |
182 | 179 | ||
183 | 180 | ||
@@ -473,9 +470,8 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, | |||
473 | 470 | ||
474 | if (sbi->s_log_groups_per_flex) { | 471 | if (sbi->s_log_groups_per_flex) { |
475 | ext4_group_t flex_group = ext4_flex_group(sbi, block_group); | 472 | ext4_group_t flex_group = ext4_flex_group(sbi, block_group); |
476 | spin_lock(sb_bgl_lock(sbi, flex_group)); | 473 | atomic_add(blocks_freed, |
477 | sbi->s_flex_groups[flex_group].free_blocks += blocks_freed; | 474 | &sbi->s_flex_groups[flex_group].free_blocks); |
478 | spin_unlock(sb_bgl_lock(sbi, flex_group)); | ||
479 | } | 475 | } |
480 | /* | 476 | /* |
481 | * request to reload the buddy with the | 477 | * request to reload the buddy with the |
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 2df2e40b01af..b64789929a65 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c | |||
@@ -67,7 +67,8 @@ int ext4_check_dir_entry(const char *function, struct inode *dir, | |||
67 | unsigned int offset) | 67 | unsigned int offset) |
68 | { | 68 | { |
69 | const char *error_msg = NULL; | 69 | const char *error_msg = NULL; |
70 | const int rlen = ext4_rec_len_from_disk(de->rec_len); | 70 | const int rlen = ext4_rec_len_from_disk(de->rec_len, |
71 | dir->i_sb->s_blocksize); | ||
71 | 72 | ||
72 | if (rlen < EXT4_DIR_REC_LEN(1)) | 73 | if (rlen < EXT4_DIR_REC_LEN(1)) |
73 | error_msg = "rec_len is smaller than minimal"; | 74 | error_msg = "rec_len is smaller than minimal"; |
@@ -178,10 +179,11 @@ revalidate: | |||
178 | * least that it is non-zero. A | 179 | * least that it is non-zero. A |
179 | * failure will be detected in the | 180 | * failure will be detected in the |
180 | * dirent test below. */ | 181 | * dirent test below. */ |
181 | if (ext4_rec_len_from_disk(de->rec_len) | 182 | if (ext4_rec_len_from_disk(de->rec_len, |
182 | < EXT4_DIR_REC_LEN(1)) | 183 | sb->s_blocksize) < EXT4_DIR_REC_LEN(1)) |
183 | break; | 184 | break; |
184 | i += ext4_rec_len_from_disk(de->rec_len); | 185 | i += ext4_rec_len_from_disk(de->rec_len, |
186 | sb->s_blocksize); | ||
185 | } | 187 | } |
186 | offset = i; | 188 | offset = i; |
187 | filp->f_pos = (filp->f_pos & ~(sb->s_blocksize - 1)) | 189 | filp->f_pos = (filp->f_pos & ~(sb->s_blocksize - 1)) |
@@ -203,7 +205,8 @@ revalidate: | |||
203 | ret = stored; | 205 | ret = stored; |
204 | goto out; | 206 | goto out; |
205 | } | 207 | } |
206 | offset += ext4_rec_len_from_disk(de->rec_len); | 208 | offset += ext4_rec_len_from_disk(de->rec_len, |
209 | sb->s_blocksize); | ||
207 | if (le32_to_cpu(de->inode)) { | 210 | if (le32_to_cpu(de->inode)) { |
208 | /* We might block in the next section | 211 | /* We might block in the next section |
209 | * if the data destination is | 212 | * if the data destination is |
@@ -225,7 +228,8 @@ revalidate: | |||
225 | goto revalidate; | 228 | goto revalidate; |
226 | stored++; | 229 | stored++; |
227 | } | 230 | } |
228 | filp->f_pos += ext4_rec_len_from_disk(de->rec_len); | 231 | filp->f_pos += ext4_rec_len_from_disk(de->rec_len, |
232 | sb->s_blocksize); | ||
229 | } | 233 | } |
230 | offset = 0; | 234 | offset = 0; |
231 | brelse(bh); | 235 | brelse(bh); |
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 990c94000924..d0f15ef56de1 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
@@ -33,14 +33,6 @@ | |||
33 | #undef EXT4FS_DEBUG | 33 | #undef EXT4FS_DEBUG |
34 | 34 | ||
35 | /* | 35 | /* |
36 | * Define EXT4_RESERVATION to reserve data blocks for expanding files | ||
37 | */ | ||
38 | #define EXT4_DEFAULT_RESERVE_BLOCKS 8 | ||
39 | /*max window size: 1024(direct blocks) + 3([t,d]indirect blocks) */ | ||
40 | #define EXT4_MAX_RESERVE_BLOCKS 1027 | ||
41 | #define EXT4_RESERVE_WINDOW_NOT_ALLOCATED 0 | ||
42 | |||
43 | /* | ||
44 | * Debug code | 36 | * Debug code |
45 | */ | 37 | */ |
46 | #ifdef EXT4FS_DEBUG | 38 | #ifdef EXT4FS_DEBUG |
@@ -54,8 +46,6 @@ | |||
54 | #define ext4_debug(f, a...) do {} while (0) | 46 | #define ext4_debug(f, a...) do {} while (0) |
55 | #endif | 47 | #endif |
56 | 48 | ||
57 | #define EXT4_MULTIBLOCK_ALLOCATOR 1 | ||
58 | |||
59 | /* prefer goal again. length */ | 49 | /* prefer goal again. length */ |
60 | #define EXT4_MB_HINT_MERGE 1 | 50 | #define EXT4_MB_HINT_MERGE 1 |
61 | /* blocks already reserved */ | 51 | /* blocks already reserved */ |
@@ -180,8 +170,9 @@ struct ext4_group_desc | |||
180 | */ | 170 | */ |
181 | 171 | ||
182 | struct flex_groups { | 172 | struct flex_groups { |
183 | __u32 free_inodes; | 173 | atomic_t free_inodes; |
184 | __u32 free_blocks; | 174 | atomic_t free_blocks; |
175 | atomic_t used_dirs; | ||
185 | }; | 176 | }; |
186 | 177 | ||
187 | #define EXT4_BG_INODE_UNINIT 0x0001 /* Inode table/bitmap not in use */ | 178 | #define EXT4_BG_INODE_UNINIT 0x0001 /* Inode table/bitmap not in use */ |
@@ -249,6 +240,30 @@ struct flex_groups { | |||
249 | #define EXT4_FL_USER_VISIBLE 0x000BDFFF /* User visible flags */ | 240 | #define EXT4_FL_USER_VISIBLE 0x000BDFFF /* User visible flags */ |
250 | #define EXT4_FL_USER_MODIFIABLE 0x000B80FF /* User modifiable flags */ | 241 | #define EXT4_FL_USER_MODIFIABLE 0x000B80FF /* User modifiable flags */ |
251 | 242 | ||
243 | /* Flags that should be inherited by new inodes from their parent. */ | ||
244 | #define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\ | ||
245 | EXT4_SYNC_FL | EXT4_IMMUTABLE_FL | EXT4_APPEND_FL |\ | ||
246 | EXT4_NODUMP_FL | EXT4_NOATIME_FL |\ | ||
247 | EXT4_NOCOMPR_FL | EXT4_JOURNAL_DATA_FL |\ | ||
248 | EXT4_NOTAIL_FL | EXT4_DIRSYNC_FL) | ||
249 | |||
250 | /* Flags that are appropriate for regular files (all but dir-specific ones). */ | ||
251 | #define EXT4_REG_FLMASK (~(EXT4_DIRSYNC_FL | EXT4_TOPDIR_FL)) | ||
252 | |||
253 | /* Flags that are appropriate for non-directories/regular files. */ | ||
254 | #define EXT4_OTHER_FLMASK (EXT4_NODUMP_FL | EXT4_NOATIME_FL) | ||
255 | |||
256 | /* Mask out flags that are inappropriate for the given type of inode. */ | ||
257 | static inline __u32 ext4_mask_flags(umode_t mode, __u32 flags) | ||
258 | { | ||
259 | if (S_ISDIR(mode)) | ||
260 | return flags; | ||
261 | else if (S_ISREG(mode)) | ||
262 | return flags & EXT4_REG_FLMASK; | ||
263 | else | ||
264 | return flags & EXT4_OTHER_FLMASK; | ||
265 | } | ||
266 | |||
252 | /* | 267 | /* |
253 | * Inode dynamic state flags | 268 | * Inode dynamic state flags |
254 | */ | 269 | */ |
@@ -256,6 +271,7 @@ struct flex_groups { | |||
256 | #define EXT4_STATE_NEW 0x00000002 /* inode is newly created */ | 271 | #define EXT4_STATE_NEW 0x00000002 /* inode is newly created */ |
257 | #define EXT4_STATE_XATTR 0x00000004 /* has in-inode xattrs */ | 272 | #define EXT4_STATE_XATTR 0x00000004 /* has in-inode xattrs */ |
258 | #define EXT4_STATE_NO_EXPAND 0x00000008 /* No space for expansion */ | 273 | #define EXT4_STATE_NO_EXPAND 0x00000008 /* No space for expansion */ |
274 | #define EXT4_STATE_DA_ALLOC_CLOSE 0x00000010 /* Alloc DA blks on close */ | ||
259 | 275 | ||
260 | /* Used to pass group descriptor data when online resize is done */ | 276 | /* Used to pass group descriptor data when online resize is done */ |
261 | struct ext4_new_group_input { | 277 | struct ext4_new_group_input { |
@@ -303,7 +319,9 @@ struct ext4_new_group_data { | |||
303 | #define EXT4_IOC_GROUP_EXTEND _IOW('f', 7, unsigned long) | 319 | #define EXT4_IOC_GROUP_EXTEND _IOW('f', 7, unsigned long) |
304 | #define EXT4_IOC_GROUP_ADD _IOW('f', 8, struct ext4_new_group_input) | 320 | #define EXT4_IOC_GROUP_ADD _IOW('f', 8, struct ext4_new_group_input) |
305 | #define EXT4_IOC_MIGRATE _IO('f', 9) | 321 | #define EXT4_IOC_MIGRATE _IO('f', 9) |
322 | /* note ioctl 10 reserved for an early version of the FIEMAP ioctl */ | ||
306 | /* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */ | 323 | /* note ioctl 11 reserved for filesystem-independent FIEMAP ioctl */ |
324 | #define EXT4_IOC_ALLOC_DA_BLKS _IO('f', 12) | ||
307 | 325 | ||
308 | /* | 326 | /* |
309 | * ioctl commands in 32 bit emulation | 327 | * ioctl commands in 32 bit emulation |
@@ -531,7 +549,7 @@ do { \ | |||
531 | #define EXT4_MOUNT_NO_UID32 0x02000 /* Disable 32-bit UIDs */ | 549 | #define EXT4_MOUNT_NO_UID32 0x02000 /* Disable 32-bit UIDs */ |
532 | #define EXT4_MOUNT_XATTR_USER 0x04000 /* Extended user attributes */ | 550 | #define EXT4_MOUNT_XATTR_USER 0x04000 /* Extended user attributes */ |
533 | #define EXT4_MOUNT_POSIX_ACL 0x08000 /* POSIX Access Control Lists */ | 551 | #define EXT4_MOUNT_POSIX_ACL 0x08000 /* POSIX Access Control Lists */ |
534 | #define EXT4_MOUNT_RESERVATION 0x10000 /* Preallocation */ | 552 | #define EXT4_MOUNT_NO_AUTO_DA_ALLOC 0x10000 /* No auto delalloc mapping */ |
535 | #define EXT4_MOUNT_BARRIER 0x20000 /* Use block barriers */ | 553 | #define EXT4_MOUNT_BARRIER 0x20000 /* Use block barriers */ |
536 | #define EXT4_MOUNT_NOBH 0x40000 /* No bufferheads */ | 554 | #define EXT4_MOUNT_NOBH 0x40000 /* No bufferheads */ |
537 | #define EXT4_MOUNT_QUOTA 0x80000 /* Some quota option set */ | 555 | #define EXT4_MOUNT_QUOTA 0x80000 /* Some quota option set */ |
@@ -666,7 +684,8 @@ struct ext4_super_block { | |||
666 | __u8 s_log_groups_per_flex; /* FLEX_BG group size */ | 684 | __u8 s_log_groups_per_flex; /* FLEX_BG group size */ |
667 | __u8 s_reserved_char_pad2; | 685 | __u8 s_reserved_char_pad2; |
668 | __le16 s_reserved_pad; | 686 | __le16 s_reserved_pad; |
669 | __u32 s_reserved[162]; /* Padding to the end of the block */ | 687 | __le64 s_kbytes_written; /* nr of lifetime kilobytes written */ |
688 | __u32 s_reserved[160]; /* Padding to the end of the block */ | ||
670 | }; | 689 | }; |
671 | 690 | ||
672 | #ifdef __KERNEL__ | 691 | #ifdef __KERNEL__ |
@@ -814,6 +833,12 @@ static inline int ext4_valid_inum(struct super_block *sb, unsigned long ino) | |||
814 | #define EXT4_DEF_MAX_BATCH_TIME 15000 /* 15ms */ | 833 | #define EXT4_DEF_MAX_BATCH_TIME 15000 /* 15ms */ |
815 | 834 | ||
816 | /* | 835 | /* |
836 | * Minimum number of groups in a flexgroup before we separate out | ||
837 | * directories into the first block group of a flexgroup | ||
838 | */ | ||
839 | #define EXT4_FLEX_SIZE_DIR_ALLOC_SCHEME 4 | ||
840 | |||
841 | /* | ||
817 | * Structure of a directory entry | 842 | * Structure of a directory entry |
818 | */ | 843 | */ |
819 | #define EXT4_NAME_LEN 255 | 844 | #define EXT4_NAME_LEN 255 |
@@ -865,24 +890,6 @@ struct ext4_dir_entry_2 { | |||
865 | ~EXT4_DIR_ROUND) | 890 | ~EXT4_DIR_ROUND) |
866 | #define EXT4_MAX_REC_LEN ((1<<16)-1) | 891 | #define EXT4_MAX_REC_LEN ((1<<16)-1) |
867 | 892 | ||
868 | static inline unsigned ext4_rec_len_from_disk(__le16 dlen) | ||
869 | { | ||
870 | unsigned len = le16_to_cpu(dlen); | ||
871 | |||
872 | if (len == EXT4_MAX_REC_LEN || len == 0) | ||
873 | return 1 << 16; | ||
874 | return len; | ||
875 | } | ||
876 | |||
877 | static inline __le16 ext4_rec_len_to_disk(unsigned len) | ||
878 | { | ||
879 | if (len == (1 << 16)) | ||
880 | return cpu_to_le16(EXT4_MAX_REC_LEN); | ||
881 | else if (len > (1 << 16)) | ||
882 | BUG(); | ||
883 | return cpu_to_le16(len); | ||
884 | } | ||
885 | |||
886 | /* | 893 | /* |
887 | * Hash Tree Directory indexing | 894 | * Hash Tree Directory indexing |
888 | * (c) Daniel Phillips, 2001 | 895 | * (c) Daniel Phillips, 2001 |
@@ -970,22 +977,6 @@ void ext4_get_group_no_and_offset(struct super_block *sb, ext4_fsblk_t blocknr, | |||
970 | 977 | ||
971 | extern struct proc_dir_entry *ext4_proc_root; | 978 | extern struct proc_dir_entry *ext4_proc_root; |
972 | 979 | ||
973 | #ifdef CONFIG_PROC_FS | ||
974 | extern const struct file_operations ext4_ui_proc_fops; | ||
975 | |||
976 | #define EXT4_PROC_HANDLER(name, var) \ | ||
977 | do { \ | ||
978 | proc = proc_create_data(name, mode, sbi->s_proc, \ | ||
979 | &ext4_ui_proc_fops, &sbi->s_##var); \ | ||
980 | if (proc == NULL) { \ | ||
981 | printk(KERN_ERR "EXT4-fs: can't create %s\n", name); \ | ||
982 | goto err_out; \ | ||
983 | } \ | ||
984 | } while (0) | ||
985 | #else | ||
986 | #define EXT4_PROC_HANDLER(name, var) | ||
987 | #endif | ||
988 | |||
989 | /* | 980 | /* |
990 | * Function prototypes | 981 | * Function prototypes |
991 | */ | 982 | */ |
@@ -1092,6 +1083,7 @@ extern int ext4_can_truncate(struct inode *inode); | |||
1092 | extern void ext4_truncate(struct inode *); | 1083 | extern void ext4_truncate(struct inode *); |
1093 | extern void ext4_set_inode_flags(struct inode *); | 1084 | extern void ext4_set_inode_flags(struct inode *); |
1094 | extern void ext4_get_inode_flags(struct ext4_inode_info *); | 1085 | extern void ext4_get_inode_flags(struct ext4_inode_info *); |
1086 | extern int ext4_alloc_da_blocks(struct inode *inode); | ||
1095 | extern void ext4_set_aops(struct inode *inode); | 1087 | extern void ext4_set_aops(struct inode *inode); |
1096 | extern int ext4_writepage_trans_blocks(struct inode *); | 1088 | extern int ext4_writepage_trans_blocks(struct inode *); |
1097 | extern int ext4_meta_trans_blocks(struct inode *, int nrblocks, int idxblocks); | 1089 | extern int ext4_meta_trans_blocks(struct inode *, int nrblocks, int idxblocks); |
@@ -1107,7 +1099,10 @@ extern long ext4_compat_ioctl(struct file *, unsigned int, unsigned long); | |||
1107 | 1099 | ||
1108 | /* migrate.c */ | 1100 | /* migrate.c */ |
1109 | extern int ext4_ext_migrate(struct inode *); | 1101 | extern int ext4_ext_migrate(struct inode *); |
1102 | |||
1110 | /* namei.c */ | 1103 | /* namei.c */ |
1104 | extern unsigned int ext4_rec_len_from_disk(__le16 dlen, unsigned blocksize); | ||
1105 | extern __le16 ext4_rec_len_to_disk(unsigned len, unsigned blocksize); | ||
1111 | extern int ext4_orphan_add(handle_t *, struct inode *); | 1106 | extern int ext4_orphan_add(handle_t *, struct inode *); |
1112 | extern int ext4_orphan_del(handle_t *, struct inode *); | 1107 | extern int ext4_orphan_del(handle_t *, struct inode *); |
1113 | extern int ext4_htree_fill_tree(struct file *dir_file, __u32 start_hash, | 1108 | extern int ext4_htree_fill_tree(struct file *dir_file, __u32 start_hash, |
diff --git a/fs/ext4/ext4_extents.h b/fs/ext4/ext4_extents.h index 18cb67b2cbbc..f0c3ec85bd48 100644 --- a/fs/ext4/ext4_extents.h +++ b/fs/ext4/ext4_extents.h | |||
@@ -241,5 +241,6 @@ extern int ext4_ext_search_left(struct inode *, struct ext4_ext_path *, | |||
241 | extern int ext4_ext_search_right(struct inode *, struct ext4_ext_path *, | 241 | extern int ext4_ext_search_right(struct inode *, struct ext4_ext_path *, |
242 | ext4_lblk_t *, ext4_fsblk_t *); | 242 | ext4_lblk_t *, ext4_fsblk_t *); |
243 | extern void ext4_ext_drop_refs(struct ext4_ext_path *); | 243 | extern void ext4_ext_drop_refs(struct ext4_ext_path *); |
244 | extern int ext4_ext_check_inode(struct inode *inode); | ||
244 | #endif /* _EXT4_EXTENTS */ | 245 | #endif /* _EXT4_EXTENTS */ |
245 | 246 | ||
diff --git a/fs/ext4/ext4_i.h b/fs/ext4/ext4_i.h index e69acc16f5c4..4ce2187123aa 100644 --- a/fs/ext4/ext4_i.h +++ b/fs/ext4/ext4_i.h | |||
@@ -33,9 +33,6 @@ typedef __u32 ext4_lblk_t; | |||
33 | /* data type for block group number */ | 33 | /* data type for block group number */ |
34 | typedef unsigned int ext4_group_t; | 34 | typedef unsigned int ext4_group_t; |
35 | 35 | ||
36 | #define rsv_start rsv_window._rsv_start | ||
37 | #define rsv_end rsv_window._rsv_end | ||
38 | |||
39 | /* | 36 | /* |
40 | * storage for cached extent | 37 | * storage for cached extent |
41 | */ | 38 | */ |
@@ -125,6 +122,9 @@ struct ext4_inode_info { | |||
125 | struct list_head i_prealloc_list; | 122 | struct list_head i_prealloc_list; |
126 | spinlock_t i_prealloc_lock; | 123 | spinlock_t i_prealloc_lock; |
127 | 124 | ||
125 | /* ialloc */ | ||
126 | ext4_group_t i_last_alloc_group; | ||
127 | |||
128 | /* allocation reservation info for delalloc */ | 128 | /* allocation reservation info for delalloc */ |
129 | unsigned int i_reserved_data_blocks; | 129 | unsigned int i_reserved_data_blocks; |
130 | unsigned int i_reserved_meta_blocks; | 130 | unsigned int i_reserved_meta_blocks; |
diff --git a/fs/ext4/ext4_sb.h b/fs/ext4/ext4_sb.h index 039b6ea1a042..57b71fefbccf 100644 --- a/fs/ext4/ext4_sb.h +++ b/fs/ext4/ext4_sb.h | |||
@@ -62,12 +62,10 @@ struct ext4_sb_info { | |||
62 | struct percpu_counter s_freeinodes_counter; | 62 | struct percpu_counter s_freeinodes_counter; |
63 | struct percpu_counter s_dirs_counter; | 63 | struct percpu_counter s_dirs_counter; |
64 | struct percpu_counter s_dirtyblocks_counter; | 64 | struct percpu_counter s_dirtyblocks_counter; |
65 | struct blockgroup_lock s_blockgroup_lock; | 65 | struct blockgroup_lock *s_blockgroup_lock; |
66 | struct proc_dir_entry *s_proc; | 66 | struct proc_dir_entry *s_proc; |
67 | 67 | struct kobject s_kobj; | |
68 | /* root of the per fs reservation window tree */ | 68 | struct completion s_kobj_unregister; |
69 | spinlock_t s_rsv_window_lock; | ||
70 | struct rb_root s_rsv_window_root; | ||
71 | 69 | ||
72 | /* Journaling */ | 70 | /* Journaling */ |
73 | struct inode *s_journal_inode; | 71 | struct inode *s_journal_inode; |
@@ -146,6 +144,10 @@ struct ext4_sb_info { | |||
146 | /* locality groups */ | 144 | /* locality groups */ |
147 | struct ext4_locality_group *s_locality_groups; | 145 | struct ext4_locality_group *s_locality_groups; |
148 | 146 | ||
147 | /* for write statistics */ | ||
148 | unsigned long s_sectors_written_start; | ||
149 | u64 s_kbytes_written; | ||
150 | |||
149 | unsigned int s_log_groups_per_flex; | 151 | unsigned int s_log_groups_per_flex; |
150 | struct flex_groups *s_flex_groups; | 152 | struct flex_groups *s_flex_groups; |
151 | }; | 153 | }; |
@@ -153,7 +155,7 @@ struct ext4_sb_info { | |||
153 | static inline spinlock_t * | 155 | static inline spinlock_t * |
154 | sb_bgl_lock(struct ext4_sb_info *sbi, unsigned int block_group) | 156 | sb_bgl_lock(struct ext4_sb_info *sbi, unsigned int block_group) |
155 | { | 157 | { |
156 | return bgl_lock_ptr(&sbi->s_blockgroup_lock, block_group); | 158 | return bgl_lock_ptr(sbi->s_blockgroup_lock, block_group); |
157 | } | 159 | } |
158 | 160 | ||
159 | #endif /* _EXT4_SB */ | 161 | #endif /* _EXT4_SB */ |
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index e0aa4fe4f596..ac77d8b8251d 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c | |||
@@ -152,6 +152,8 @@ static ext4_fsblk_t ext4_ext_find_goal(struct inode *inode, | |||
152 | ext4_fsblk_t bg_start; | 152 | ext4_fsblk_t bg_start; |
153 | ext4_fsblk_t last_block; | 153 | ext4_fsblk_t last_block; |
154 | ext4_grpblk_t colour; | 154 | ext4_grpblk_t colour; |
155 | ext4_group_t block_group; | ||
156 | int flex_size = ext4_flex_bg_size(EXT4_SB(inode->i_sb)); | ||
155 | int depth; | 157 | int depth; |
156 | 158 | ||
157 | if (path) { | 159 | if (path) { |
@@ -170,10 +172,31 @@ static ext4_fsblk_t ext4_ext_find_goal(struct inode *inode, | |||
170 | } | 172 | } |
171 | 173 | ||
172 | /* OK. use inode's group */ | 174 | /* OK. use inode's group */ |
173 | bg_start = (ei->i_block_group * EXT4_BLOCKS_PER_GROUP(inode->i_sb)) + | 175 | block_group = ei->i_block_group; |
176 | if (flex_size >= EXT4_FLEX_SIZE_DIR_ALLOC_SCHEME) { | ||
177 | /* | ||
178 | * If there are at least EXT4_FLEX_SIZE_DIR_ALLOC_SCHEME | ||
179 | * block groups per flexgroup, reserve the first block | ||
180 | * group for directories and special files. Regular | ||
181 | * files will start at the second block group. This | ||
182 | * tends to speed up directory access and improves | ||
183 | * fsck times. | ||
184 | */ | ||
185 | block_group &= ~(flex_size-1); | ||
186 | if (S_ISREG(inode->i_mode)) | ||
187 | block_group++; | ||
188 | } | ||
189 | bg_start = (block_group * EXT4_BLOCKS_PER_GROUP(inode->i_sb)) + | ||
174 | le32_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_first_data_block); | 190 | le32_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_first_data_block); |
175 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; | 191 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; |
176 | 192 | ||
193 | /* | ||
194 | * If we are doing delayed allocation, we don't need take | ||
195 | * colour into account. | ||
196 | */ | ||
197 | if (test_opt(inode->i_sb, DELALLOC)) | ||
198 | return bg_start; | ||
199 | |||
177 | if (bg_start + EXT4_BLOCKS_PER_GROUP(inode->i_sb) <= last_block) | 200 | if (bg_start + EXT4_BLOCKS_PER_GROUP(inode->i_sb) <= last_block) |
178 | colour = (current->pid % 16) * | 201 | colour = (current->pid % 16) * |
179 | (EXT4_BLOCKS_PER_GROUP(inode->i_sb) / 16); | 202 | (EXT4_BLOCKS_PER_GROUP(inode->i_sb) / 16); |
@@ -301,7 +324,64 @@ ext4_ext_max_entries(struct inode *inode, int depth) | |||
301 | return max; | 324 | return max; |
302 | } | 325 | } |
303 | 326 | ||
304 | static int __ext4_ext_check_header(const char *function, struct inode *inode, | 327 | static int ext4_valid_extent(struct inode *inode, struct ext4_extent *ext) |
328 | { | ||
329 | ext4_fsblk_t block = ext_pblock(ext); | ||
330 | int len = ext4_ext_get_actual_len(ext); | ||
331 | struct ext4_super_block *es = EXT4_SB(inode->i_sb)->s_es; | ||
332 | if (unlikely(block < le32_to_cpu(es->s_first_data_block) || | ||
333 | ((block + len) > ext4_blocks_count(es)))) | ||
334 | return 0; | ||
335 | else | ||
336 | return 1; | ||
337 | } | ||
338 | |||
339 | static int ext4_valid_extent_idx(struct inode *inode, | ||
340 | struct ext4_extent_idx *ext_idx) | ||
341 | { | ||
342 | ext4_fsblk_t block = idx_pblock(ext_idx); | ||
343 | struct ext4_super_block *es = EXT4_SB(inode->i_sb)->s_es; | ||
344 | if (unlikely(block < le32_to_cpu(es->s_first_data_block) || | ||
345 | (block > ext4_blocks_count(es)))) | ||
346 | return 0; | ||
347 | else | ||
348 | return 1; | ||
349 | } | ||
350 | |||
351 | static int ext4_valid_extent_entries(struct inode *inode, | ||
352 | struct ext4_extent_header *eh, | ||
353 | int depth) | ||
354 | { | ||
355 | struct ext4_extent *ext; | ||
356 | struct ext4_extent_idx *ext_idx; | ||
357 | unsigned short entries; | ||
358 | if (eh->eh_entries == 0) | ||
359 | return 1; | ||
360 | |||
361 | entries = le16_to_cpu(eh->eh_entries); | ||
362 | |||
363 | if (depth == 0) { | ||
364 | /* leaf entries */ | ||
365 | ext = EXT_FIRST_EXTENT(eh); | ||
366 | while (entries) { | ||
367 | if (!ext4_valid_extent(inode, ext)) | ||
368 | return 0; | ||
369 | ext++; | ||
370 | entries--; | ||
371 | } | ||
372 | } else { | ||
373 | ext_idx = EXT_FIRST_INDEX(eh); | ||
374 | while (entries) { | ||
375 | if (!ext4_valid_extent_idx(inode, ext_idx)) | ||
376 | return 0; | ||
377 | ext_idx++; | ||
378 | entries--; | ||
379 | } | ||
380 | } | ||
381 | return 1; | ||
382 | } | ||
383 | |||
384 | static int __ext4_ext_check(const char *function, struct inode *inode, | ||
305 | struct ext4_extent_header *eh, | 385 | struct ext4_extent_header *eh, |
306 | int depth) | 386 | int depth) |
307 | { | 387 | { |
@@ -329,11 +409,15 @@ static int __ext4_ext_check_header(const char *function, struct inode *inode, | |||
329 | error_msg = "invalid eh_entries"; | 409 | error_msg = "invalid eh_entries"; |
330 | goto corrupted; | 410 | goto corrupted; |
331 | } | 411 | } |
412 | if (!ext4_valid_extent_entries(inode, eh, depth)) { | ||
413 | error_msg = "invalid extent entries"; | ||
414 | goto corrupted; | ||
415 | } | ||
332 | return 0; | 416 | return 0; |
333 | 417 | ||
334 | corrupted: | 418 | corrupted: |
335 | ext4_error(inode->i_sb, function, | 419 | ext4_error(inode->i_sb, function, |
336 | "bad header in inode #%lu: %s - magic %x, " | 420 | "bad header/extent in inode #%lu: %s - magic %x, " |
337 | "entries %u, max %u(%u), depth %u(%u)", | 421 | "entries %u, max %u(%u), depth %u(%u)", |
338 | inode->i_ino, error_msg, le16_to_cpu(eh->eh_magic), | 422 | inode->i_ino, error_msg, le16_to_cpu(eh->eh_magic), |
339 | le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max), | 423 | le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max), |
@@ -342,8 +426,13 @@ corrupted: | |||
342 | return -EIO; | 426 | return -EIO; |
343 | } | 427 | } |
344 | 428 | ||
345 | #define ext4_ext_check_header(inode, eh, depth) \ | 429 | #define ext4_ext_check(inode, eh, depth) \ |
346 | __ext4_ext_check_header(__func__, inode, eh, depth) | 430 | __ext4_ext_check(__func__, inode, eh, depth) |
431 | |||
432 | int ext4_ext_check_inode(struct inode *inode) | ||
433 | { | ||
434 | return ext4_ext_check(inode, ext_inode_hdr(inode), ext_depth(inode)); | ||
435 | } | ||
347 | 436 | ||
348 | #ifdef EXT_DEBUG | 437 | #ifdef EXT_DEBUG |
349 | static void ext4_ext_show_path(struct inode *inode, struct ext4_ext_path *path) | 438 | static void ext4_ext_show_path(struct inode *inode, struct ext4_ext_path *path) |
@@ -547,9 +636,6 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block, | |||
547 | 636 | ||
548 | eh = ext_inode_hdr(inode); | 637 | eh = ext_inode_hdr(inode); |
549 | depth = ext_depth(inode); | 638 | depth = ext_depth(inode); |
550 | if (ext4_ext_check_header(inode, eh, depth)) | ||
551 | return ERR_PTR(-EIO); | ||
552 | |||
553 | 639 | ||
554 | /* account possible depth increase */ | 640 | /* account possible depth increase */ |
555 | if (!path) { | 641 | if (!path) { |
@@ -565,6 +651,8 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block, | |||
565 | i = depth; | 651 | i = depth; |
566 | /* walk through the tree */ | 652 | /* walk through the tree */ |
567 | while (i) { | 653 | while (i) { |
654 | int need_to_validate = 0; | ||
655 | |||
568 | ext_debug("depth %d: num %d, max %d\n", | 656 | ext_debug("depth %d: num %d, max %d\n", |
569 | ppos, le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max)); | 657 | ppos, le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max)); |
570 | 658 | ||
@@ -573,10 +661,17 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block, | |||
573 | path[ppos].p_depth = i; | 661 | path[ppos].p_depth = i; |
574 | path[ppos].p_ext = NULL; | 662 | path[ppos].p_ext = NULL; |
575 | 663 | ||
576 | bh = sb_bread(inode->i_sb, path[ppos].p_block); | 664 | bh = sb_getblk(inode->i_sb, path[ppos].p_block); |
577 | if (!bh) | 665 | if (unlikely(!bh)) |
578 | goto err; | 666 | goto err; |
579 | 667 | if (!bh_uptodate_or_lock(bh)) { | |
668 | if (bh_submit_read(bh) < 0) { | ||
669 | put_bh(bh); | ||
670 | goto err; | ||
671 | } | ||
672 | /* validate the extent entries */ | ||
673 | need_to_validate = 1; | ||
674 | } | ||
580 | eh = ext_block_hdr(bh); | 675 | eh = ext_block_hdr(bh); |
581 | ppos++; | 676 | ppos++; |
582 | BUG_ON(ppos > depth); | 677 | BUG_ON(ppos > depth); |
@@ -584,7 +679,7 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block, | |||
584 | path[ppos].p_hdr = eh; | 679 | path[ppos].p_hdr = eh; |
585 | i--; | 680 | i--; |
586 | 681 | ||
587 | if (ext4_ext_check_header(inode, eh, i)) | 682 | if (need_to_validate && ext4_ext_check(inode, eh, i)) |
588 | goto err; | 683 | goto err; |
589 | } | 684 | } |
590 | 685 | ||
@@ -1181,7 +1276,7 @@ got_index: | |||
1181 | return -EIO; | 1276 | return -EIO; |
1182 | eh = ext_block_hdr(bh); | 1277 | eh = ext_block_hdr(bh); |
1183 | /* subtract from p_depth to get proper eh_depth */ | 1278 | /* subtract from p_depth to get proper eh_depth */ |
1184 | if (ext4_ext_check_header(inode, eh, path->p_depth - depth)) { | 1279 | if (ext4_ext_check(inode, eh, path->p_depth - depth)) { |
1185 | put_bh(bh); | 1280 | put_bh(bh); |
1186 | return -EIO; | 1281 | return -EIO; |
1187 | } | 1282 | } |
@@ -1194,7 +1289,7 @@ got_index: | |||
1194 | if (bh == NULL) | 1289 | if (bh == NULL) |
1195 | return -EIO; | 1290 | return -EIO; |
1196 | eh = ext_block_hdr(bh); | 1291 | eh = ext_block_hdr(bh); |
1197 | if (ext4_ext_check_header(inode, eh, path->p_depth - depth)) { | 1292 | if (ext4_ext_check(inode, eh, path->p_depth - depth)) { |
1198 | put_bh(bh); | 1293 | put_bh(bh); |
1199 | return -EIO; | 1294 | return -EIO; |
1200 | } | 1295 | } |
@@ -2137,7 +2232,7 @@ static int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start) | |||
2137 | return -ENOMEM; | 2232 | return -ENOMEM; |
2138 | } | 2233 | } |
2139 | path[0].p_hdr = ext_inode_hdr(inode); | 2234 | path[0].p_hdr = ext_inode_hdr(inode); |
2140 | if (ext4_ext_check_header(inode, path[0].p_hdr, depth)) { | 2235 | if (ext4_ext_check(inode, path[0].p_hdr, depth)) { |
2141 | err = -EIO; | 2236 | err = -EIO; |
2142 | goto out; | 2237 | goto out; |
2143 | } | 2238 | } |
@@ -2191,7 +2286,7 @@ static int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start) | |||
2191 | err = -EIO; | 2286 | err = -EIO; |
2192 | break; | 2287 | break; |
2193 | } | 2288 | } |
2194 | if (ext4_ext_check_header(inode, ext_block_hdr(bh), | 2289 | if (ext4_ext_check(inode, ext_block_hdr(bh), |
2195 | depth - i - 1)) { | 2290 | depth - i - 1)) { |
2196 | err = -EIO; | 2291 | err = -EIO; |
2197 | break; | 2292 | break; |
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index f731cb545a03..588af8c77246 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
@@ -33,9 +33,14 @@ | |||
33 | */ | 33 | */ |
34 | static int ext4_release_file(struct inode *inode, struct file *filp) | 34 | static int ext4_release_file(struct inode *inode, struct file *filp) |
35 | { | 35 | { |
36 | if (EXT4_I(inode)->i_state & EXT4_STATE_DA_ALLOC_CLOSE) { | ||
37 | ext4_alloc_da_blocks(inode); | ||
38 | EXT4_I(inode)->i_state &= ~EXT4_STATE_DA_ALLOC_CLOSE; | ||
39 | } | ||
36 | /* if we are the last writer on the inode, drop the block reservation */ | 40 | /* if we are the last writer on the inode, drop the block reservation */ |
37 | if ((filp->f_mode & FMODE_WRITE) && | 41 | if ((filp->f_mode & FMODE_WRITE) && |
38 | (atomic_read(&inode->i_writecount) == 1)) | 42 | (atomic_read(&inode->i_writecount) == 1) && |
43 | !EXT4_I(inode)->i_reserved_data_blocks) | ||
39 | { | 44 | { |
40 | down_write(&EXT4_I(inode)->i_data_sem); | 45 | down_write(&EXT4_I(inode)->i_data_sem); |
41 | ext4_discard_preallocations(inode); | 46 | ext4_discard_preallocations(inode); |
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index fb51b40e3e8f..47b84e8df568 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c | |||
@@ -189,7 +189,6 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
189 | struct ext4_super_block *es; | 189 | struct ext4_super_block *es; |
190 | struct ext4_sb_info *sbi; | 190 | struct ext4_sb_info *sbi; |
191 | int fatal = 0, err, count, cleared; | 191 | int fatal = 0, err, count, cleared; |
192 | ext4_group_t flex_group; | ||
193 | 192 | ||
194 | if (atomic_read(&inode->i_count) > 1) { | 193 | if (atomic_read(&inode->i_count) > 1) { |
195 | printk(KERN_ERR "ext4_free_inode: inode has count=%d\n", | 194 | printk(KERN_ERR "ext4_free_inode: inode has count=%d\n", |
@@ -268,6 +267,13 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
268 | if (is_directory) { | 267 | if (is_directory) { |
269 | count = ext4_used_dirs_count(sb, gdp) - 1; | 268 | count = ext4_used_dirs_count(sb, gdp) - 1; |
270 | ext4_used_dirs_set(sb, gdp, count); | 269 | ext4_used_dirs_set(sb, gdp, count); |
270 | if (sbi->s_log_groups_per_flex) { | ||
271 | ext4_group_t f; | ||
272 | |||
273 | f = ext4_flex_group(sbi, block_group); | ||
274 | atomic_dec(&sbi->s_flex_groups[f].free_inodes); | ||
275 | } | ||
276 | |||
271 | } | 277 | } |
272 | gdp->bg_checksum = ext4_group_desc_csum(sbi, | 278 | gdp->bg_checksum = ext4_group_desc_csum(sbi, |
273 | block_group, gdp); | 279 | block_group, gdp); |
@@ -277,10 +283,10 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
277 | percpu_counter_dec(&sbi->s_dirs_counter); | 283 | percpu_counter_dec(&sbi->s_dirs_counter); |
278 | 284 | ||
279 | if (sbi->s_log_groups_per_flex) { | 285 | if (sbi->s_log_groups_per_flex) { |
280 | flex_group = ext4_flex_group(sbi, block_group); | 286 | ext4_group_t f; |
281 | spin_lock(sb_bgl_lock(sbi, flex_group)); | 287 | |
282 | sbi->s_flex_groups[flex_group].free_inodes++; | 288 | f = ext4_flex_group(sbi, block_group); |
283 | spin_unlock(sb_bgl_lock(sbi, flex_group)); | 289 | atomic_inc(&sbi->s_flex_groups[f].free_inodes); |
284 | } | 290 | } |
285 | } | 291 | } |
286 | BUFFER_TRACE(bh2, "call ext4_handle_dirty_metadata"); | 292 | BUFFER_TRACE(bh2, "call ext4_handle_dirty_metadata"); |
@@ -360,9 +366,9 @@ static int find_group_flex(struct super_block *sb, struct inode *parent, | |||
360 | sbi->s_log_groups_per_flex; | 366 | sbi->s_log_groups_per_flex; |
361 | 367 | ||
362 | find_close_to_parent: | 368 | find_close_to_parent: |
363 | flexbg_free_blocks = flex_group[best_flex].free_blocks; | 369 | flexbg_free_blocks = atomic_read(&flex_group[best_flex].free_blocks); |
364 | flex_freeb_ratio = flexbg_free_blocks * 100 / blocks_per_flex; | 370 | flex_freeb_ratio = flexbg_free_blocks * 100 / blocks_per_flex; |
365 | if (flex_group[best_flex].free_inodes && | 371 | if (atomic_read(&flex_group[best_flex].free_inodes) && |
366 | flex_freeb_ratio > free_block_ratio) | 372 | flex_freeb_ratio > free_block_ratio) |
367 | goto found_flexbg; | 373 | goto found_flexbg; |
368 | 374 | ||
@@ -375,24 +381,24 @@ find_close_to_parent: | |||
375 | if (i == parent_fbg_group || i == parent_fbg_group - 1) | 381 | if (i == parent_fbg_group || i == parent_fbg_group - 1) |
376 | continue; | 382 | continue; |
377 | 383 | ||
378 | flexbg_free_blocks = flex_group[i].free_blocks; | 384 | flexbg_free_blocks = atomic_read(&flex_group[i].free_blocks); |
379 | flex_freeb_ratio = flexbg_free_blocks * 100 / blocks_per_flex; | 385 | flex_freeb_ratio = flexbg_free_blocks * 100 / blocks_per_flex; |
380 | 386 | ||
381 | if (flex_freeb_ratio > free_block_ratio && | 387 | if (flex_freeb_ratio > free_block_ratio && |
382 | flex_group[i].free_inodes) { | 388 | (atomic_read(&flex_group[i].free_inodes))) { |
383 | best_flex = i; | 389 | best_flex = i; |
384 | goto found_flexbg; | 390 | goto found_flexbg; |
385 | } | 391 | } |
386 | 392 | ||
387 | if (flex_group[best_flex].free_inodes == 0 || | 393 | if ((atomic_read(&flex_group[best_flex].free_inodes) == 0) || |
388 | (flex_group[i].free_blocks > | 394 | ((atomic_read(&flex_group[i].free_blocks) > |
389 | flex_group[best_flex].free_blocks && | 395 | atomic_read(&flex_group[best_flex].free_blocks)) && |
390 | flex_group[i].free_inodes)) | 396 | atomic_read(&flex_group[i].free_inodes))) |
391 | best_flex = i; | 397 | best_flex = i; |
392 | } | 398 | } |
393 | 399 | ||
394 | if (!flex_group[best_flex].free_inodes || | 400 | if (!atomic_read(&flex_group[best_flex].free_inodes) || |
395 | !flex_group[best_flex].free_blocks) | 401 | !atomic_read(&flex_group[best_flex].free_blocks)) |
396 | return -1; | 402 | return -1; |
397 | 403 | ||
398 | found_flexbg: | 404 | found_flexbg: |
@@ -410,6 +416,42 @@ out: | |||
410 | return 0; | 416 | return 0; |
411 | } | 417 | } |
412 | 418 | ||
419 | struct orlov_stats { | ||
420 | __u32 free_inodes; | ||
421 | __u32 free_blocks; | ||
422 | __u32 used_dirs; | ||
423 | }; | ||
424 | |||
425 | /* | ||
426 | * Helper function for Orlov's allocator; returns critical information | ||
427 | * for a particular block group or flex_bg. If flex_size is 1, then g | ||
428 | * is a block group number; otherwise it is flex_bg number. | ||
429 | */ | ||
430 | void get_orlov_stats(struct super_block *sb, ext4_group_t g, | ||
431 | int flex_size, struct orlov_stats *stats) | ||
432 | { | ||
433 | struct ext4_group_desc *desc; | ||
434 | struct flex_groups *flex_group = EXT4_SB(sb)->s_flex_groups; | ||
435 | |||
436 | if (flex_size > 1) { | ||
437 | stats->free_inodes = atomic_read(&flex_group[g].free_inodes); | ||
438 | stats->free_blocks = atomic_read(&flex_group[g].free_blocks); | ||
439 | stats->used_dirs = atomic_read(&flex_group[g].used_dirs); | ||
440 | return; | ||
441 | } | ||
442 | |||
443 | desc = ext4_get_group_desc(sb, g, NULL); | ||
444 | if (desc) { | ||
445 | stats->free_inodes = ext4_free_inodes_count(sb, desc); | ||
446 | stats->free_blocks = ext4_free_blks_count(sb, desc); | ||
447 | stats->used_dirs = ext4_used_dirs_count(sb, desc); | ||
448 | } else { | ||
449 | stats->free_inodes = 0; | ||
450 | stats->free_blocks = 0; | ||
451 | stats->used_dirs = 0; | ||
452 | } | ||
453 | } | ||
454 | |||
413 | /* | 455 | /* |
414 | * Orlov's allocator for directories. | 456 | * Orlov's allocator for directories. |
415 | * | 457 | * |
@@ -425,35 +467,34 @@ out: | |||
425 | * it has too many directories already (max_dirs) or | 467 | * it has too many directories already (max_dirs) or |
426 | * it has too few free inodes left (min_inodes) or | 468 | * it has too few free inodes left (min_inodes) or |
427 | * it has too few free blocks left (min_blocks) or | 469 | * it has too few free blocks left (min_blocks) or |
428 | * it's already running too large debt (max_debt). | ||
429 | * Parent's group is preferred, if it doesn't satisfy these | 470 | * Parent's group is preferred, if it doesn't satisfy these |
430 | * conditions we search cyclically through the rest. If none | 471 | * conditions we search cyclically through the rest. If none |
431 | * of the groups look good we just look for a group with more | 472 | * of the groups look good we just look for a group with more |
432 | * free inodes than average (starting at parent's group). | 473 | * free inodes than average (starting at parent's group). |
433 | * | ||
434 | * Debt is incremented each time we allocate a directory and decremented | ||
435 | * when we allocate an inode, within 0--255. | ||
436 | */ | 474 | */ |
437 | 475 | ||
438 | #define INODE_COST 64 | ||
439 | #define BLOCK_COST 256 | ||
440 | |||
441 | static int find_group_orlov(struct super_block *sb, struct inode *parent, | 476 | static int find_group_orlov(struct super_block *sb, struct inode *parent, |
442 | ext4_group_t *group) | 477 | ext4_group_t *group, int mode) |
443 | { | 478 | { |
444 | ext4_group_t parent_group = EXT4_I(parent)->i_block_group; | 479 | ext4_group_t parent_group = EXT4_I(parent)->i_block_group; |
445 | struct ext4_sb_info *sbi = EXT4_SB(sb); | 480 | struct ext4_sb_info *sbi = EXT4_SB(sb); |
446 | struct ext4_super_block *es = sbi->s_es; | ||
447 | ext4_group_t ngroups = sbi->s_groups_count; | 481 | ext4_group_t ngroups = sbi->s_groups_count; |
448 | int inodes_per_group = EXT4_INODES_PER_GROUP(sb); | 482 | int inodes_per_group = EXT4_INODES_PER_GROUP(sb); |
449 | unsigned int freei, avefreei; | 483 | unsigned int freei, avefreei; |
450 | ext4_fsblk_t freeb, avefreeb; | 484 | ext4_fsblk_t freeb, avefreeb; |
451 | ext4_fsblk_t blocks_per_dir; | ||
452 | unsigned int ndirs; | 485 | unsigned int ndirs; |
453 | int max_debt, max_dirs, min_inodes; | 486 | int max_dirs, min_inodes; |
454 | ext4_grpblk_t min_blocks; | 487 | ext4_grpblk_t min_blocks; |
455 | ext4_group_t i; | 488 | ext4_group_t i, grp, g; |
456 | struct ext4_group_desc *desc; | 489 | struct ext4_group_desc *desc; |
490 | struct orlov_stats stats; | ||
491 | int flex_size = ext4_flex_bg_size(sbi); | ||
492 | |||
493 | if (flex_size > 1) { | ||
494 | ngroups = (ngroups + flex_size - 1) >> | ||
495 | sbi->s_log_groups_per_flex; | ||
496 | parent_group >>= sbi->s_log_groups_per_flex; | ||
497 | } | ||
457 | 498 | ||
458 | freei = percpu_counter_read_positive(&sbi->s_freeinodes_counter); | 499 | freei = percpu_counter_read_positive(&sbi->s_freeinodes_counter); |
459 | avefreei = freei / ngroups; | 500 | avefreei = freei / ngroups; |
@@ -462,71 +503,97 @@ static int find_group_orlov(struct super_block *sb, struct inode *parent, | |||
462 | do_div(avefreeb, ngroups); | 503 | do_div(avefreeb, ngroups); |
463 | ndirs = percpu_counter_read_positive(&sbi->s_dirs_counter); | 504 | ndirs = percpu_counter_read_positive(&sbi->s_dirs_counter); |
464 | 505 | ||
465 | if ((parent == sb->s_root->d_inode) || | 506 | if (S_ISDIR(mode) && |
466 | (EXT4_I(parent)->i_flags & EXT4_TOPDIR_FL)) { | 507 | ((parent == sb->s_root->d_inode) || |
508 | (EXT4_I(parent)->i_flags & EXT4_TOPDIR_FL))) { | ||
467 | int best_ndir = inodes_per_group; | 509 | int best_ndir = inodes_per_group; |
468 | ext4_group_t grp; | ||
469 | int ret = -1; | 510 | int ret = -1; |
470 | 511 | ||
471 | get_random_bytes(&grp, sizeof(grp)); | 512 | get_random_bytes(&grp, sizeof(grp)); |
472 | parent_group = (unsigned)grp % ngroups; | 513 | parent_group = (unsigned)grp % ngroups; |
473 | for (i = 0; i < ngroups; i++) { | 514 | for (i = 0; i < ngroups; i++) { |
474 | grp = (parent_group + i) % ngroups; | 515 | g = (parent_group + i) % ngroups; |
475 | desc = ext4_get_group_desc(sb, grp, NULL); | 516 | get_orlov_stats(sb, g, flex_size, &stats); |
476 | if (!desc || !ext4_free_inodes_count(sb, desc)) | 517 | if (!stats.free_inodes) |
477 | continue; | 518 | continue; |
478 | if (ext4_used_dirs_count(sb, desc) >= best_ndir) | 519 | if (stats.used_dirs >= best_ndir) |
479 | continue; | 520 | continue; |
480 | if (ext4_free_inodes_count(sb, desc) < avefreei) | 521 | if (stats.free_inodes < avefreei) |
481 | continue; | 522 | continue; |
482 | if (ext4_free_blks_count(sb, desc) < avefreeb) | 523 | if (stats.free_blocks < avefreeb) |
483 | continue; | 524 | continue; |
484 | *group = grp; | 525 | grp = g; |
485 | ret = 0; | 526 | ret = 0; |
486 | best_ndir = ext4_used_dirs_count(sb, desc); | 527 | best_ndir = stats.used_dirs; |
528 | } | ||
529 | if (ret) | ||
530 | goto fallback; | ||
531 | found_flex_bg: | ||
532 | if (flex_size == 1) { | ||
533 | *group = grp; | ||
534 | return 0; | ||
535 | } | ||
536 | |||
537 | /* | ||
538 | * We pack inodes at the beginning of the flexgroup's | ||
539 | * inode tables. Block allocation decisions will do | ||
540 | * something similar, although regular files will | ||
541 | * start at 2nd block group of the flexgroup. See | ||
542 | * ext4_ext_find_goal() and ext4_find_near(). | ||
543 | */ | ||
544 | grp *= flex_size; | ||
545 | for (i = 0; i < flex_size; i++) { | ||
546 | if (grp+i >= sbi->s_groups_count) | ||
547 | break; | ||
548 | desc = ext4_get_group_desc(sb, grp+i, NULL); | ||
549 | if (desc && ext4_free_inodes_count(sb, desc)) { | ||
550 | *group = grp+i; | ||
551 | return 0; | ||
552 | } | ||
487 | } | 553 | } |
488 | if (ret == 0) | ||
489 | return ret; | ||
490 | goto fallback; | 554 | goto fallback; |
491 | } | 555 | } |
492 | 556 | ||
493 | blocks_per_dir = ext4_blocks_count(es) - freeb; | ||
494 | do_div(blocks_per_dir, ndirs); | ||
495 | |||
496 | max_dirs = ndirs / ngroups + inodes_per_group / 16; | 557 | max_dirs = ndirs / ngroups + inodes_per_group / 16; |
497 | min_inodes = avefreei - inodes_per_group / 4; | 558 | min_inodes = avefreei - inodes_per_group*flex_size / 4; |
498 | min_blocks = avefreeb - EXT4_BLOCKS_PER_GROUP(sb) / 4; | 559 | if (min_inodes < 1) |
499 | 560 | min_inodes = 1; | |
500 | max_debt = EXT4_BLOCKS_PER_GROUP(sb); | 561 | min_blocks = avefreeb - EXT4_BLOCKS_PER_GROUP(sb)*flex_size / 4; |
501 | max_debt /= max_t(int, blocks_per_dir, BLOCK_COST); | 562 | |
502 | if (max_debt * INODE_COST > inodes_per_group) | 563 | /* |
503 | max_debt = inodes_per_group / INODE_COST; | 564 | * Start looking in the flex group where we last allocated an |
504 | if (max_debt > 255) | 565 | * inode for this parent directory |
505 | max_debt = 255; | 566 | */ |
506 | if (max_debt == 0) | 567 | if (EXT4_I(parent)->i_last_alloc_group != ~0) { |
507 | max_debt = 1; | 568 | parent_group = EXT4_I(parent)->i_last_alloc_group; |
569 | if (flex_size > 1) | ||
570 | parent_group >>= sbi->s_log_groups_per_flex; | ||
571 | } | ||
508 | 572 | ||
509 | for (i = 0; i < ngroups; i++) { | 573 | for (i = 0; i < ngroups; i++) { |
510 | *group = (parent_group + i) % ngroups; | 574 | grp = (parent_group + i) % ngroups; |
511 | desc = ext4_get_group_desc(sb, *group, NULL); | 575 | get_orlov_stats(sb, grp, flex_size, &stats); |
512 | if (!desc || !ext4_free_inodes_count(sb, desc)) | 576 | if (stats.used_dirs >= max_dirs) |
513 | continue; | ||
514 | if (ext4_used_dirs_count(sb, desc) >= max_dirs) | ||
515 | continue; | 577 | continue; |
516 | if (ext4_free_inodes_count(sb, desc) < min_inodes) | 578 | if (stats.free_inodes < min_inodes) |
517 | continue; | 579 | continue; |
518 | if (ext4_free_blks_count(sb, desc) < min_blocks) | 580 | if (stats.free_blocks < min_blocks) |
519 | continue; | 581 | continue; |
520 | return 0; | 582 | goto found_flex_bg; |
521 | } | 583 | } |
522 | 584 | ||
523 | fallback: | 585 | fallback: |
586 | ngroups = sbi->s_groups_count; | ||
587 | avefreei = freei / ngroups; | ||
588 | parent_group = EXT4_I(parent)->i_block_group; | ||
524 | for (i = 0; i < ngroups; i++) { | 589 | for (i = 0; i < ngroups; i++) { |
525 | *group = (parent_group + i) % ngroups; | 590 | grp = (parent_group + i) % ngroups; |
526 | desc = ext4_get_group_desc(sb, *group, NULL); | 591 | desc = ext4_get_group_desc(sb, grp, NULL); |
527 | if (desc && ext4_free_inodes_count(sb, desc) && | 592 | if (desc && ext4_free_inodes_count(sb, desc) && |
528 | ext4_free_inodes_count(sb, desc) >= avefreei) | 593 | ext4_free_inodes_count(sb, desc) >= avefreei) { |
594 | *group = grp; | ||
529 | return 0; | 595 | return 0; |
596 | } | ||
530 | } | 597 | } |
531 | 598 | ||
532 | if (avefreei) { | 599 | if (avefreei) { |
@@ -542,12 +609,51 @@ fallback: | |||
542 | } | 609 | } |
543 | 610 | ||
544 | static int find_group_other(struct super_block *sb, struct inode *parent, | 611 | static int find_group_other(struct super_block *sb, struct inode *parent, |
545 | ext4_group_t *group) | 612 | ext4_group_t *group, int mode) |
546 | { | 613 | { |
547 | ext4_group_t parent_group = EXT4_I(parent)->i_block_group; | 614 | ext4_group_t parent_group = EXT4_I(parent)->i_block_group; |
548 | ext4_group_t ngroups = EXT4_SB(sb)->s_groups_count; | 615 | ext4_group_t ngroups = EXT4_SB(sb)->s_groups_count; |
549 | struct ext4_group_desc *desc; | 616 | struct ext4_group_desc *desc; |
550 | ext4_group_t i; | 617 | ext4_group_t i, last; |
618 | int flex_size = ext4_flex_bg_size(EXT4_SB(sb)); | ||
619 | |||
620 | /* | ||
621 | * Try to place the inode is the same flex group as its | ||
622 | * parent. If we can't find space, use the Orlov algorithm to | ||
623 | * find another flex group, and store that information in the | ||
624 | * parent directory's inode information so that use that flex | ||
625 | * group for future allocations. | ||
626 | */ | ||
627 | if (flex_size > 1) { | ||
628 | int retry = 0; | ||
629 | |||
630 | try_again: | ||
631 | parent_group &= ~(flex_size-1); | ||
632 | last = parent_group + flex_size; | ||
633 | if (last > ngroups) | ||
634 | last = ngroups; | ||
635 | for (i = parent_group; i < last; i++) { | ||
636 | desc = ext4_get_group_desc(sb, i, NULL); | ||
637 | if (desc && ext4_free_inodes_count(sb, desc)) { | ||
638 | *group = i; | ||
639 | return 0; | ||
640 | } | ||
641 | } | ||
642 | if (!retry && EXT4_I(parent)->i_last_alloc_group != ~0) { | ||
643 | retry = 1; | ||
644 | parent_group = EXT4_I(parent)->i_last_alloc_group; | ||
645 | goto try_again; | ||
646 | } | ||
647 | /* | ||
648 | * If this didn't work, use the Orlov search algorithm | ||
649 | * to find a new flex group; we pass in the mode to | ||
650 | * avoid the topdir algorithms. | ||
651 | */ | ||
652 | *group = parent_group + flex_size; | ||
653 | if (*group > ngroups) | ||
654 | *group = 0; | ||
655 | return find_group_orlov(sb, parent, group, mode); | ||
656 | } | ||
551 | 657 | ||
552 | /* | 658 | /* |
553 | * Try to place the inode in its parent directory | 659 | * Try to place the inode in its parent directory |
@@ -665,6 +771,11 @@ static int ext4_claim_inode(struct super_block *sb, | |||
665 | if (S_ISDIR(mode)) { | 771 | if (S_ISDIR(mode)) { |
666 | count = ext4_used_dirs_count(sb, gdp) + 1; | 772 | count = ext4_used_dirs_count(sb, gdp) + 1; |
667 | ext4_used_dirs_set(sb, gdp, count); | 773 | ext4_used_dirs_set(sb, gdp, count); |
774 | if (sbi->s_log_groups_per_flex) { | ||
775 | ext4_group_t f = ext4_flex_group(sbi, group); | ||
776 | |||
777 | atomic_inc(&sbi->s_flex_groups[f].free_inodes); | ||
778 | } | ||
668 | } | 779 | } |
669 | gdp->bg_checksum = ext4_group_desc_csum(sbi, group, gdp); | 780 | gdp->bg_checksum = ext4_group_desc_csum(sbi, group, gdp); |
670 | err_ret: | 781 | err_ret: |
@@ -716,10 +827,10 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode) | |||
716 | sbi = EXT4_SB(sb); | 827 | sbi = EXT4_SB(sb); |
717 | es = sbi->s_es; | 828 | es = sbi->s_es; |
718 | 829 | ||
719 | if (sbi->s_log_groups_per_flex) { | 830 | if (sbi->s_log_groups_per_flex && test_opt(sb, OLDALLOC)) { |
720 | ret2 = find_group_flex(sb, dir, &group); | 831 | ret2 = find_group_flex(sb, dir, &group); |
721 | if (ret2 == -1) { | 832 | if (ret2 == -1) { |
722 | ret2 = find_group_other(sb, dir, &group); | 833 | ret2 = find_group_other(sb, dir, &group, mode); |
723 | if (ret2 == 0 && once) | 834 | if (ret2 == 0 && once) |
724 | once = 0; | 835 | once = 0; |
725 | printk(KERN_NOTICE "ext4: find_group_flex " | 836 | printk(KERN_NOTICE "ext4: find_group_flex " |
@@ -733,11 +844,12 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode) | |||
733 | if (test_opt(sb, OLDALLOC)) | 844 | if (test_opt(sb, OLDALLOC)) |
734 | ret2 = find_group_dir(sb, dir, &group); | 845 | ret2 = find_group_dir(sb, dir, &group); |
735 | else | 846 | else |
736 | ret2 = find_group_orlov(sb, dir, &group); | 847 | ret2 = find_group_orlov(sb, dir, &group, mode); |
737 | } else | 848 | } else |
738 | ret2 = find_group_other(sb, dir, &group); | 849 | ret2 = find_group_other(sb, dir, &group, mode); |
739 | 850 | ||
740 | got_group: | 851 | got_group: |
852 | EXT4_I(dir)->i_last_alloc_group = group; | ||
741 | err = -ENOSPC; | 853 | err = -ENOSPC; |
742 | if (ret2 == -1) | 854 | if (ret2 == -1) |
743 | goto out; | 855 | goto out; |
@@ -858,9 +970,7 @@ got: | |||
858 | 970 | ||
859 | if (sbi->s_log_groups_per_flex) { | 971 | if (sbi->s_log_groups_per_flex) { |
860 | flex_group = ext4_flex_group(sbi, group); | 972 | flex_group = ext4_flex_group(sbi, group); |
861 | spin_lock(sb_bgl_lock(sbi, flex_group)); | 973 | atomic_dec(&sbi->s_flex_groups[flex_group].free_inodes); |
862 | sbi->s_flex_groups[flex_group].free_inodes--; | ||
863 | spin_unlock(sb_bgl_lock(sbi, flex_group)); | ||
864 | } | 974 | } |
865 | 975 | ||
866 | inode->i_uid = current_fsuid(); | 976 | inode->i_uid = current_fsuid(); |
@@ -885,19 +995,16 @@ got: | |||
885 | ei->i_disksize = 0; | 995 | ei->i_disksize = 0; |
886 | 996 | ||
887 | /* | 997 | /* |
888 | * Don't inherit extent flag from directory. We set extent flag on | 998 | * Don't inherit extent flag from directory, amongst others. We set |
889 | * newly created directory and file only if -o extent mount option is | 999 | * extent flag on newly created directory and file only if -o extent |
890 | * specified | 1000 | * mount option is specified |
891 | */ | 1001 | */ |
892 | ei->i_flags = EXT4_I(dir)->i_flags & ~(EXT4_INDEX_FL|EXT4_EXTENTS_FL); | 1002 | ei->i_flags = |
893 | if (S_ISLNK(mode)) | 1003 | ext4_mask_flags(mode, EXT4_I(dir)->i_flags & EXT4_FL_INHERITED); |
894 | ei->i_flags &= ~(EXT4_IMMUTABLE_FL|EXT4_APPEND_FL); | ||
895 | /* dirsync only applies to directories */ | ||
896 | if (!S_ISDIR(mode)) | ||
897 | ei->i_flags &= ~EXT4_DIRSYNC_FL; | ||
898 | ei->i_file_acl = 0; | 1004 | ei->i_file_acl = 0; |
899 | ei->i_dtime = 0; | 1005 | ei->i_dtime = 0; |
900 | ei->i_block_group = group; | 1006 | ei->i_block_group = group; |
1007 | ei->i_last_alloc_group = ~0; | ||
901 | 1008 | ||
902 | ext4_set_inode_flags(inode); | 1009 | ext4_set_inode_flags(inode); |
903 | if (IS_DIRSYNC(inode)) | 1010 | if (IS_DIRSYNC(inode)) |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index dd82ff390067..a2e7952bc5f9 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -371,6 +371,34 @@ static int ext4_block_to_path(struct inode *inode, | |||
371 | return n; | 371 | return n; |
372 | } | 372 | } |
373 | 373 | ||
374 | static int __ext4_check_blockref(const char *function, struct inode *inode, | ||
375 | unsigned int *p, unsigned int max) { | ||
376 | |||
377 | unsigned int maxblocks = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es); | ||
378 | unsigned int *bref = p; | ||
379 | while (bref < p+max) { | ||
380 | if (unlikely(*bref >= maxblocks)) { | ||
381 | ext4_error(inode->i_sb, function, | ||
382 | "block reference %u >= max (%u) " | ||
383 | "in inode #%lu, offset=%d", | ||
384 | *bref, maxblocks, | ||
385 | inode->i_ino, (int)(bref-p)); | ||
386 | return -EIO; | ||
387 | } | ||
388 | bref++; | ||
389 | } | ||
390 | return 0; | ||
391 | } | ||
392 | |||
393 | |||
394 | #define ext4_check_indirect_blockref(inode, bh) \ | ||
395 | __ext4_check_blockref(__func__, inode, (__le32 *)(bh)->b_data, \ | ||
396 | EXT4_ADDR_PER_BLOCK((inode)->i_sb)) | ||
397 | |||
398 | #define ext4_check_inode_blockref(inode) \ | ||
399 | __ext4_check_blockref(__func__, inode, EXT4_I(inode)->i_data, \ | ||
400 | EXT4_NDIR_BLOCKS) | ||
401 | |||
374 | /** | 402 | /** |
375 | * ext4_get_branch - read the chain of indirect blocks leading to data | 403 | * ext4_get_branch - read the chain of indirect blocks leading to data |
376 | * @inode: inode in question | 404 | * @inode: inode in question |
@@ -415,9 +443,22 @@ static Indirect *ext4_get_branch(struct inode *inode, int depth, | |||
415 | if (!p->key) | 443 | if (!p->key) |
416 | goto no_block; | 444 | goto no_block; |
417 | while (--depth) { | 445 | while (--depth) { |
418 | bh = sb_bread(sb, le32_to_cpu(p->key)); | 446 | bh = sb_getblk(sb, le32_to_cpu(p->key)); |
419 | if (!bh) | 447 | if (unlikely(!bh)) |
420 | goto failure; | 448 | goto failure; |
449 | |||
450 | if (!bh_uptodate_or_lock(bh)) { | ||
451 | if (bh_submit_read(bh) < 0) { | ||
452 | put_bh(bh); | ||
453 | goto failure; | ||
454 | } | ||
455 | /* validate block references */ | ||
456 | if (ext4_check_indirect_blockref(inode, bh)) { | ||
457 | put_bh(bh); | ||
458 | goto failure; | ||
459 | } | ||
460 | } | ||
461 | |||
421 | add_chain(++p, bh, (__le32 *)bh->b_data + *++offsets); | 462 | add_chain(++p, bh, (__le32 *)bh->b_data + *++offsets); |
422 | /* Reader: end */ | 463 | /* Reader: end */ |
423 | if (!p->key) | 464 | if (!p->key) |
@@ -459,6 +500,8 @@ static ext4_fsblk_t ext4_find_near(struct inode *inode, Indirect *ind) | |||
459 | ext4_fsblk_t bg_start; | 500 | ext4_fsblk_t bg_start; |
460 | ext4_fsblk_t last_block; | 501 | ext4_fsblk_t last_block; |
461 | ext4_grpblk_t colour; | 502 | ext4_grpblk_t colour; |
503 | ext4_group_t block_group; | ||
504 | int flex_size = ext4_flex_bg_size(EXT4_SB(inode->i_sb)); | ||
462 | 505 | ||
463 | /* Try to find previous block */ | 506 | /* Try to find previous block */ |
464 | for (p = ind->p - 1; p >= start; p--) { | 507 | for (p = ind->p - 1; p >= start; p--) { |
@@ -474,9 +517,22 @@ static ext4_fsblk_t ext4_find_near(struct inode *inode, Indirect *ind) | |||
474 | * It is going to be referred to from the inode itself? OK, just put it | 517 | * It is going to be referred to from the inode itself? OK, just put it |
475 | * into the same cylinder group then. | 518 | * into the same cylinder group then. |
476 | */ | 519 | */ |
477 | bg_start = ext4_group_first_block_no(inode->i_sb, ei->i_block_group); | 520 | block_group = ei->i_block_group; |
521 | if (flex_size >= EXT4_FLEX_SIZE_DIR_ALLOC_SCHEME) { | ||
522 | block_group &= ~(flex_size-1); | ||
523 | if (S_ISREG(inode->i_mode)) | ||
524 | block_group++; | ||
525 | } | ||
526 | bg_start = ext4_group_first_block_no(inode->i_sb, block_group); | ||
478 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; | 527 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; |
479 | 528 | ||
529 | /* | ||
530 | * If we are doing delayed allocation, we don't need take | ||
531 | * colour into account. | ||
532 | */ | ||
533 | if (test_opt(inode->i_sb, DELALLOC)) | ||
534 | return bg_start; | ||
535 | |||
480 | if (bg_start + EXT4_BLOCKS_PER_GROUP(inode->i_sb) <= last_block) | 536 | if (bg_start + EXT4_BLOCKS_PER_GROUP(inode->i_sb) <= last_block) |
481 | colour = (current->pid % 16) * | 537 | colour = (current->pid % 16) * |
482 | (EXT4_BLOCKS_PER_GROUP(inode->i_sb) / 16); | 538 | (EXT4_BLOCKS_PER_GROUP(inode->i_sb) / 16); |
@@ -1052,9 +1108,16 @@ static void ext4_da_update_reserve_space(struct inode *inode, int used) | |||
1052 | /* | 1108 | /* |
1053 | * free those over-booking quota for metadata blocks | 1109 | * free those over-booking quota for metadata blocks |
1054 | */ | 1110 | */ |
1055 | |||
1056 | if (mdb_free) | 1111 | if (mdb_free) |
1057 | vfs_dq_release_reservation_block(inode, mdb_free); | 1112 | vfs_dq_release_reservation_block(inode, mdb_free); |
1113 | |||
1114 | /* | ||
1115 | * If we have done all the pending block allocations and if | ||
1116 | * there aren't any writers on the inode, we can discard the | ||
1117 | * inode's preallocations. | ||
1118 | */ | ||
1119 | if (!total && (atomic_read(&inode->i_writecount) == 0)) | ||
1120 | ext4_discard_preallocations(inode); | ||
1058 | } | 1121 | } |
1059 | 1122 | ||
1060 | /* | 1123 | /* |
@@ -1688,9 +1751,10 @@ static void ext4_da_page_release_reservation(struct page *page, | |||
1688 | 1751 | ||
1689 | struct mpage_da_data { | 1752 | struct mpage_da_data { |
1690 | struct inode *inode; | 1753 | struct inode *inode; |
1691 | struct buffer_head lbh; /* extent of blocks */ | 1754 | sector_t b_blocknr; /* start block number of extent */ |
1755 | size_t b_size; /* size of extent */ | ||
1756 | unsigned long b_state; /* state of the extent */ | ||
1692 | unsigned long first_page, next_page; /* extent of pages */ | 1757 | unsigned long first_page, next_page; /* extent of pages */ |
1693 | get_block_t *get_block; | ||
1694 | struct writeback_control *wbc; | 1758 | struct writeback_control *wbc; |
1695 | int io_done; | 1759 | int io_done; |
1696 | int pages_written; | 1760 | int pages_written; |
@@ -1704,7 +1768,6 @@ struct mpage_da_data { | |||
1704 | * @mpd->inode: inode | 1768 | * @mpd->inode: inode |
1705 | * @mpd->first_page: first page of the extent | 1769 | * @mpd->first_page: first page of the extent |
1706 | * @mpd->next_page: page after the last page of the extent | 1770 | * @mpd->next_page: page after the last page of the extent |
1707 | * @mpd->get_block: the filesystem's block mapper function | ||
1708 | * | 1771 | * |
1709 | * By the time mpage_da_submit_io() is called we expect all blocks | 1772 | * By the time mpage_da_submit_io() is called we expect all blocks |
1710 | * to be allocated. this may be wrong if allocation failed. | 1773 | * to be allocated. this may be wrong if allocation failed. |
@@ -1724,7 +1787,7 @@ static int mpage_da_submit_io(struct mpage_da_data *mpd) | |||
1724 | /* | 1787 | /* |
1725 | * We need to start from the first_page to the next_page - 1 | 1788 | * We need to start from the first_page to the next_page - 1 |
1726 | * to make sure we also write the mapped dirty buffer_heads. | 1789 | * to make sure we also write the mapped dirty buffer_heads. |
1727 | * If we look at mpd->lbh.b_blocknr we would only be looking | 1790 | * If we look at mpd->b_blocknr we would only be looking |
1728 | * at the currently mapped buffer_heads. | 1791 | * at the currently mapped buffer_heads. |
1729 | */ | 1792 | */ |
1730 | index = mpd->first_page; | 1793 | index = mpd->first_page; |
@@ -1914,68 +1977,111 @@ static void ext4_print_free_blocks(struct inode *inode) | |||
1914 | return; | 1977 | return; |
1915 | } | 1978 | } |
1916 | 1979 | ||
1980 | #define EXT4_DELALLOC_RSVED 1 | ||
1981 | static int ext4_da_get_block_write(struct inode *inode, sector_t iblock, | ||
1982 | struct buffer_head *bh_result, int create) | ||
1983 | { | ||
1984 | int ret; | ||
1985 | unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; | ||
1986 | loff_t disksize = EXT4_I(inode)->i_disksize; | ||
1987 | handle_t *handle = NULL; | ||
1988 | |||
1989 | handle = ext4_journal_current_handle(); | ||
1990 | BUG_ON(!handle); | ||
1991 | ret = ext4_get_blocks_wrap(handle, inode, iblock, max_blocks, | ||
1992 | bh_result, create, 0, EXT4_DELALLOC_RSVED); | ||
1993 | if (ret <= 0) | ||
1994 | return ret; | ||
1995 | |||
1996 | bh_result->b_size = (ret << inode->i_blkbits); | ||
1997 | |||
1998 | if (ext4_should_order_data(inode)) { | ||
1999 | int retval; | ||
2000 | retval = ext4_jbd2_file_inode(handle, inode); | ||
2001 | if (retval) | ||
2002 | /* | ||
2003 | * Failed to add inode for ordered mode. Don't | ||
2004 | * update file size | ||
2005 | */ | ||
2006 | return retval; | ||
2007 | } | ||
2008 | |||
2009 | /* | ||
2010 | * Update on-disk size along with block allocation we don't | ||
2011 | * use 'extend_disksize' as size may change within already | ||
2012 | * allocated block -bzzz | ||
2013 | */ | ||
2014 | disksize = ((loff_t) iblock + ret) << inode->i_blkbits; | ||
2015 | if (disksize > i_size_read(inode)) | ||
2016 | disksize = i_size_read(inode); | ||
2017 | if (disksize > EXT4_I(inode)->i_disksize) { | ||
2018 | ext4_update_i_disksize(inode, disksize); | ||
2019 | ret = ext4_mark_inode_dirty(handle, inode); | ||
2020 | return ret; | ||
2021 | } | ||
2022 | return 0; | ||
2023 | } | ||
2024 | |||
1917 | /* | 2025 | /* |
1918 | * mpage_da_map_blocks - go through given space | 2026 | * mpage_da_map_blocks - go through given space |
1919 | * | 2027 | * |
1920 | * @mpd->lbh - bh describing space | 2028 | * @mpd - bh describing space |
1921 | * @mpd->get_block - the filesystem's block mapper function | ||
1922 | * | 2029 | * |
1923 | * The function skips space we know is already mapped to disk blocks. | 2030 | * The function skips space we know is already mapped to disk blocks. |
1924 | * | 2031 | * |
1925 | */ | 2032 | */ |
1926 | static int mpage_da_map_blocks(struct mpage_da_data *mpd) | 2033 | static int mpage_da_map_blocks(struct mpage_da_data *mpd) |
1927 | { | 2034 | { |
1928 | int err = 0; | 2035 | int err = 0; |
1929 | struct buffer_head new; | 2036 | struct buffer_head new; |
1930 | struct buffer_head *lbh = &mpd->lbh; | ||
1931 | sector_t next; | 2037 | sector_t next; |
1932 | 2038 | ||
1933 | /* | 2039 | /* |
1934 | * We consider only non-mapped and non-allocated blocks | 2040 | * We consider only non-mapped and non-allocated blocks |
1935 | */ | 2041 | */ |
1936 | if (buffer_mapped(lbh) && !buffer_delay(lbh)) | 2042 | if ((mpd->b_state & (1 << BH_Mapped)) && |
2043 | !(mpd->b_state & (1 << BH_Delay))) | ||
1937 | return 0; | 2044 | return 0; |
1938 | new.b_state = lbh->b_state; | 2045 | new.b_state = mpd->b_state; |
1939 | new.b_blocknr = 0; | 2046 | new.b_blocknr = 0; |
1940 | new.b_size = lbh->b_size; | 2047 | new.b_size = mpd->b_size; |
1941 | next = lbh->b_blocknr; | 2048 | next = mpd->b_blocknr; |
1942 | /* | 2049 | /* |
1943 | * If we didn't accumulate anything | 2050 | * If we didn't accumulate anything |
1944 | * to write simply return | 2051 | * to write simply return |
1945 | */ | 2052 | */ |
1946 | if (!new.b_size) | 2053 | if (!new.b_size) |
1947 | return 0; | 2054 | return 0; |
1948 | err = mpd->get_block(mpd->inode, next, &new, 1); | ||
1949 | if (err) { | ||
1950 | 2055 | ||
1951 | /* If get block returns with error | 2056 | err = ext4_da_get_block_write(mpd->inode, next, &new, 1); |
1952 | * we simply return. Later writepage | 2057 | if (err) { |
1953 | * will redirty the page and writepages | 2058 | /* |
1954 | * will find the dirty page again | 2059 | * If get block returns with error we simply |
2060 | * return. Later writepage will redirty the page and | ||
2061 | * writepages will find the dirty page again | ||
1955 | */ | 2062 | */ |
1956 | if (err == -EAGAIN) | 2063 | if (err == -EAGAIN) |
1957 | return 0; | 2064 | return 0; |
1958 | 2065 | ||
1959 | if (err == -ENOSPC && | 2066 | if (err == -ENOSPC && |
1960 | ext4_count_free_blocks(mpd->inode->i_sb)) { | 2067 | ext4_count_free_blocks(mpd->inode->i_sb)) { |
1961 | mpd->retval = err; | 2068 | mpd->retval = err; |
1962 | return 0; | 2069 | return 0; |
1963 | } | 2070 | } |
1964 | 2071 | ||
1965 | /* | 2072 | /* |
1966 | * get block failure will cause us | 2073 | * get block failure will cause us to loop in |
1967 | * to loop in writepages. Because | 2074 | * writepages, because a_ops->writepage won't be able |
1968 | * a_ops->writepage won't be able to | 2075 | * to make progress. The page will be redirtied by |
1969 | * make progress. The page will be redirtied | 2076 | * writepage and writepages will again try to write |
1970 | * by writepage and writepages will again | 2077 | * the same. |
1971 | * try to write the same. | ||
1972 | */ | 2078 | */ |
1973 | printk(KERN_EMERG "%s block allocation failed for inode %lu " | 2079 | printk(KERN_EMERG "%s block allocation failed for inode %lu " |
1974 | "at logical offset %llu with max blocks " | 2080 | "at logical offset %llu with max blocks " |
1975 | "%zd with error %d\n", | 2081 | "%zd with error %d\n", |
1976 | __func__, mpd->inode->i_ino, | 2082 | __func__, mpd->inode->i_ino, |
1977 | (unsigned long long)next, | 2083 | (unsigned long long)next, |
1978 | lbh->b_size >> mpd->inode->i_blkbits, err); | 2084 | mpd->b_size >> mpd->inode->i_blkbits, err); |
1979 | printk(KERN_EMERG "This should not happen.!! " | 2085 | printk(KERN_EMERG "This should not happen.!! " |
1980 | "Data will be lost\n"); | 2086 | "Data will be lost\n"); |
1981 | if (err == -ENOSPC) { | 2087 | if (err == -ENOSPC) { |
@@ -1983,7 +2089,7 @@ static int mpage_da_map_blocks(struct mpage_da_data *mpd) | |||
1983 | } | 2089 | } |
1984 | /* invlaidate all the pages */ | 2090 | /* invlaidate all the pages */ |
1985 | ext4_da_block_invalidatepages(mpd, next, | 2091 | ext4_da_block_invalidatepages(mpd, next, |
1986 | lbh->b_size >> mpd->inode->i_blkbits); | 2092 | mpd->b_size >> mpd->inode->i_blkbits); |
1987 | return err; | 2093 | return err; |
1988 | } | 2094 | } |
1989 | BUG_ON(new.b_size == 0); | 2095 | BUG_ON(new.b_size == 0); |
@@ -1995,7 +2101,8 @@ static int mpage_da_map_blocks(struct mpage_da_data *mpd) | |||
1995 | * If blocks are delayed marked, we need to | 2101 | * If blocks are delayed marked, we need to |
1996 | * put actual blocknr and drop delayed bit | 2102 | * put actual blocknr and drop delayed bit |
1997 | */ | 2103 | */ |
1998 | if (buffer_delay(lbh) || buffer_unwritten(lbh)) | 2104 | if ((mpd->b_state & (1 << BH_Delay)) || |
2105 | (mpd->b_state & (1 << BH_Unwritten))) | ||
1999 | mpage_put_bnr_to_bhs(mpd, next, &new); | 2106 | mpage_put_bnr_to_bhs(mpd, next, &new); |
2000 | 2107 | ||
2001 | return 0; | 2108 | return 0; |
@@ -2014,12 +2121,11 @@ static int mpage_da_map_blocks(struct mpage_da_data *mpd) | |||
2014 | * the function is used to collect contig. blocks in same state | 2121 | * the function is used to collect contig. blocks in same state |
2015 | */ | 2122 | */ |
2016 | static void mpage_add_bh_to_extent(struct mpage_da_data *mpd, | 2123 | static void mpage_add_bh_to_extent(struct mpage_da_data *mpd, |
2017 | sector_t logical, struct buffer_head *bh) | 2124 | sector_t logical, size_t b_size, |
2125 | unsigned long b_state) | ||
2018 | { | 2126 | { |
2019 | sector_t next; | 2127 | sector_t next; |
2020 | size_t b_size = bh->b_size; | 2128 | int nrblocks = mpd->b_size >> mpd->inode->i_blkbits; |
2021 | struct buffer_head *lbh = &mpd->lbh; | ||
2022 | int nrblocks = lbh->b_size >> mpd->inode->i_blkbits; | ||
2023 | 2129 | ||
2024 | /* check if thereserved journal credits might overflow */ | 2130 | /* check if thereserved journal credits might overflow */ |
2025 | if (!(EXT4_I(mpd->inode)->i_flags & EXT4_EXTENTS_FL)) { | 2131 | if (!(EXT4_I(mpd->inode)->i_flags & EXT4_EXTENTS_FL)) { |
@@ -2046,19 +2152,19 @@ static void mpage_add_bh_to_extent(struct mpage_da_data *mpd, | |||
2046 | /* | 2152 | /* |
2047 | * First block in the extent | 2153 | * First block in the extent |
2048 | */ | 2154 | */ |
2049 | if (lbh->b_size == 0) { | 2155 | if (mpd->b_size == 0) { |
2050 | lbh->b_blocknr = logical; | 2156 | mpd->b_blocknr = logical; |
2051 | lbh->b_size = b_size; | 2157 | mpd->b_size = b_size; |
2052 | lbh->b_state = bh->b_state & BH_FLAGS; | 2158 | mpd->b_state = b_state & BH_FLAGS; |
2053 | return; | 2159 | return; |
2054 | } | 2160 | } |
2055 | 2161 | ||
2056 | next = lbh->b_blocknr + nrblocks; | 2162 | next = mpd->b_blocknr + nrblocks; |
2057 | /* | 2163 | /* |
2058 | * Can we merge the block to our big extent? | 2164 | * Can we merge the block to our big extent? |
2059 | */ | 2165 | */ |
2060 | if (logical == next && (bh->b_state & BH_FLAGS) == lbh->b_state) { | 2166 | if (logical == next && (b_state & BH_FLAGS) == mpd->b_state) { |
2061 | lbh->b_size += b_size; | 2167 | mpd->b_size += b_size; |
2062 | return; | 2168 | return; |
2063 | } | 2169 | } |
2064 | 2170 | ||
@@ -2087,7 +2193,7 @@ static int __mpage_da_writepage(struct page *page, | |||
2087 | { | 2193 | { |
2088 | struct mpage_da_data *mpd = data; | 2194 | struct mpage_da_data *mpd = data; |
2089 | struct inode *inode = mpd->inode; | 2195 | struct inode *inode = mpd->inode; |
2090 | struct buffer_head *bh, *head, fake; | 2196 | struct buffer_head *bh, *head; |
2091 | sector_t logical; | 2197 | sector_t logical; |
2092 | 2198 | ||
2093 | if (mpd->io_done) { | 2199 | if (mpd->io_done) { |
@@ -2129,9 +2235,9 @@ static int __mpage_da_writepage(struct page *page, | |||
2129 | /* | 2235 | /* |
2130 | * ... and blocks | 2236 | * ... and blocks |
2131 | */ | 2237 | */ |
2132 | mpd->lbh.b_size = 0; | 2238 | mpd->b_size = 0; |
2133 | mpd->lbh.b_state = 0; | 2239 | mpd->b_state = 0; |
2134 | mpd->lbh.b_blocknr = 0; | 2240 | mpd->b_blocknr = 0; |
2135 | } | 2241 | } |
2136 | 2242 | ||
2137 | mpd->next_page = page->index + 1; | 2243 | mpd->next_page = page->index + 1; |
@@ -2139,16 +2245,8 @@ static int __mpage_da_writepage(struct page *page, | |||
2139 | (PAGE_CACHE_SHIFT - inode->i_blkbits); | 2245 | (PAGE_CACHE_SHIFT - inode->i_blkbits); |
2140 | 2246 | ||
2141 | if (!page_has_buffers(page)) { | 2247 | if (!page_has_buffers(page)) { |
2142 | /* | 2248 | mpage_add_bh_to_extent(mpd, logical, PAGE_CACHE_SIZE, |
2143 | * There is no attached buffer heads yet (mmap?) | 2249 | (1 << BH_Dirty) | (1 << BH_Uptodate)); |
2144 | * we treat the page asfull of dirty blocks | ||
2145 | */ | ||
2146 | bh = &fake; | ||
2147 | bh->b_size = PAGE_CACHE_SIZE; | ||
2148 | bh->b_state = 0; | ||
2149 | set_buffer_dirty(bh); | ||
2150 | set_buffer_uptodate(bh); | ||
2151 | mpage_add_bh_to_extent(mpd, logical, bh); | ||
2152 | if (mpd->io_done) | 2250 | if (mpd->io_done) |
2153 | return MPAGE_DA_EXTENT_TAIL; | 2251 | return MPAGE_DA_EXTENT_TAIL; |
2154 | } else { | 2252 | } else { |
@@ -2166,8 +2264,10 @@ static int __mpage_da_writepage(struct page *page, | |||
2166 | * with the page in ext4_da_writepage | 2264 | * with the page in ext4_da_writepage |
2167 | */ | 2265 | */ |
2168 | if (buffer_dirty(bh) && | 2266 | if (buffer_dirty(bh) && |
2169 | (!buffer_mapped(bh) || buffer_delay(bh))) { | 2267 | (!buffer_mapped(bh) || buffer_delay(bh))) { |
2170 | mpage_add_bh_to_extent(mpd, logical, bh); | 2268 | mpage_add_bh_to_extent(mpd, logical, |
2269 | bh->b_size, | ||
2270 | bh->b_state); | ||
2171 | if (mpd->io_done) | 2271 | if (mpd->io_done) |
2172 | return MPAGE_DA_EXTENT_TAIL; | 2272 | return MPAGE_DA_EXTENT_TAIL; |
2173 | } else if (buffer_dirty(bh) && (buffer_mapped(bh))) { | 2273 | } else if (buffer_dirty(bh) && (buffer_mapped(bh))) { |
@@ -2179,9 +2279,8 @@ static int __mpage_da_writepage(struct page *page, | |||
2179 | * unmapped buffer_head later we need to | 2279 | * unmapped buffer_head later we need to |
2180 | * use the b_state flag of that buffer_head. | 2280 | * use the b_state flag of that buffer_head. |
2181 | */ | 2281 | */ |
2182 | if (mpd->lbh.b_size == 0) | 2282 | if (mpd->b_size == 0) |
2183 | mpd->lbh.b_state = | 2283 | mpd->b_state = bh->b_state & BH_FLAGS; |
2184 | bh->b_state & BH_FLAGS; | ||
2185 | } | 2284 | } |
2186 | logical++; | 2285 | logical++; |
2187 | } while ((bh = bh->b_this_page) != head); | 2286 | } while ((bh = bh->b_this_page) != head); |
@@ -2191,51 +2290,6 @@ static int __mpage_da_writepage(struct page *page, | |||
2191 | } | 2290 | } |
2192 | 2291 | ||
2193 | /* | 2292 | /* |
2194 | * mpage_da_writepages - walk the list of dirty pages of the given | ||
2195 | * address space, allocates non-allocated blocks, maps newly-allocated | ||
2196 | * blocks to existing bhs and issue IO them | ||
2197 | * | ||
2198 | * @mapping: address space structure to write | ||
2199 | * @wbc: subtract the number of written pages from *@wbc->nr_to_write | ||
2200 | * @get_block: the filesystem's block mapper function. | ||
2201 | * | ||
2202 | * This is a library function, which implements the writepages() | ||
2203 | * address_space_operation. | ||
2204 | */ | ||
2205 | static int mpage_da_writepages(struct address_space *mapping, | ||
2206 | struct writeback_control *wbc, | ||
2207 | struct mpage_da_data *mpd) | ||
2208 | { | ||
2209 | int ret; | ||
2210 | |||
2211 | if (!mpd->get_block) | ||
2212 | return generic_writepages(mapping, wbc); | ||
2213 | |||
2214 | mpd->lbh.b_size = 0; | ||
2215 | mpd->lbh.b_state = 0; | ||
2216 | mpd->lbh.b_blocknr = 0; | ||
2217 | mpd->first_page = 0; | ||
2218 | mpd->next_page = 0; | ||
2219 | mpd->io_done = 0; | ||
2220 | mpd->pages_written = 0; | ||
2221 | mpd->retval = 0; | ||
2222 | |||
2223 | ret = write_cache_pages(mapping, wbc, __mpage_da_writepage, mpd); | ||
2224 | /* | ||
2225 | * Handle last extent of pages | ||
2226 | */ | ||
2227 | if (!mpd->io_done && mpd->next_page != mpd->first_page) { | ||
2228 | if (mpage_da_map_blocks(mpd) == 0) | ||
2229 | mpage_da_submit_io(mpd); | ||
2230 | |||
2231 | mpd->io_done = 1; | ||
2232 | ret = MPAGE_DA_EXTENT_TAIL; | ||
2233 | } | ||
2234 | wbc->nr_to_write -= mpd->pages_written; | ||
2235 | return ret; | ||
2236 | } | ||
2237 | |||
2238 | /* | ||
2239 | * this is a special callback for ->write_begin() only | 2293 | * this is a special callback for ->write_begin() only |
2240 | * it's intention is to return mapped block or reserve space | 2294 | * it's intention is to return mapped block or reserve space |
2241 | */ | 2295 | */ |
@@ -2274,51 +2328,6 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock, | |||
2274 | 2328 | ||
2275 | return ret; | 2329 | return ret; |
2276 | } | 2330 | } |
2277 | #define EXT4_DELALLOC_RSVED 1 | ||
2278 | static int ext4_da_get_block_write(struct inode *inode, sector_t iblock, | ||
2279 | struct buffer_head *bh_result, int create) | ||
2280 | { | ||
2281 | int ret; | ||
2282 | unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; | ||
2283 | loff_t disksize = EXT4_I(inode)->i_disksize; | ||
2284 | handle_t *handle = NULL; | ||
2285 | |||
2286 | handle = ext4_journal_current_handle(); | ||
2287 | BUG_ON(!handle); | ||
2288 | ret = ext4_get_blocks_wrap(handle, inode, iblock, max_blocks, | ||
2289 | bh_result, create, 0, EXT4_DELALLOC_RSVED); | ||
2290 | if (ret > 0) { | ||
2291 | |||
2292 | bh_result->b_size = (ret << inode->i_blkbits); | ||
2293 | |||
2294 | if (ext4_should_order_data(inode)) { | ||
2295 | int retval; | ||
2296 | retval = ext4_jbd2_file_inode(handle, inode); | ||
2297 | if (retval) | ||
2298 | /* | ||
2299 | * Failed to add inode for ordered | ||
2300 | * mode. Don't update file size | ||
2301 | */ | ||
2302 | return retval; | ||
2303 | } | ||
2304 | |||
2305 | /* | ||
2306 | * Update on-disk size along with block allocation | ||
2307 | * we don't use 'extend_disksize' as size may change | ||
2308 | * within already allocated block -bzzz | ||
2309 | */ | ||
2310 | disksize = ((loff_t) iblock + ret) << inode->i_blkbits; | ||
2311 | if (disksize > i_size_read(inode)) | ||
2312 | disksize = i_size_read(inode); | ||
2313 | if (disksize > EXT4_I(inode)->i_disksize) { | ||
2314 | ext4_update_i_disksize(inode, disksize); | ||
2315 | ret = ext4_mark_inode_dirty(handle, inode); | ||
2316 | return ret; | ||
2317 | } | ||
2318 | ret = 0; | ||
2319 | } | ||
2320 | return ret; | ||
2321 | } | ||
2322 | 2331 | ||
2323 | static int ext4_bh_unmapped_or_delay(handle_t *handle, struct buffer_head *bh) | 2332 | static int ext4_bh_unmapped_or_delay(handle_t *handle, struct buffer_head *bh) |
2324 | { | 2333 | { |
@@ -2569,8 +2578,38 @@ retry: | |||
2569 | dump_stack(); | 2578 | dump_stack(); |
2570 | goto out_writepages; | 2579 | goto out_writepages; |
2571 | } | 2580 | } |
2572 | mpd.get_block = ext4_da_get_block_write; | 2581 | |
2573 | ret = mpage_da_writepages(mapping, wbc, &mpd); | 2582 | /* |
2583 | * Now call __mpage_da_writepage to find the next | ||
2584 | * contiguous region of logical blocks that need | ||
2585 | * blocks to be allocated by ext4. We don't actually | ||
2586 | * submit the blocks for I/O here, even though | ||
2587 | * write_cache_pages thinks it will, and will set the | ||
2588 | * pages as clean for write before calling | ||
2589 | * __mpage_da_writepage(). | ||
2590 | */ | ||
2591 | mpd.b_size = 0; | ||
2592 | mpd.b_state = 0; | ||
2593 | mpd.b_blocknr = 0; | ||
2594 | mpd.first_page = 0; | ||
2595 | mpd.next_page = 0; | ||
2596 | mpd.io_done = 0; | ||
2597 | mpd.pages_written = 0; | ||
2598 | mpd.retval = 0; | ||
2599 | ret = write_cache_pages(mapping, wbc, __mpage_da_writepage, | ||
2600 | &mpd); | ||
2601 | /* | ||
2602 | * If we have a contigous extent of pages and we | ||
2603 | * haven't done the I/O yet, map the blocks and submit | ||
2604 | * them for I/O. | ||
2605 | */ | ||
2606 | if (!mpd.io_done && mpd.next_page != mpd.first_page) { | ||
2607 | if (mpage_da_map_blocks(&mpd) == 0) | ||
2608 | mpage_da_submit_io(&mpd); | ||
2609 | mpd.io_done = 1; | ||
2610 | ret = MPAGE_DA_EXTENT_TAIL; | ||
2611 | } | ||
2612 | wbc->nr_to_write -= mpd.pages_written; | ||
2574 | 2613 | ||
2575 | ext4_journal_stop(handle); | 2614 | ext4_journal_stop(handle); |
2576 | 2615 | ||
@@ -2846,6 +2885,48 @@ out: | |||
2846 | return; | 2885 | return; |
2847 | } | 2886 | } |
2848 | 2887 | ||
2888 | /* | ||
2889 | * Force all delayed allocation blocks to be allocated for a given inode. | ||
2890 | */ | ||
2891 | int ext4_alloc_da_blocks(struct inode *inode) | ||
2892 | { | ||
2893 | if (!EXT4_I(inode)->i_reserved_data_blocks && | ||
2894 | !EXT4_I(inode)->i_reserved_meta_blocks) | ||
2895 | return 0; | ||
2896 | |||
2897 | /* | ||
2898 | * We do something simple for now. The filemap_flush() will | ||
2899 | * also start triggering a write of the data blocks, which is | ||
2900 | * not strictly speaking necessary (and for users of | ||
2901 | * laptop_mode, not even desirable). However, to do otherwise | ||
2902 | * would require replicating code paths in: | ||
2903 | * | ||
2904 | * ext4_da_writepages() -> | ||
2905 | * write_cache_pages() ---> (via passed in callback function) | ||
2906 | * __mpage_da_writepage() --> | ||
2907 | * mpage_add_bh_to_extent() | ||
2908 | * mpage_da_map_blocks() | ||
2909 | * | ||
2910 | * The problem is that write_cache_pages(), located in | ||
2911 | * mm/page-writeback.c, marks pages clean in preparation for | ||
2912 | * doing I/O, which is not desirable if we're not planning on | ||
2913 | * doing I/O at all. | ||
2914 | * | ||
2915 | * We could call write_cache_pages(), and then redirty all of | ||
2916 | * the pages by calling redirty_page_for_writeback() but that | ||
2917 | * would be ugly in the extreme. So instead we would need to | ||
2918 | * replicate parts of the code in the above functions, | ||
2919 | * simplifying them becuase we wouldn't actually intend to | ||
2920 | * write out the pages, but rather only collect contiguous | ||
2921 | * logical block extents, call the multi-block allocator, and | ||
2922 | * then update the buffer heads with the block allocations. | ||
2923 | * | ||
2924 | * For now, though, we'll cheat by calling filemap_flush(), | ||
2925 | * which will map the blocks, and start the I/O, but not | ||
2926 | * actually wait for the I/O to complete. | ||
2927 | */ | ||
2928 | return filemap_flush(inode->i_mapping); | ||
2929 | } | ||
2849 | 2930 | ||
2850 | /* | 2931 | /* |
2851 | * bmap() is special. It gets used by applications such as lilo and by | 2932 | * bmap() is special. It gets used by applications such as lilo and by |
@@ -3868,6 +3949,9 @@ void ext4_truncate(struct inode *inode) | |||
3868 | if (!ext4_can_truncate(inode)) | 3949 | if (!ext4_can_truncate(inode)) |
3869 | return; | 3950 | return; |
3870 | 3951 | ||
3952 | if (inode->i_size == 0 && !test_opt(inode->i_sb, NO_AUTO_DA_ALLOC)) | ||
3953 | ei->i_state |= EXT4_STATE_DA_ALLOC_CLOSE; | ||
3954 | |||
3871 | if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { | 3955 | if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { |
3872 | ext4_ext_truncate(inode); | 3956 | ext4_ext_truncate(inode); |
3873 | return; | 3957 | return; |
@@ -4110,12 +4194,7 @@ make_io: | |||
4110 | unsigned num; | 4194 | unsigned num; |
4111 | 4195 | ||
4112 | table = ext4_inode_table(sb, gdp); | 4196 | table = ext4_inode_table(sb, gdp); |
4113 | /* Make sure s_inode_readahead_blks is a power of 2 */ | 4197 | /* s_inode_readahead_blks is always a power of 2 */ |
4114 | while (EXT4_SB(sb)->s_inode_readahead_blks & | ||
4115 | (EXT4_SB(sb)->s_inode_readahead_blks-1)) | ||
4116 | EXT4_SB(sb)->s_inode_readahead_blks = | ||
4117 | (EXT4_SB(sb)->s_inode_readahead_blks & | ||
4118 | (EXT4_SB(sb)->s_inode_readahead_blks-1)); | ||
4119 | b = block & ~(EXT4_SB(sb)->s_inode_readahead_blks-1); | 4198 | b = block & ~(EXT4_SB(sb)->s_inode_readahead_blks-1); |
4120 | if (table > b) | 4199 | if (table > b) |
4121 | b = table; | 4200 | b = table; |
@@ -4287,6 +4366,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4287 | ei->i_disksize = inode->i_size; | 4366 | ei->i_disksize = inode->i_size; |
4288 | inode->i_generation = le32_to_cpu(raw_inode->i_generation); | 4367 | inode->i_generation = le32_to_cpu(raw_inode->i_generation); |
4289 | ei->i_block_group = iloc.block_group; | 4368 | ei->i_block_group = iloc.block_group; |
4369 | ei->i_last_alloc_group = ~0; | ||
4290 | /* | 4370 | /* |
4291 | * NOTE! The in-memory inode i_data array is in little-endian order | 4371 | * NOTE! The in-memory inode i_data array is in little-endian order |
4292 | * even on big-endian machines: we do NOT byteswap the block numbers! | 4372 | * even on big-endian machines: we do NOT byteswap the block numbers! |
@@ -4329,6 +4409,20 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4329 | (__u64)(le32_to_cpu(raw_inode->i_version_hi)) << 32; | 4409 | (__u64)(le32_to_cpu(raw_inode->i_version_hi)) << 32; |
4330 | } | 4410 | } |
4331 | 4411 | ||
4412 | if (ei->i_flags & EXT4_EXTENTS_FL) { | ||
4413 | /* Validate extent which is part of inode */ | ||
4414 | ret = ext4_ext_check_inode(inode); | ||
4415 | } else if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || | ||
4416 | (S_ISLNK(inode->i_mode) && | ||
4417 | !ext4_inode_is_fast_symlink(inode))) { | ||
4418 | /* Validate block references which are part of inode */ | ||
4419 | ret = ext4_check_inode_blockref(inode); | ||
4420 | } | ||
4421 | if (ret) { | ||
4422 | brelse(bh); | ||
4423 | goto bad_inode; | ||
4424 | } | ||
4425 | |||
4332 | if (S_ISREG(inode->i_mode)) { | 4426 | if (S_ISREG(inode->i_mode)) { |
4333 | inode->i_op = &ext4_file_inode_operations; | 4427 | inode->i_op = &ext4_file_inode_operations; |
4334 | inode->i_fop = &ext4_file_operations; | 4428 | inode->i_fop = &ext4_file_operations; |
@@ -4345,7 +4439,8 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4345 | inode->i_op = &ext4_symlink_inode_operations; | 4439 | inode->i_op = &ext4_symlink_inode_operations; |
4346 | ext4_set_aops(inode); | 4440 | ext4_set_aops(inode); |
4347 | } | 4441 | } |
4348 | } else { | 4442 | } else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) || |
4443 | S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) { | ||
4349 | inode->i_op = &ext4_special_inode_operations; | 4444 | inode->i_op = &ext4_special_inode_operations; |
4350 | if (raw_inode->i_block[0]) | 4445 | if (raw_inode->i_block[0]) |
4351 | init_special_inode(inode, inode->i_mode, | 4446 | init_special_inode(inode, inode->i_mode, |
@@ -4353,6 +4448,13 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4353 | else | 4448 | else |
4354 | init_special_inode(inode, inode->i_mode, | 4449 | init_special_inode(inode, inode->i_mode, |
4355 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); | 4450 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); |
4451 | } else { | ||
4452 | brelse(bh); | ||
4453 | ret = -EIO; | ||
4454 | ext4_error(inode->i_sb, __func__, | ||
4455 | "bogus i_mode (%o) for inode=%lu", | ||
4456 | inode->i_mode, inode->i_ino); | ||
4457 | goto bad_inode; | ||
4356 | } | 4458 | } |
4357 | brelse(iloc.bh); | 4459 | brelse(iloc.bh); |
4358 | ext4_set_inode_flags(inode); | 4460 | ext4_set_inode_flags(inode); |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 42dc83fb247a..91e75f7a9e73 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c | |||
@@ -48,8 +48,7 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
48 | if (err) | 48 | if (err) |
49 | return err; | 49 | return err; |
50 | 50 | ||
51 | if (!S_ISDIR(inode->i_mode)) | 51 | flags = ext4_mask_flags(inode->i_mode, flags); |
52 | flags &= ~EXT4_DIRSYNC_FL; | ||
53 | 52 | ||
54 | err = -EPERM; | 53 | err = -EPERM; |
55 | mutex_lock(&inode->i_mutex); | 54 | mutex_lock(&inode->i_mutex); |
@@ -263,6 +262,20 @@ setversion_out: | |||
263 | return err; | 262 | return err; |
264 | } | 263 | } |
265 | 264 | ||
265 | case EXT4_IOC_ALLOC_DA_BLKS: | ||
266 | { | ||
267 | int err; | ||
268 | if (!is_owner_or_cap(inode)) | ||
269 | return -EACCES; | ||
270 | |||
271 | err = mnt_want_write(filp->f_path.mnt); | ||
272 | if (err) | ||
273 | return err; | ||
274 | err = ext4_alloc_da_blocks(inode); | ||
275 | mnt_drop_write(filp->f_path.mnt); | ||
276 | return err; | ||
277 | } | ||
278 | |||
266 | default: | 279 | default: |
267 | return -ENOTTY; | 280 | return -ENOTTY; |
268 | } | 281 | } |
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index b038188bd039..f871677a7984 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
@@ -46,22 +46,23 @@ | |||
46 | * The allocation request involve request for multiple number of blocks | 46 | * The allocation request involve request for multiple number of blocks |
47 | * near to the goal(block) value specified. | 47 | * near to the goal(block) value specified. |
48 | * | 48 | * |
49 | * During initialization phase of the allocator we decide to use the group | 49 | * During initialization phase of the allocator we decide to use the |
50 | * preallocation or inode preallocation depending on the size file. The | 50 | * group preallocation or inode preallocation depending on the size of |
51 | * size of the file could be the resulting file size we would have after | 51 | * the file. The size of the file could be the resulting file size we |
52 | * allocation or the current file size which ever is larger. If the size is | 52 | * would have after allocation, or the current file size, which ever |
53 | * less that sbi->s_mb_stream_request we select the group | 53 | * is larger. If the size is less than sbi->s_mb_stream_request we |
54 | * preallocation. The default value of s_mb_stream_request is 16 | 54 | * select to use the group preallocation. The default value of |
55 | * blocks. This can also be tuned via | 55 | * s_mb_stream_request is 16 blocks. This can also be tuned via |
56 | * /proc/fs/ext4/<partition>/stream_req. The value is represented in terms | 56 | * /sys/fs/ext4/<partition>/mb_stream_req. The value is represented in |
57 | * of number of blocks. | 57 | * terms of number of blocks. |
58 | * | 58 | * |
59 | * The main motivation for having small file use group preallocation is to | 59 | * The main motivation for having small file use group preallocation is to |
60 | * ensure that we have small file closer in the disk. | 60 | * ensure that we have small files closer together on the disk. |
61 | * | 61 | * |
62 | * First stage the allocator looks at the inode prealloc list | 62 | * First stage the allocator looks at the inode prealloc list, |
63 | * ext4_inode_info->i_prealloc_list contain list of prealloc spaces for | 63 | * ext4_inode_info->i_prealloc_list, which contains list of prealloc |
64 | * this particular inode. The inode prealloc space is represented as: | 64 | * spaces for this particular inode. The inode prealloc space is |
65 | * represented as: | ||
65 | * | 66 | * |
66 | * pa_lstart -> the logical start block for this prealloc space | 67 | * pa_lstart -> the logical start block for this prealloc space |
67 | * pa_pstart -> the physical start block for this prealloc space | 68 | * pa_pstart -> the physical start block for this prealloc space |
@@ -121,29 +122,29 @@ | |||
121 | * list. In case of inode preallocation we follow a list of heuristics | 122 | * list. In case of inode preallocation we follow a list of heuristics |
122 | * based on file size. This can be found in ext4_mb_normalize_request. If | 123 | * based on file size. This can be found in ext4_mb_normalize_request. If |
123 | * we are doing a group prealloc we try to normalize the request to | 124 | * we are doing a group prealloc we try to normalize the request to |
124 | * sbi->s_mb_group_prealloc. Default value of s_mb_group_prealloc is set to | 125 | * sbi->s_mb_group_prealloc. Default value of s_mb_group_prealloc is |
125 | * 512 blocks. This can be tuned via | 126 | * 512 blocks. This can be tuned via |
126 | * /proc/fs/ext4/<partition/group_prealloc. The value is represented in | 127 | * /sys/fs/ext4/<partition/mb_group_prealloc. The value is represented in |
127 | * terms of number of blocks. If we have mounted the file system with -O | 128 | * terms of number of blocks. If we have mounted the file system with -O |
128 | * stripe=<value> option the group prealloc request is normalized to the | 129 | * stripe=<value> option the group prealloc request is normalized to the |
129 | * stripe value (sbi->s_stripe) | 130 | * stripe value (sbi->s_stripe) |
130 | * | 131 | * |
131 | * The regular allocator(using the buddy cache) support few tunables. | 132 | * The regular allocator(using the buddy cache) supports few tunables. |
132 | * | 133 | * |
133 | * /proc/fs/ext4/<partition>/min_to_scan | 134 | * /sys/fs/ext4/<partition>/mb_min_to_scan |
134 | * /proc/fs/ext4/<partition>/max_to_scan | 135 | * /sys/fs/ext4/<partition>/mb_max_to_scan |
135 | * /proc/fs/ext4/<partition>/order2_req | 136 | * /sys/fs/ext4/<partition>/mb_order2_req |
136 | * | 137 | * |
137 | * The regular allocator use buddy scan only if the request len is power of | 138 | * The regular allocator uses buddy scan only if the request len is power of |
138 | * 2 blocks and the order of allocation is >= sbi->s_mb_order2_reqs. The | 139 | * 2 blocks and the order of allocation is >= sbi->s_mb_order2_reqs. The |
139 | * value of s_mb_order2_reqs can be tuned via | 140 | * value of s_mb_order2_reqs can be tuned via |
140 | * /proc/fs/ext4/<partition>/order2_req. If the request len is equal to | 141 | * /sys/fs/ext4/<partition>/mb_order2_req. If the request len is equal to |
141 | * stripe size (sbi->s_stripe), we try to search for contigous block in | 142 | * stripe size (sbi->s_stripe), we try to search for contigous block in |
142 | * stripe size. This should result in better allocation on RAID setup. If | 143 | * stripe size. This should result in better allocation on RAID setups. If |
143 | * not we search in the specific group using bitmap for best extents. The | 144 | * not, we search in the specific group using bitmap for best extents. The |
144 | * tunable min_to_scan and max_to_scan controll the behaviour here. | 145 | * tunable min_to_scan and max_to_scan control the behaviour here. |
145 | * min_to_scan indicate how long the mballoc __must__ look for a best | 146 | * min_to_scan indicate how long the mballoc __must__ look for a best |
146 | * extent and max_to_scanindicate how long the mballoc __can__ look for a | 147 | * extent and max_to_scan indicates how long the mballoc __can__ look for a |
147 | * best extent in the found extents. Searching for the blocks starts with | 148 | * best extent in the found extents. Searching for the blocks starts with |
148 | * the group specified as the goal value in allocation context via | 149 | * the group specified as the goal value in allocation context via |
149 | * ac_g_ex. Each group is first checked based on the criteria whether it | 150 | * ac_g_ex. Each group is first checked based on the criteria whether it |
@@ -337,8 +338,6 @@ static void ext4_mb_generate_from_pa(struct super_block *sb, void *bitmap, | |||
337 | ext4_group_t group); | 338 | ext4_group_t group); |
338 | static void ext4_mb_generate_from_freelist(struct super_block *sb, void *bitmap, | 339 | static void ext4_mb_generate_from_freelist(struct super_block *sb, void *bitmap, |
339 | ext4_group_t group); | 340 | ext4_group_t group); |
340 | static int ext4_mb_init_per_dev_proc(struct super_block *sb); | ||
341 | static int ext4_mb_destroy_per_dev_proc(struct super_block *sb); | ||
342 | static void release_blocks_on_commit(journal_t *journal, transaction_t *txn); | 341 | static void release_blocks_on_commit(journal_t *journal, transaction_t *txn); |
343 | 342 | ||
344 | 343 | ||
@@ -1726,6 +1725,7 @@ static int ext4_mb_good_group(struct ext4_allocation_context *ac, | |||
1726 | { | 1725 | { |
1727 | unsigned free, fragments; | 1726 | unsigned free, fragments; |
1728 | unsigned i, bits; | 1727 | unsigned i, bits; |
1728 | int flex_size = ext4_flex_bg_size(EXT4_SB(ac->ac_sb)); | ||
1729 | struct ext4_group_desc *desc; | 1729 | struct ext4_group_desc *desc; |
1730 | struct ext4_group_info *grp = ext4_get_group_info(ac->ac_sb, group); | 1730 | struct ext4_group_info *grp = ext4_get_group_info(ac->ac_sb, group); |
1731 | 1731 | ||
@@ -1747,6 +1747,12 @@ static int ext4_mb_good_group(struct ext4_allocation_context *ac, | |||
1747 | if (desc->bg_flags & cpu_to_le16(EXT4_BG_BLOCK_UNINIT)) | 1747 | if (desc->bg_flags & cpu_to_le16(EXT4_BG_BLOCK_UNINIT)) |
1748 | return 0; | 1748 | return 0; |
1749 | 1749 | ||
1750 | /* Avoid using the first bg of a flexgroup for data files */ | ||
1751 | if ((ac->ac_flags & EXT4_MB_HINT_DATA) && | ||
1752 | (flex_size >= EXT4_FLEX_SIZE_DIR_ALLOC_SCHEME) && | ||
1753 | ((group % flex_size) == 0)) | ||
1754 | return 0; | ||
1755 | |||
1750 | bits = ac->ac_sb->s_blocksize_bits + 1; | 1756 | bits = ac->ac_sb->s_blocksize_bits + 1; |
1751 | for (i = ac->ac_2order; i <= bits; i++) | 1757 | for (i = ac->ac_2order; i <= bits; i++) |
1752 | if (grp->bb_counters[i] > 0) | 1758 | if (grp->bb_counters[i] > 0) |
@@ -1971,7 +1977,7 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) | |||
1971 | /* | 1977 | /* |
1972 | * We search using buddy data only if the order of the request | 1978 | * We search using buddy data only if the order of the request |
1973 | * is greater than equal to the sbi_s_mb_order2_reqs | 1979 | * is greater than equal to the sbi_s_mb_order2_reqs |
1974 | * You can tune it via /proc/fs/ext4/<partition>/order2_req | 1980 | * You can tune it via /sys/fs/ext4/<partition>/mb_order2_req |
1975 | */ | 1981 | */ |
1976 | if (i >= sbi->s_mb_order2_reqs) { | 1982 | if (i >= sbi->s_mb_order2_reqs) { |
1977 | /* | 1983 | /* |
@@ -2693,7 +2699,7 @@ int ext4_mb_init(struct super_block *sb, int needs_recovery) | |||
2693 | i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int); | 2699 | i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int); |
2694 | sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL); | 2700 | sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL); |
2695 | if (sbi->s_mb_maxs == NULL) { | 2701 | if (sbi->s_mb_maxs == NULL) { |
2696 | kfree(sbi->s_mb_maxs); | 2702 | kfree(sbi->s_mb_offsets); |
2697 | return -ENOMEM; | 2703 | return -ENOMEM; |
2698 | } | 2704 | } |
2699 | 2705 | ||
@@ -2746,7 +2752,6 @@ int ext4_mb_init(struct super_block *sb, int needs_recovery) | |||
2746 | spin_lock_init(&lg->lg_prealloc_lock); | 2752 | spin_lock_init(&lg->lg_prealloc_lock); |
2747 | } | 2753 | } |
2748 | 2754 | ||
2749 | ext4_mb_init_per_dev_proc(sb); | ||
2750 | ext4_mb_history_init(sb); | 2755 | ext4_mb_history_init(sb); |
2751 | 2756 | ||
2752 | if (sbi->s_journal) | 2757 | if (sbi->s_journal) |
@@ -2829,7 +2834,6 @@ int ext4_mb_release(struct super_block *sb) | |||
2829 | 2834 | ||
2830 | free_percpu(sbi->s_locality_groups); | 2835 | free_percpu(sbi->s_locality_groups); |
2831 | ext4_mb_history_release(sb); | 2836 | ext4_mb_history_release(sb); |
2832 | ext4_mb_destroy_per_dev_proc(sb); | ||
2833 | 2837 | ||
2834 | return 0; | 2838 | return 0; |
2835 | } | 2839 | } |
@@ -2890,62 +2894,6 @@ static void release_blocks_on_commit(journal_t *journal, transaction_t *txn) | |||
2890 | mb_debug("freed %u blocks in %u structures\n", count, count2); | 2894 | mb_debug("freed %u blocks in %u structures\n", count, count2); |
2891 | } | 2895 | } |
2892 | 2896 | ||
2893 | #define EXT4_MB_STATS_NAME "stats" | ||
2894 | #define EXT4_MB_MAX_TO_SCAN_NAME "max_to_scan" | ||
2895 | #define EXT4_MB_MIN_TO_SCAN_NAME "min_to_scan" | ||
2896 | #define EXT4_MB_ORDER2_REQ "order2_req" | ||
2897 | #define EXT4_MB_STREAM_REQ "stream_req" | ||
2898 | #define EXT4_MB_GROUP_PREALLOC "group_prealloc" | ||
2899 | |||
2900 | static int ext4_mb_init_per_dev_proc(struct super_block *sb) | ||
2901 | { | ||
2902 | #ifdef CONFIG_PROC_FS | ||
2903 | mode_t mode = S_IFREG | S_IRUGO | S_IWUSR; | ||
2904 | struct ext4_sb_info *sbi = EXT4_SB(sb); | ||
2905 | struct proc_dir_entry *proc; | ||
2906 | |||
2907 | if (sbi->s_proc == NULL) | ||
2908 | return -EINVAL; | ||
2909 | |||
2910 | EXT4_PROC_HANDLER(EXT4_MB_STATS_NAME, mb_stats); | ||
2911 | EXT4_PROC_HANDLER(EXT4_MB_MAX_TO_SCAN_NAME, mb_max_to_scan); | ||
2912 | EXT4_PROC_HANDLER(EXT4_MB_MIN_TO_SCAN_NAME, mb_min_to_scan); | ||
2913 | EXT4_PROC_HANDLER(EXT4_MB_ORDER2_REQ, mb_order2_reqs); | ||
2914 | EXT4_PROC_HANDLER(EXT4_MB_STREAM_REQ, mb_stream_request); | ||
2915 | EXT4_PROC_HANDLER(EXT4_MB_GROUP_PREALLOC, mb_group_prealloc); | ||
2916 | return 0; | ||
2917 | |||
2918 | err_out: | ||
2919 | remove_proc_entry(EXT4_MB_GROUP_PREALLOC, sbi->s_proc); | ||
2920 | remove_proc_entry(EXT4_MB_STREAM_REQ, sbi->s_proc); | ||
2921 | remove_proc_entry(EXT4_MB_ORDER2_REQ, sbi->s_proc); | ||
2922 | remove_proc_entry(EXT4_MB_MIN_TO_SCAN_NAME, sbi->s_proc); | ||
2923 | remove_proc_entry(EXT4_MB_MAX_TO_SCAN_NAME, sbi->s_proc); | ||
2924 | remove_proc_entry(EXT4_MB_STATS_NAME, sbi->s_proc); | ||
2925 | return -ENOMEM; | ||
2926 | #else | ||
2927 | return 0; | ||
2928 | #endif | ||
2929 | } | ||
2930 | |||
2931 | static int ext4_mb_destroy_per_dev_proc(struct super_block *sb) | ||
2932 | { | ||
2933 | #ifdef CONFIG_PROC_FS | ||
2934 | struct ext4_sb_info *sbi = EXT4_SB(sb); | ||
2935 | |||
2936 | if (sbi->s_proc == NULL) | ||
2937 | return -EINVAL; | ||
2938 | |||
2939 | remove_proc_entry(EXT4_MB_GROUP_PREALLOC, sbi->s_proc); | ||
2940 | remove_proc_entry(EXT4_MB_STREAM_REQ, sbi->s_proc); | ||
2941 | remove_proc_entry(EXT4_MB_ORDER2_REQ, sbi->s_proc); | ||
2942 | remove_proc_entry(EXT4_MB_MIN_TO_SCAN_NAME, sbi->s_proc); | ||
2943 | remove_proc_entry(EXT4_MB_MAX_TO_SCAN_NAME, sbi->s_proc); | ||
2944 | remove_proc_entry(EXT4_MB_STATS_NAME, sbi->s_proc); | ||
2945 | #endif | ||
2946 | return 0; | ||
2947 | } | ||
2948 | |||
2949 | int __init init_ext4_mballoc(void) | 2897 | int __init init_ext4_mballoc(void) |
2950 | { | 2898 | { |
2951 | ext4_pspace_cachep = | 2899 | ext4_pspace_cachep = |
@@ -3096,9 +3044,8 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, | |||
3096 | if (sbi->s_log_groups_per_flex) { | 3044 | if (sbi->s_log_groups_per_flex) { |
3097 | ext4_group_t flex_group = ext4_flex_group(sbi, | 3045 | ext4_group_t flex_group = ext4_flex_group(sbi, |
3098 | ac->ac_b_ex.fe_group); | 3046 | ac->ac_b_ex.fe_group); |
3099 | spin_lock(sb_bgl_lock(sbi, flex_group)); | 3047 | atomic_sub(ac->ac_b_ex.fe_len, |
3100 | sbi->s_flex_groups[flex_group].free_blocks -= ac->ac_b_ex.fe_len; | 3048 | &sbi->s_flex_groups[flex_group].free_blocks); |
3101 | spin_unlock(sb_bgl_lock(sbi, flex_group)); | ||
3102 | } | 3049 | } |
3103 | 3050 | ||
3104 | err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh); | 3051 | err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh); |
@@ -3116,7 +3063,7 @@ out_err: | |||
3116 | * here we normalize request for locality group | 3063 | * here we normalize request for locality group |
3117 | * Group request are normalized to s_strip size if we set the same via mount | 3064 | * Group request are normalized to s_strip size if we set the same via mount |
3118 | * option. If not we set it to s_mb_group_prealloc which can be configured via | 3065 | * option. If not we set it to s_mb_group_prealloc which can be configured via |
3119 | * /proc/fs/ext4/<partition>/group_prealloc | 3066 | * /sys/fs/ext4/<partition>/mb_group_prealloc |
3120 | * | 3067 | * |
3121 | * XXX: should we try to preallocate more than the group has now? | 3068 | * XXX: should we try to preallocate more than the group has now? |
3122 | */ | 3069 | */ |
@@ -3608,8 +3555,11 @@ static void ext4_mb_put_pa(struct ext4_allocation_context *ac, | |||
3608 | spin_unlock(&pa->pa_lock); | 3555 | spin_unlock(&pa->pa_lock); |
3609 | 3556 | ||
3610 | grp_blk = pa->pa_pstart; | 3557 | grp_blk = pa->pa_pstart; |
3611 | /* If linear, pa_pstart may be in the next group when pa is used up */ | 3558 | /* |
3612 | if (pa->pa_linear) | 3559 | * If doing group-based preallocation, pa_pstart may be in the |
3560 | * next group when pa is used up | ||
3561 | */ | ||
3562 | if (pa->pa_type == MB_GROUP_PA) | ||
3613 | grp_blk--; | 3563 | grp_blk--; |
3614 | 3564 | ||
3615 | ext4_get_group_no_and_offset(sb, grp_blk, &grp, NULL); | 3565 | ext4_get_group_no_and_offset(sb, grp_blk, &grp, NULL); |
@@ -3704,7 +3654,7 @@ ext4_mb_new_inode_pa(struct ext4_allocation_context *ac) | |||
3704 | INIT_LIST_HEAD(&pa->pa_inode_list); | 3654 | INIT_LIST_HEAD(&pa->pa_inode_list); |
3705 | INIT_LIST_HEAD(&pa->pa_group_list); | 3655 | INIT_LIST_HEAD(&pa->pa_group_list); |
3706 | pa->pa_deleted = 0; | 3656 | pa->pa_deleted = 0; |
3707 | pa->pa_linear = 0; | 3657 | pa->pa_type = MB_INODE_PA; |
3708 | 3658 | ||
3709 | mb_debug("new inode pa %p: %llu/%u for %u\n", pa, | 3659 | mb_debug("new inode pa %p: %llu/%u for %u\n", pa, |
3710 | pa->pa_pstart, pa->pa_len, pa->pa_lstart); | 3660 | pa->pa_pstart, pa->pa_len, pa->pa_lstart); |
@@ -3767,7 +3717,7 @@ ext4_mb_new_group_pa(struct ext4_allocation_context *ac) | |||
3767 | INIT_LIST_HEAD(&pa->pa_inode_list); | 3717 | INIT_LIST_HEAD(&pa->pa_inode_list); |
3768 | INIT_LIST_HEAD(&pa->pa_group_list); | 3718 | INIT_LIST_HEAD(&pa->pa_group_list); |
3769 | pa->pa_deleted = 0; | 3719 | pa->pa_deleted = 0; |
3770 | pa->pa_linear = 1; | 3720 | pa->pa_type = MB_GROUP_PA; |
3771 | 3721 | ||
3772 | mb_debug("new group pa %p: %llu/%u for %u\n", pa, | 3722 | mb_debug("new group pa %p: %llu/%u for %u\n", pa, |
3773 | pa->pa_pstart, pa->pa_len, pa->pa_lstart); | 3723 | pa->pa_pstart, pa->pa_len, pa->pa_lstart); |
@@ -4021,7 +3971,7 @@ repeat: | |||
4021 | list_del_rcu(&pa->pa_inode_list); | 3971 | list_del_rcu(&pa->pa_inode_list); |
4022 | spin_unlock(pa->pa_obj_lock); | 3972 | spin_unlock(pa->pa_obj_lock); |
4023 | 3973 | ||
4024 | if (pa->pa_linear) | 3974 | if (pa->pa_type == MB_GROUP_PA) |
4025 | ext4_mb_release_group_pa(&e4b, pa, ac); | 3975 | ext4_mb_release_group_pa(&e4b, pa, ac); |
4026 | else | 3976 | else |
4027 | ext4_mb_release_inode_pa(&e4b, bitmap_bh, pa, ac); | 3977 | ext4_mb_release_inode_pa(&e4b, bitmap_bh, pa, ac); |
@@ -4121,7 +4071,7 @@ repeat: | |||
4121 | spin_unlock(&ei->i_prealloc_lock); | 4071 | spin_unlock(&ei->i_prealloc_lock); |
4122 | 4072 | ||
4123 | list_for_each_entry_safe(pa, tmp, &list, u.pa_tmp_list) { | 4073 | list_for_each_entry_safe(pa, tmp, &list, u.pa_tmp_list) { |
4124 | BUG_ON(pa->pa_linear != 0); | 4074 | BUG_ON(pa->pa_type != MB_INODE_PA); |
4125 | ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, NULL); | 4075 | ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, NULL); |
4126 | 4076 | ||
4127 | err = ext4_mb_load_buddy(sb, group, &e4b); | 4077 | err = ext4_mb_load_buddy(sb, group, &e4b); |
@@ -4232,7 +4182,7 @@ static inline void ext4_mb_show_ac(struct ext4_allocation_context *ac) | |||
4232 | * file is determined by the current size or the resulting size after | 4182 | * file is determined by the current size or the resulting size after |
4233 | * allocation which ever is larger | 4183 | * allocation which ever is larger |
4234 | * | 4184 | * |
4235 | * One can tune this size via /proc/fs/ext4/<partition>/stream_req | 4185 | * One can tune this size via /sys/fs/ext4/<partition>/mb_stream_req |
4236 | */ | 4186 | */ |
4237 | static void ext4_mb_group_or_file(struct ext4_allocation_context *ac) | 4187 | static void ext4_mb_group_or_file(struct ext4_allocation_context *ac) |
4238 | { | 4188 | { |
@@ -4373,7 +4323,7 @@ ext4_mb_discard_lg_preallocations(struct super_block *sb, | |||
4373 | continue; | 4323 | continue; |
4374 | } | 4324 | } |
4375 | /* only lg prealloc space */ | 4325 | /* only lg prealloc space */ |
4376 | BUG_ON(!pa->pa_linear); | 4326 | BUG_ON(pa->pa_type != MB_GROUP_PA); |
4377 | 4327 | ||
4378 | /* seems this one can be freed ... */ | 4328 | /* seems this one can be freed ... */ |
4379 | pa->pa_deleted = 1; | 4329 | pa->pa_deleted = 1; |
@@ -4442,7 +4392,7 @@ static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac) | |||
4442 | pa_inode_list) { | 4392 | pa_inode_list) { |
4443 | spin_lock(&tmp_pa->pa_lock); | 4393 | spin_lock(&tmp_pa->pa_lock); |
4444 | if (tmp_pa->pa_deleted) { | 4394 | if (tmp_pa->pa_deleted) { |
4445 | spin_unlock(&pa->pa_lock); | 4395 | spin_unlock(&tmp_pa->pa_lock); |
4446 | continue; | 4396 | continue; |
4447 | } | 4397 | } |
4448 | if (!added && pa->pa_free < tmp_pa->pa_free) { | 4398 | if (!added && pa->pa_free < tmp_pa->pa_free) { |
@@ -4479,7 +4429,7 @@ static int ext4_mb_release_context(struct ext4_allocation_context *ac) | |||
4479 | { | 4429 | { |
4480 | struct ext4_prealloc_space *pa = ac->ac_pa; | 4430 | struct ext4_prealloc_space *pa = ac->ac_pa; |
4481 | if (pa) { | 4431 | if (pa) { |
4482 | if (pa->pa_linear) { | 4432 | if (pa->pa_type == MB_GROUP_PA) { |
4483 | /* see comment in ext4_mb_use_group_pa() */ | 4433 | /* see comment in ext4_mb_use_group_pa() */ |
4484 | spin_lock(&pa->pa_lock); | 4434 | spin_lock(&pa->pa_lock); |
4485 | pa->pa_pstart += ac->ac_b_ex.fe_len; | 4435 | pa->pa_pstart += ac->ac_b_ex.fe_len; |
@@ -4499,7 +4449,7 @@ static int ext4_mb_release_context(struct ext4_allocation_context *ac) | |||
4499 | * doesn't grow big. We need to release | 4449 | * doesn't grow big. We need to release |
4500 | * alloc_semp before calling ext4_mb_add_n_trim() | 4450 | * alloc_semp before calling ext4_mb_add_n_trim() |
4501 | */ | 4451 | */ |
4502 | if (pa->pa_linear && likely(pa->pa_free)) { | 4452 | if ((pa->pa_type == MB_GROUP_PA) && likely(pa->pa_free)) { |
4503 | spin_lock(pa->pa_obj_lock); | 4453 | spin_lock(pa->pa_obj_lock); |
4504 | list_del_rcu(&pa->pa_inode_list); | 4454 | list_del_rcu(&pa->pa_inode_list); |
4505 | spin_unlock(pa->pa_obj_lock); | 4455 | spin_unlock(pa->pa_obj_lock); |
@@ -4936,9 +4886,7 @@ do_more: | |||
4936 | 4886 | ||
4937 | if (sbi->s_log_groups_per_flex) { | 4887 | if (sbi->s_log_groups_per_flex) { |
4938 | ext4_group_t flex_group = ext4_flex_group(sbi, block_group); | 4888 | ext4_group_t flex_group = ext4_flex_group(sbi, block_group); |
4939 | spin_lock(sb_bgl_lock(sbi, flex_group)); | 4889 | atomic_add(count, &sbi->s_flex_groups[flex_group].free_blocks); |
4940 | sbi->s_flex_groups[flex_group].free_blocks += count; | ||
4941 | spin_unlock(sb_bgl_lock(sbi, flex_group)); | ||
4942 | } | 4890 | } |
4943 | 4891 | ||
4944 | ext4_mb_release_desc(&e4b); | 4892 | ext4_mb_release_desc(&e4b); |
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h index 10a2921baf14..dd9e6cd5f6cf 100644 --- a/fs/ext4/mballoc.h +++ b/fs/ext4/mballoc.h | |||
@@ -132,12 +132,15 @@ struct ext4_prealloc_space { | |||
132 | ext4_lblk_t pa_lstart; /* log. block */ | 132 | ext4_lblk_t pa_lstart; /* log. block */ |
133 | unsigned short pa_len; /* len of preallocated chunk */ | 133 | unsigned short pa_len; /* len of preallocated chunk */ |
134 | unsigned short pa_free; /* how many blocks are free */ | 134 | unsigned short pa_free; /* how many blocks are free */ |
135 | unsigned short pa_linear; /* consumed in one direction | 135 | unsigned short pa_type; /* pa type. inode or group */ |
136 | * strictly, for grp prealloc */ | ||
137 | spinlock_t *pa_obj_lock; | 136 | spinlock_t *pa_obj_lock; |
138 | struct inode *pa_inode; /* hack, for history only */ | 137 | struct inode *pa_inode; /* hack, for history only */ |
139 | }; | 138 | }; |
140 | 139 | ||
140 | enum { | ||
141 | MB_INODE_PA = 0, | ||
142 | MB_GROUP_PA = 1 | ||
143 | }; | ||
141 | 144 | ||
142 | struct ext4_free_extent { | 145 | struct ext4_free_extent { |
143 | ext4_lblk_t fe_logical; | 146 | ext4_lblk_t fe_logical; |
@@ -247,7 +250,6 @@ static inline void ext4_mb_store_history(struct ext4_allocation_context *ac) | |||
247 | 250 | ||
248 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) | 251 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) |
249 | 252 | ||
250 | struct buffer_head *read_block_bitmap(struct super_block *, ext4_group_t); | ||
251 | static inline ext4_fsblk_t ext4_grp_offs_to_block(struct super_block *sb, | 253 | static inline ext4_fsblk_t ext4_grp_offs_to_block(struct super_block *sb, |
252 | struct ext4_free_extent *fex) | 254 | struct ext4_free_extent *fex) |
253 | { | 255 | { |
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 83410244d3ee..22098e1cd085 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
@@ -161,12 +161,12 @@ static struct dx_frame *dx_probe(const struct qstr *d_name, | |||
161 | struct dx_frame *frame, | 161 | struct dx_frame *frame, |
162 | int *err); | 162 | int *err); |
163 | static void dx_release(struct dx_frame *frames); | 163 | static void dx_release(struct dx_frame *frames); |
164 | static int dx_make_map(struct ext4_dir_entry_2 *de, int size, | 164 | static int dx_make_map(struct ext4_dir_entry_2 *de, unsigned blocksize, |
165 | struct dx_hash_info *hinfo, struct dx_map_entry map[]); | 165 | struct dx_hash_info *hinfo, struct dx_map_entry map[]); |
166 | static void dx_sort_map(struct dx_map_entry *map, unsigned count); | 166 | static void dx_sort_map(struct dx_map_entry *map, unsigned count); |
167 | static struct ext4_dir_entry_2 *dx_move_dirents(char *from, char *to, | 167 | static struct ext4_dir_entry_2 *dx_move_dirents(char *from, char *to, |
168 | struct dx_map_entry *offsets, int count); | 168 | struct dx_map_entry *offsets, int count, unsigned blocksize); |
169 | static struct ext4_dir_entry_2* dx_pack_dirents(char *base, int size); | 169 | static struct ext4_dir_entry_2* dx_pack_dirents(char *base, unsigned blocksize); |
170 | static void dx_insert_block(struct dx_frame *frame, | 170 | static void dx_insert_block(struct dx_frame *frame, |
171 | u32 hash, ext4_lblk_t block); | 171 | u32 hash, ext4_lblk_t block); |
172 | static int ext4_htree_next_block(struct inode *dir, __u32 hash, | 172 | static int ext4_htree_next_block(struct inode *dir, __u32 hash, |
@@ -180,14 +180,38 @@ static struct buffer_head * ext4_dx_find_entry(struct inode *dir, | |||
180 | static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry, | 180 | static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry, |
181 | struct inode *inode); | 181 | struct inode *inode); |
182 | 182 | ||
183 | unsigned int ext4_rec_len_from_disk(__le16 dlen, unsigned blocksize) | ||
184 | { | ||
185 | unsigned len = le16_to_cpu(dlen); | ||
186 | |||
187 | if (len == EXT4_MAX_REC_LEN || len == 0) | ||
188 | return blocksize; | ||
189 | return (len & 65532) | ((len & 3) << 16); | ||
190 | } | ||
191 | |||
192 | __le16 ext4_rec_len_to_disk(unsigned len, unsigned blocksize) | ||
193 | { | ||
194 | if ((len > blocksize) || (blocksize > (1 << 18)) || (len & 3)) | ||
195 | BUG(); | ||
196 | if (len < 65536) | ||
197 | return cpu_to_le16(len); | ||
198 | if (len == blocksize) { | ||
199 | if (blocksize == 65536) | ||
200 | return cpu_to_le16(EXT4_MAX_REC_LEN); | ||
201 | else | ||
202 | return cpu_to_le16(0); | ||
203 | } | ||
204 | return cpu_to_le16((len & 65532) | ((len >> 16) & 3)); | ||
205 | } | ||
206 | |||
183 | /* | 207 | /* |
184 | * p is at least 6 bytes before the end of page | 208 | * p is at least 6 bytes before the end of page |
185 | */ | 209 | */ |
186 | static inline struct ext4_dir_entry_2 * | 210 | static inline struct ext4_dir_entry_2 * |
187 | ext4_next_entry(struct ext4_dir_entry_2 *p) | 211 | ext4_next_entry(struct ext4_dir_entry_2 *p, unsigned long blocksize) |
188 | { | 212 | { |
189 | return (struct ext4_dir_entry_2 *)((char *)p + | 213 | return (struct ext4_dir_entry_2 *)((char *)p + |
190 | ext4_rec_len_from_disk(p->rec_len)); | 214 | ext4_rec_len_from_disk(p->rec_len, blocksize)); |
191 | } | 215 | } |
192 | 216 | ||
193 | /* | 217 | /* |
@@ -294,7 +318,7 @@ static struct stats dx_show_leaf(struct dx_hash_info *hinfo, struct ext4_dir_ent | |||
294 | space += EXT4_DIR_REC_LEN(de->name_len); | 318 | space += EXT4_DIR_REC_LEN(de->name_len); |
295 | names++; | 319 | names++; |
296 | } | 320 | } |
297 | de = ext4_next_entry(de); | 321 | de = ext4_next_entry(de, size); |
298 | } | 322 | } |
299 | printk("(%i)\n", names); | 323 | printk("(%i)\n", names); |
300 | return (struct stats) { names, space, 1 }; | 324 | return (struct stats) { names, space, 1 }; |
@@ -585,7 +609,7 @@ static int htree_dirblock_to_tree(struct file *dir_file, | |||
585 | top = (struct ext4_dir_entry_2 *) ((char *) de + | 609 | top = (struct ext4_dir_entry_2 *) ((char *) de + |
586 | dir->i_sb->s_blocksize - | 610 | dir->i_sb->s_blocksize - |
587 | EXT4_DIR_REC_LEN(0)); | 611 | EXT4_DIR_REC_LEN(0)); |
588 | for (; de < top; de = ext4_next_entry(de)) { | 612 | for (; de < top; de = ext4_next_entry(de, dir->i_sb->s_blocksize)) { |
589 | if (!ext4_check_dir_entry("htree_dirblock_to_tree", dir, de, bh, | 613 | if (!ext4_check_dir_entry("htree_dirblock_to_tree", dir, de, bh, |
590 | (block<<EXT4_BLOCK_SIZE_BITS(dir->i_sb)) | 614 | (block<<EXT4_BLOCK_SIZE_BITS(dir->i_sb)) |
591 | +((char *)de - bh->b_data))) { | 615 | +((char *)de - bh->b_data))) { |
@@ -663,7 +687,7 @@ int ext4_htree_fill_tree(struct file *dir_file, __u32 start_hash, | |||
663 | } | 687 | } |
664 | if (start_hash < 2 || (start_hash ==2 && start_minor_hash==0)) { | 688 | if (start_hash < 2 || (start_hash ==2 && start_minor_hash==0)) { |
665 | de = (struct ext4_dir_entry_2 *) frames[0].bh->b_data; | 689 | de = (struct ext4_dir_entry_2 *) frames[0].bh->b_data; |
666 | de = ext4_next_entry(de); | 690 | de = ext4_next_entry(de, dir->i_sb->s_blocksize); |
667 | if ((err = ext4_htree_store_dirent(dir_file, 2, 0, de)) != 0) | 691 | if ((err = ext4_htree_store_dirent(dir_file, 2, 0, de)) != 0) |
668 | goto errout; | 692 | goto errout; |
669 | count++; | 693 | count++; |
@@ -713,15 +737,15 @@ errout: | |||
713 | * Create map of hash values, offsets, and sizes, stored at end of block. | 737 | * Create map of hash values, offsets, and sizes, stored at end of block. |
714 | * Returns number of entries mapped. | 738 | * Returns number of entries mapped. |
715 | */ | 739 | */ |
716 | static int dx_make_map (struct ext4_dir_entry_2 *de, int size, | 740 | static int dx_make_map(struct ext4_dir_entry_2 *de, unsigned blocksize, |
717 | struct dx_hash_info *hinfo, struct dx_map_entry *map_tail) | 741 | struct dx_hash_info *hinfo, |
742 | struct dx_map_entry *map_tail) | ||
718 | { | 743 | { |
719 | int count = 0; | 744 | int count = 0; |
720 | char *base = (char *) de; | 745 | char *base = (char *) de; |
721 | struct dx_hash_info h = *hinfo; | 746 | struct dx_hash_info h = *hinfo; |
722 | 747 | ||
723 | while ((char *) de < base + size) | 748 | while ((char *) de < base + blocksize) { |
724 | { | ||
725 | if (de->name_len && de->inode) { | 749 | if (de->name_len && de->inode) { |
726 | ext4fs_dirhash(de->name, de->name_len, &h); | 750 | ext4fs_dirhash(de->name, de->name_len, &h); |
727 | map_tail--; | 751 | map_tail--; |
@@ -732,7 +756,7 @@ static int dx_make_map (struct ext4_dir_entry_2 *de, int size, | |||
732 | cond_resched(); | 756 | cond_resched(); |
733 | } | 757 | } |
734 | /* XXX: do we need to check rec_len == 0 case? -Chris */ | 758 | /* XXX: do we need to check rec_len == 0 case? -Chris */ |
735 | de = ext4_next_entry(de); | 759 | de = ext4_next_entry(de, blocksize); |
736 | } | 760 | } |
737 | return count; | 761 | return count; |
738 | } | 762 | } |
@@ -832,7 +856,8 @@ static inline int search_dirblock(struct buffer_head *bh, | |||
832 | return 1; | 856 | return 1; |
833 | } | 857 | } |
834 | /* prevent looping on a bad block */ | 858 | /* prevent looping on a bad block */ |
835 | de_len = ext4_rec_len_from_disk(de->rec_len); | 859 | de_len = ext4_rec_len_from_disk(de->rec_len, |
860 | dir->i_sb->s_blocksize); | ||
836 | if (de_len <= 0) | 861 | if (de_len <= 0) |
837 | return -1; | 862 | return -1; |
838 | offset += de_len; | 863 | offset += de_len; |
@@ -996,7 +1021,7 @@ static struct buffer_head * ext4_dx_find_entry(struct inode *dir, const struct q | |||
996 | de = (struct ext4_dir_entry_2 *) bh->b_data; | 1021 | de = (struct ext4_dir_entry_2 *) bh->b_data; |
997 | top = (struct ext4_dir_entry_2 *) ((char *) de + sb->s_blocksize - | 1022 | top = (struct ext4_dir_entry_2 *) ((char *) de + sb->s_blocksize - |
998 | EXT4_DIR_REC_LEN(0)); | 1023 | EXT4_DIR_REC_LEN(0)); |
999 | for (; de < top; de = ext4_next_entry(de)) { | 1024 | for (; de < top; de = ext4_next_entry(de, sb->s_blocksize)) { |
1000 | int off = (block << EXT4_BLOCK_SIZE_BITS(sb)) | 1025 | int off = (block << EXT4_BLOCK_SIZE_BITS(sb)) |
1001 | + ((char *) de - bh->b_data); | 1026 | + ((char *) de - bh->b_data); |
1002 | 1027 | ||
@@ -1052,8 +1077,16 @@ static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, stru | |||
1052 | return ERR_PTR(-EIO); | 1077 | return ERR_PTR(-EIO); |
1053 | } | 1078 | } |
1054 | inode = ext4_iget(dir->i_sb, ino); | 1079 | inode = ext4_iget(dir->i_sb, ino); |
1055 | if (IS_ERR(inode)) | 1080 | if (unlikely(IS_ERR(inode))) { |
1056 | return ERR_CAST(inode); | 1081 | if (PTR_ERR(inode) == -ESTALE) { |
1082 | ext4_error(dir->i_sb, __func__, | ||
1083 | "deleted inode referenced: %u", | ||
1084 | ino); | ||
1085 | return ERR_PTR(-EIO); | ||
1086 | } else { | ||
1087 | return ERR_CAST(inode); | ||
1088 | } | ||
1089 | } | ||
1057 | } | 1090 | } |
1058 | return d_splice_alias(inode, dentry); | 1091 | return d_splice_alias(inode, dentry); |
1059 | } | 1092 | } |
@@ -1109,7 +1142,8 @@ static inline void ext4_set_de_type(struct super_block *sb, | |||
1109 | * Returns pointer to last entry moved. | 1142 | * Returns pointer to last entry moved. |
1110 | */ | 1143 | */ |
1111 | static struct ext4_dir_entry_2 * | 1144 | static struct ext4_dir_entry_2 * |
1112 | dx_move_dirents(char *from, char *to, struct dx_map_entry *map, int count) | 1145 | dx_move_dirents(char *from, char *to, struct dx_map_entry *map, int count, |
1146 | unsigned blocksize) | ||
1113 | { | 1147 | { |
1114 | unsigned rec_len = 0; | 1148 | unsigned rec_len = 0; |
1115 | 1149 | ||
@@ -1118,7 +1152,7 @@ dx_move_dirents(char *from, char *to, struct dx_map_entry *map, int count) | |||
1118 | rec_len = EXT4_DIR_REC_LEN(de->name_len); | 1152 | rec_len = EXT4_DIR_REC_LEN(de->name_len); |
1119 | memcpy (to, de, rec_len); | 1153 | memcpy (to, de, rec_len); |
1120 | ((struct ext4_dir_entry_2 *) to)->rec_len = | 1154 | ((struct ext4_dir_entry_2 *) to)->rec_len = |
1121 | ext4_rec_len_to_disk(rec_len); | 1155 | ext4_rec_len_to_disk(rec_len, blocksize); |
1122 | de->inode = 0; | 1156 | de->inode = 0; |
1123 | map++; | 1157 | map++; |
1124 | to += rec_len; | 1158 | to += rec_len; |
@@ -1130,19 +1164,19 @@ dx_move_dirents(char *from, char *to, struct dx_map_entry *map, int count) | |||
1130 | * Compact each dir entry in the range to the minimal rec_len. | 1164 | * Compact each dir entry in the range to the minimal rec_len. |
1131 | * Returns pointer to last entry in range. | 1165 | * Returns pointer to last entry in range. |
1132 | */ | 1166 | */ |
1133 | static struct ext4_dir_entry_2* dx_pack_dirents(char *base, int size) | 1167 | static struct ext4_dir_entry_2* dx_pack_dirents(char *base, unsigned blocksize) |
1134 | { | 1168 | { |
1135 | struct ext4_dir_entry_2 *next, *to, *prev, *de = (struct ext4_dir_entry_2 *) base; | 1169 | struct ext4_dir_entry_2 *next, *to, *prev, *de = (struct ext4_dir_entry_2 *) base; |
1136 | unsigned rec_len = 0; | 1170 | unsigned rec_len = 0; |
1137 | 1171 | ||
1138 | prev = to = de; | 1172 | prev = to = de; |
1139 | while ((char*)de < base + size) { | 1173 | while ((char*)de < base + blocksize) { |
1140 | next = ext4_next_entry(de); | 1174 | next = ext4_next_entry(de, blocksize); |
1141 | if (de->inode && de->name_len) { | 1175 | if (de->inode && de->name_len) { |
1142 | rec_len = EXT4_DIR_REC_LEN(de->name_len); | 1176 | rec_len = EXT4_DIR_REC_LEN(de->name_len); |
1143 | if (de > to) | 1177 | if (de > to) |
1144 | memmove(to, de, rec_len); | 1178 | memmove(to, de, rec_len); |
1145 | to->rec_len = ext4_rec_len_to_disk(rec_len); | 1179 | to->rec_len = ext4_rec_len_to_disk(rec_len, blocksize); |
1146 | prev = to; | 1180 | prev = to; |
1147 | to = (struct ext4_dir_entry_2 *) (((char *) to) + rec_len); | 1181 | to = (struct ext4_dir_entry_2 *) (((char *) to) + rec_len); |
1148 | } | 1182 | } |
@@ -1215,10 +1249,12 @@ static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir, | |||
1215 | hash2, split, count-split)); | 1249 | hash2, split, count-split)); |
1216 | 1250 | ||
1217 | /* Fancy dance to stay within two buffers */ | 1251 | /* Fancy dance to stay within two buffers */ |
1218 | de2 = dx_move_dirents(data1, data2, map + split, count - split); | 1252 | de2 = dx_move_dirents(data1, data2, map + split, count - split, blocksize); |
1219 | de = dx_pack_dirents(data1, blocksize); | 1253 | de = dx_pack_dirents(data1, blocksize); |
1220 | de->rec_len = ext4_rec_len_to_disk(data1 + blocksize - (char *) de); | 1254 | de->rec_len = ext4_rec_len_to_disk(data1 + blocksize - (char *) de, |
1221 | de2->rec_len = ext4_rec_len_to_disk(data2 + blocksize - (char *) de2); | 1255 | blocksize); |
1256 | de2->rec_len = ext4_rec_len_to_disk(data2 + blocksize - (char *) de2, | ||
1257 | blocksize); | ||
1222 | dxtrace(dx_show_leaf (hinfo, (struct ext4_dir_entry_2 *) data1, blocksize, 1)); | 1258 | dxtrace(dx_show_leaf (hinfo, (struct ext4_dir_entry_2 *) data1, blocksize, 1)); |
1223 | dxtrace(dx_show_leaf (hinfo, (struct ext4_dir_entry_2 *) data2, blocksize, 1)); | 1259 | dxtrace(dx_show_leaf (hinfo, (struct ext4_dir_entry_2 *) data2, blocksize, 1)); |
1224 | 1260 | ||
@@ -1268,6 +1304,7 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | |||
1268 | const char *name = dentry->d_name.name; | 1304 | const char *name = dentry->d_name.name; |
1269 | int namelen = dentry->d_name.len; | 1305 | int namelen = dentry->d_name.len; |
1270 | unsigned int offset = 0; | 1306 | unsigned int offset = 0; |
1307 | unsigned int blocksize = dir->i_sb->s_blocksize; | ||
1271 | unsigned short reclen; | 1308 | unsigned short reclen; |
1272 | int nlen, rlen, err; | 1309 | int nlen, rlen, err; |
1273 | char *top; | 1310 | char *top; |
@@ -1275,7 +1312,7 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | |||
1275 | reclen = EXT4_DIR_REC_LEN(namelen); | 1312 | reclen = EXT4_DIR_REC_LEN(namelen); |
1276 | if (!de) { | 1313 | if (!de) { |
1277 | de = (struct ext4_dir_entry_2 *)bh->b_data; | 1314 | de = (struct ext4_dir_entry_2 *)bh->b_data; |
1278 | top = bh->b_data + dir->i_sb->s_blocksize - reclen; | 1315 | top = bh->b_data + blocksize - reclen; |
1279 | while ((char *) de <= top) { | 1316 | while ((char *) de <= top) { |
1280 | if (!ext4_check_dir_entry("ext4_add_entry", dir, de, | 1317 | if (!ext4_check_dir_entry("ext4_add_entry", dir, de, |
1281 | bh, offset)) { | 1318 | bh, offset)) { |
@@ -1287,7 +1324,7 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | |||
1287 | return -EEXIST; | 1324 | return -EEXIST; |
1288 | } | 1325 | } |
1289 | nlen = EXT4_DIR_REC_LEN(de->name_len); | 1326 | nlen = EXT4_DIR_REC_LEN(de->name_len); |
1290 | rlen = ext4_rec_len_from_disk(de->rec_len); | 1327 | rlen = ext4_rec_len_from_disk(de->rec_len, blocksize); |
1291 | if ((de->inode? rlen - nlen: rlen) >= reclen) | 1328 | if ((de->inode? rlen - nlen: rlen) >= reclen) |
1292 | break; | 1329 | break; |
1293 | de = (struct ext4_dir_entry_2 *)((char *)de + rlen); | 1330 | de = (struct ext4_dir_entry_2 *)((char *)de + rlen); |
@@ -1306,11 +1343,11 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry, | |||
1306 | 1343 | ||
1307 | /* By now the buffer is marked for journaling */ | 1344 | /* By now the buffer is marked for journaling */ |
1308 | nlen = EXT4_DIR_REC_LEN(de->name_len); | 1345 | nlen = EXT4_DIR_REC_LEN(de->name_len); |
1309 | rlen = ext4_rec_len_from_disk(de->rec_len); | 1346 | rlen = ext4_rec_len_from_disk(de->rec_len, blocksize); |
1310 | if (de->inode) { | 1347 | if (de->inode) { |
1311 | struct ext4_dir_entry_2 *de1 = (struct ext4_dir_entry_2 *)((char *)de + nlen); | 1348 | struct ext4_dir_entry_2 *de1 = (struct ext4_dir_entry_2 *)((char *)de + nlen); |
1312 | de1->rec_len = ext4_rec_len_to_disk(rlen - nlen); | 1349 | de1->rec_len = ext4_rec_len_to_disk(rlen - nlen, blocksize); |
1313 | de->rec_len = ext4_rec_len_to_disk(nlen); | 1350 | de->rec_len = ext4_rec_len_to_disk(nlen, blocksize); |
1314 | de = de1; | 1351 | de = de1; |
1315 | } | 1352 | } |
1316 | de->file_type = EXT4_FT_UNKNOWN; | 1353 | de->file_type = EXT4_FT_UNKNOWN; |
@@ -1380,7 +1417,7 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, | |||
1380 | /* The 0th block becomes the root, move the dirents out */ | 1417 | /* The 0th block becomes the root, move the dirents out */ |
1381 | fde = &root->dotdot; | 1418 | fde = &root->dotdot; |
1382 | de = (struct ext4_dir_entry_2 *)((char *)fde + | 1419 | de = (struct ext4_dir_entry_2 *)((char *)fde + |
1383 | ext4_rec_len_from_disk(fde->rec_len)); | 1420 | ext4_rec_len_from_disk(fde->rec_len, blocksize)); |
1384 | if ((char *) de >= (((char *) root) + blocksize)) { | 1421 | if ((char *) de >= (((char *) root) + blocksize)) { |
1385 | ext4_error(dir->i_sb, __func__, | 1422 | ext4_error(dir->i_sb, __func__, |
1386 | "invalid rec_len for '..' in inode %lu", | 1423 | "invalid rec_len for '..' in inode %lu", |
@@ -1402,12 +1439,14 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, | |||
1402 | memcpy (data1, de, len); | 1439 | memcpy (data1, de, len); |
1403 | de = (struct ext4_dir_entry_2 *) data1; | 1440 | de = (struct ext4_dir_entry_2 *) data1; |
1404 | top = data1 + len; | 1441 | top = data1 + len; |
1405 | while ((char *)(de2 = ext4_next_entry(de)) < top) | 1442 | while ((char *)(de2 = ext4_next_entry(de, blocksize)) < top) |
1406 | de = de2; | 1443 | de = de2; |
1407 | de->rec_len = ext4_rec_len_to_disk(data1 + blocksize - (char *) de); | 1444 | de->rec_len = ext4_rec_len_to_disk(data1 + blocksize - (char *) de, |
1445 | blocksize); | ||
1408 | /* Initialize the root; the dot dirents already exist */ | 1446 | /* Initialize the root; the dot dirents already exist */ |
1409 | de = (struct ext4_dir_entry_2 *) (&root->dotdot); | 1447 | de = (struct ext4_dir_entry_2 *) (&root->dotdot); |
1410 | de->rec_len = ext4_rec_len_to_disk(blocksize - EXT4_DIR_REC_LEN(2)); | 1448 | de->rec_len = ext4_rec_len_to_disk(blocksize - EXT4_DIR_REC_LEN(2), |
1449 | blocksize); | ||
1411 | memset (&root->info, 0, sizeof(root->info)); | 1450 | memset (&root->info, 0, sizeof(root->info)); |
1412 | root->info.info_length = sizeof(root->info); | 1451 | root->info.info_length = sizeof(root->info); |
1413 | root->info.hash_version = EXT4_SB(dir->i_sb)->s_def_hash_version; | 1452 | root->info.hash_version = EXT4_SB(dir->i_sb)->s_def_hash_version; |
@@ -1488,7 +1527,7 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry, | |||
1488 | return retval; | 1527 | return retval; |
1489 | de = (struct ext4_dir_entry_2 *) bh->b_data; | 1528 | de = (struct ext4_dir_entry_2 *) bh->b_data; |
1490 | de->inode = 0; | 1529 | de->inode = 0; |
1491 | de->rec_len = ext4_rec_len_to_disk(blocksize); | 1530 | de->rec_len = ext4_rec_len_to_disk(blocksize, blocksize); |
1492 | return add_dirent_to_buf(handle, dentry, inode, de, bh); | 1531 | return add_dirent_to_buf(handle, dentry, inode, de, bh); |
1493 | } | 1532 | } |
1494 | 1533 | ||
@@ -1551,7 +1590,8 @@ static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry, | |||
1551 | goto cleanup; | 1590 | goto cleanup; |
1552 | node2 = (struct dx_node *)(bh2->b_data); | 1591 | node2 = (struct dx_node *)(bh2->b_data); |
1553 | entries2 = node2->entries; | 1592 | entries2 = node2->entries; |
1554 | node2->fake.rec_len = ext4_rec_len_to_disk(sb->s_blocksize); | 1593 | node2->fake.rec_len = ext4_rec_len_to_disk(sb->s_blocksize, |
1594 | sb->s_blocksize); | ||
1555 | node2->fake.inode = 0; | 1595 | node2->fake.inode = 0; |
1556 | BUFFER_TRACE(frame->bh, "get_write_access"); | 1596 | BUFFER_TRACE(frame->bh, "get_write_access"); |
1557 | err = ext4_journal_get_write_access(handle, frame->bh); | 1597 | err = ext4_journal_get_write_access(handle, frame->bh); |
@@ -1639,6 +1679,7 @@ static int ext4_delete_entry(handle_t *handle, | |||
1639 | struct buffer_head *bh) | 1679 | struct buffer_head *bh) |
1640 | { | 1680 | { |
1641 | struct ext4_dir_entry_2 *de, *pde; | 1681 | struct ext4_dir_entry_2 *de, *pde; |
1682 | unsigned int blocksize = dir->i_sb->s_blocksize; | ||
1642 | int i; | 1683 | int i; |
1643 | 1684 | ||
1644 | i = 0; | 1685 | i = 0; |
@@ -1652,8 +1693,11 @@ static int ext4_delete_entry(handle_t *handle, | |||
1652 | ext4_journal_get_write_access(handle, bh); | 1693 | ext4_journal_get_write_access(handle, bh); |
1653 | if (pde) | 1694 | if (pde) |
1654 | pde->rec_len = ext4_rec_len_to_disk( | 1695 | pde->rec_len = ext4_rec_len_to_disk( |
1655 | ext4_rec_len_from_disk(pde->rec_len) + | 1696 | ext4_rec_len_from_disk(pde->rec_len, |
1656 | ext4_rec_len_from_disk(de->rec_len)); | 1697 | blocksize) + |
1698 | ext4_rec_len_from_disk(de->rec_len, | ||
1699 | blocksize), | ||
1700 | blocksize); | ||
1657 | else | 1701 | else |
1658 | de->inode = 0; | 1702 | de->inode = 0; |
1659 | dir->i_version++; | 1703 | dir->i_version++; |
@@ -1661,9 +1705,9 @@ static int ext4_delete_entry(handle_t *handle, | |||
1661 | ext4_handle_dirty_metadata(handle, dir, bh); | 1705 | ext4_handle_dirty_metadata(handle, dir, bh); |
1662 | return 0; | 1706 | return 0; |
1663 | } | 1707 | } |
1664 | i += ext4_rec_len_from_disk(de->rec_len); | 1708 | i += ext4_rec_len_from_disk(de->rec_len, blocksize); |
1665 | pde = de; | 1709 | pde = de; |
1666 | de = ext4_next_entry(de); | 1710 | de = ext4_next_entry(de, blocksize); |
1667 | } | 1711 | } |
1668 | return -ENOENT; | 1712 | return -ENOENT; |
1669 | } | 1713 | } |
@@ -1793,6 +1837,7 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
1793 | struct inode *inode; | 1837 | struct inode *inode; |
1794 | struct buffer_head *dir_block; | 1838 | struct buffer_head *dir_block; |
1795 | struct ext4_dir_entry_2 *de; | 1839 | struct ext4_dir_entry_2 *de; |
1840 | unsigned int blocksize = dir->i_sb->s_blocksize; | ||
1796 | int err, retries = 0; | 1841 | int err, retries = 0; |
1797 | 1842 | ||
1798 | if (EXT4_DIR_LINK_MAX(dir)) | 1843 | if (EXT4_DIR_LINK_MAX(dir)) |
@@ -1824,13 +1869,14 @@ retry: | |||
1824 | de = (struct ext4_dir_entry_2 *) dir_block->b_data; | 1869 | de = (struct ext4_dir_entry_2 *) dir_block->b_data; |
1825 | de->inode = cpu_to_le32(inode->i_ino); | 1870 | de->inode = cpu_to_le32(inode->i_ino); |
1826 | de->name_len = 1; | 1871 | de->name_len = 1; |
1827 | de->rec_len = ext4_rec_len_to_disk(EXT4_DIR_REC_LEN(de->name_len)); | 1872 | de->rec_len = ext4_rec_len_to_disk(EXT4_DIR_REC_LEN(de->name_len), |
1873 | blocksize); | ||
1828 | strcpy(de->name, "."); | 1874 | strcpy(de->name, "."); |
1829 | ext4_set_de_type(dir->i_sb, de, S_IFDIR); | 1875 | ext4_set_de_type(dir->i_sb, de, S_IFDIR); |
1830 | de = ext4_next_entry(de); | 1876 | de = ext4_next_entry(de, blocksize); |
1831 | de->inode = cpu_to_le32(dir->i_ino); | 1877 | de->inode = cpu_to_le32(dir->i_ino); |
1832 | de->rec_len = ext4_rec_len_to_disk(inode->i_sb->s_blocksize - | 1878 | de->rec_len = ext4_rec_len_to_disk(blocksize - EXT4_DIR_REC_LEN(1), |
1833 | EXT4_DIR_REC_LEN(1)); | 1879 | blocksize); |
1834 | de->name_len = 2; | 1880 | de->name_len = 2; |
1835 | strcpy(de->name, ".."); | 1881 | strcpy(de->name, ".."); |
1836 | ext4_set_de_type(dir->i_sb, de, S_IFDIR); | 1882 | ext4_set_de_type(dir->i_sb, de, S_IFDIR); |
@@ -1885,7 +1931,7 @@ static int empty_dir(struct inode *inode) | |||
1885 | return 1; | 1931 | return 1; |
1886 | } | 1932 | } |
1887 | de = (struct ext4_dir_entry_2 *) bh->b_data; | 1933 | de = (struct ext4_dir_entry_2 *) bh->b_data; |
1888 | de1 = ext4_next_entry(de); | 1934 | de1 = ext4_next_entry(de, sb->s_blocksize); |
1889 | if (le32_to_cpu(de->inode) != inode->i_ino || | 1935 | if (le32_to_cpu(de->inode) != inode->i_ino || |
1890 | !le32_to_cpu(de1->inode) || | 1936 | !le32_to_cpu(de1->inode) || |
1891 | strcmp(".", de->name) || | 1937 | strcmp(".", de->name) || |
@@ -1896,9 +1942,9 @@ static int empty_dir(struct inode *inode) | |||
1896 | brelse(bh); | 1942 | brelse(bh); |
1897 | return 1; | 1943 | return 1; |
1898 | } | 1944 | } |
1899 | offset = ext4_rec_len_from_disk(de->rec_len) + | 1945 | offset = ext4_rec_len_from_disk(de->rec_len, sb->s_blocksize) + |
1900 | ext4_rec_len_from_disk(de1->rec_len); | 1946 | ext4_rec_len_from_disk(de1->rec_len, sb->s_blocksize); |
1901 | de = ext4_next_entry(de1); | 1947 | de = ext4_next_entry(de1, sb->s_blocksize); |
1902 | while (offset < inode->i_size) { | 1948 | while (offset < inode->i_size) { |
1903 | if (!bh || | 1949 | if (!bh || |
1904 | (void *) de >= (void *) (bh->b_data+sb->s_blocksize)) { | 1950 | (void *) de >= (void *) (bh->b_data+sb->s_blocksize)) { |
@@ -1927,8 +1973,8 @@ static int empty_dir(struct inode *inode) | |||
1927 | brelse(bh); | 1973 | brelse(bh); |
1928 | return 0; | 1974 | return 0; |
1929 | } | 1975 | } |
1930 | offset += ext4_rec_len_from_disk(de->rec_len); | 1976 | offset += ext4_rec_len_from_disk(de->rec_len, sb->s_blocksize); |
1931 | de = ext4_next_entry(de); | 1977 | de = ext4_next_entry(de, sb->s_blocksize); |
1932 | } | 1978 | } |
1933 | brelse(bh); | 1979 | brelse(bh); |
1934 | return 1; | 1980 | return 1; |
@@ -2297,8 +2343,8 @@ retry: | |||
2297 | return err; | 2343 | return err; |
2298 | } | 2344 | } |
2299 | 2345 | ||
2300 | #define PARENT_INO(buffer) \ | 2346 | #define PARENT_INO(buffer, size) \ |
2301 | (ext4_next_entry((struct ext4_dir_entry_2 *)(buffer))->inode) | 2347 | (ext4_next_entry((struct ext4_dir_entry_2 *)(buffer), size)->inode) |
2302 | 2348 | ||
2303 | /* | 2349 | /* |
2304 | * Anybody can rename anything with this: the permission checks are left to the | 2350 | * Anybody can rename anything with this: the permission checks are left to the |
@@ -2311,7 +2357,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2311 | struct inode *old_inode, *new_inode; | 2357 | struct inode *old_inode, *new_inode; |
2312 | struct buffer_head *old_bh, *new_bh, *dir_bh; | 2358 | struct buffer_head *old_bh, *new_bh, *dir_bh; |
2313 | struct ext4_dir_entry_2 *old_de, *new_de; | 2359 | struct ext4_dir_entry_2 *old_de, *new_de; |
2314 | int retval; | 2360 | int retval, force_da_alloc = 0; |
2315 | 2361 | ||
2316 | old_bh = new_bh = dir_bh = NULL; | 2362 | old_bh = new_bh = dir_bh = NULL; |
2317 | 2363 | ||
@@ -2358,7 +2404,8 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2358 | dir_bh = ext4_bread(handle, old_inode, 0, 0, &retval); | 2404 | dir_bh = ext4_bread(handle, old_inode, 0, 0, &retval); |
2359 | if (!dir_bh) | 2405 | if (!dir_bh) |
2360 | goto end_rename; | 2406 | goto end_rename; |
2361 | if (le32_to_cpu(PARENT_INO(dir_bh->b_data)) != old_dir->i_ino) | 2407 | if (le32_to_cpu(PARENT_INO(dir_bh->b_data, |
2408 | old_dir->i_sb->s_blocksize)) != old_dir->i_ino) | ||
2362 | goto end_rename; | 2409 | goto end_rename; |
2363 | retval = -EMLINK; | 2410 | retval = -EMLINK; |
2364 | if (!new_inode && new_dir != old_dir && | 2411 | if (!new_inode && new_dir != old_dir && |
@@ -2430,7 +2477,8 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2430 | if (dir_bh) { | 2477 | if (dir_bh) { |
2431 | BUFFER_TRACE(dir_bh, "get_write_access"); | 2478 | BUFFER_TRACE(dir_bh, "get_write_access"); |
2432 | ext4_journal_get_write_access(handle, dir_bh); | 2479 | ext4_journal_get_write_access(handle, dir_bh); |
2433 | PARENT_INO(dir_bh->b_data) = cpu_to_le32(new_dir->i_ino); | 2480 | PARENT_INO(dir_bh->b_data, new_dir->i_sb->s_blocksize) = |
2481 | cpu_to_le32(new_dir->i_ino); | ||
2434 | BUFFER_TRACE(dir_bh, "call ext4_handle_dirty_metadata"); | 2482 | BUFFER_TRACE(dir_bh, "call ext4_handle_dirty_metadata"); |
2435 | ext4_handle_dirty_metadata(handle, old_dir, dir_bh); | 2483 | ext4_handle_dirty_metadata(handle, old_dir, dir_bh); |
2436 | ext4_dec_count(handle, old_dir); | 2484 | ext4_dec_count(handle, old_dir); |
@@ -2449,6 +2497,8 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2449 | ext4_mark_inode_dirty(handle, new_inode); | 2497 | ext4_mark_inode_dirty(handle, new_inode); |
2450 | if (!new_inode->i_nlink) | 2498 | if (!new_inode->i_nlink) |
2451 | ext4_orphan_add(handle, new_inode); | 2499 | ext4_orphan_add(handle, new_inode); |
2500 | if (!test_opt(new_dir->i_sb, NO_AUTO_DA_ALLOC)) | ||
2501 | force_da_alloc = 1; | ||
2452 | } | 2502 | } |
2453 | retval = 0; | 2503 | retval = 0; |
2454 | 2504 | ||
@@ -2457,6 +2507,8 @@ end_rename: | |||
2457 | brelse(old_bh); | 2507 | brelse(old_bh); |
2458 | brelse(new_bh); | 2508 | brelse(new_bh); |
2459 | ext4_journal_stop(handle); | 2509 | ext4_journal_stop(handle); |
2510 | if (retval == 0 && force_da_alloc) | ||
2511 | ext4_alloc_da_blocks(old_inode); | ||
2460 | return retval; | 2512 | return retval; |
2461 | } | 2513 | } |
2462 | 2514 | ||
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index c06886abd658..546c7dd869e1 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c | |||
@@ -938,10 +938,10 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input) | |||
938 | if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG)) { | 938 | if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG)) { |
939 | ext4_group_t flex_group; | 939 | ext4_group_t flex_group; |
940 | flex_group = ext4_flex_group(sbi, input->group); | 940 | flex_group = ext4_flex_group(sbi, input->group); |
941 | sbi->s_flex_groups[flex_group].free_blocks += | 941 | atomic_add(input->free_blocks_count, |
942 | input->free_blocks_count; | 942 | &sbi->s_flex_groups[flex_group].free_blocks); |
943 | sbi->s_flex_groups[flex_group].free_inodes += | 943 | atomic_add(EXT4_INODES_PER_GROUP(sb), |
944 | EXT4_INODES_PER_GROUP(sb); | 944 | &sbi->s_flex_groups[flex_group].free_inodes); |
945 | } | 945 | } |
946 | 946 | ||
947 | ext4_handle_dirty_metadata(handle, NULL, sbi->s_sbh); | 947 | ext4_handle_dirty_metadata(handle, NULL, sbi->s_sbh); |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index f7371a6a923d..9987bba99db3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
@@ -35,6 +35,7 @@ | |||
35 | #include <linux/quotaops.h> | 35 | #include <linux/quotaops.h> |
36 | #include <linux/seq_file.h> | 36 | #include <linux/seq_file.h> |
37 | #include <linux/proc_fs.h> | 37 | #include <linux/proc_fs.h> |
38 | #include <linux/ctype.h> | ||
38 | #include <linux/marker.h> | 39 | #include <linux/marker.h> |
39 | #include <linux/log2.h> | 40 | #include <linux/log2.h> |
40 | #include <linux/crc16.h> | 41 | #include <linux/crc16.h> |
@@ -48,6 +49,7 @@ | |||
48 | #include "group.h" | 49 | #include "group.h" |
49 | 50 | ||
50 | struct proc_dir_entry *ext4_proc_root; | 51 | struct proc_dir_entry *ext4_proc_root; |
52 | static struct kset *ext4_kset; | ||
51 | 53 | ||
52 | static int ext4_load_journal(struct super_block *, struct ext4_super_block *, | 54 | static int ext4_load_journal(struct super_block *, struct ext4_super_block *, |
53 | unsigned long journal_devnum); | 55 | unsigned long journal_devnum); |
@@ -577,9 +579,9 @@ static void ext4_put_super(struct super_block *sb) | |||
577 | ext4_commit_super(sb, es, 1); | 579 | ext4_commit_super(sb, es, 1); |
578 | } | 580 | } |
579 | if (sbi->s_proc) { | 581 | if (sbi->s_proc) { |
580 | remove_proc_entry("inode_readahead_blks", sbi->s_proc); | ||
581 | remove_proc_entry(sb->s_id, ext4_proc_root); | 582 | remove_proc_entry(sb->s_id, ext4_proc_root); |
582 | } | 583 | } |
584 | kobject_del(&sbi->s_kobj); | ||
583 | 585 | ||
584 | for (i = 0; i < sbi->s_gdb_count; i++) | 586 | for (i = 0; i < sbi->s_gdb_count; i++) |
585 | brelse(sbi->s_group_desc[i]); | 587 | brelse(sbi->s_group_desc[i]); |
@@ -615,6 +617,17 @@ static void ext4_put_super(struct super_block *sb) | |||
615 | ext4_blkdev_remove(sbi); | 617 | ext4_blkdev_remove(sbi); |
616 | } | 618 | } |
617 | sb->s_fs_info = NULL; | 619 | sb->s_fs_info = NULL; |
620 | /* | ||
621 | * Now that we are completely done shutting down the | ||
622 | * superblock, we need to actually destroy the kobject. | ||
623 | */ | ||
624 | unlock_kernel(); | ||
625 | unlock_super(sb); | ||
626 | kobject_put(&sbi->s_kobj); | ||
627 | wait_for_completion(&sbi->s_kobj_unregister); | ||
628 | lock_super(sb); | ||
629 | lock_kernel(); | ||
630 | kfree(sbi->s_blockgroup_lock); | ||
618 | kfree(sbi); | 631 | kfree(sbi); |
619 | return; | 632 | return; |
620 | } | 633 | } |
@@ -803,8 +816,6 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
803 | if (!test_opt(sb, POSIX_ACL) && (def_mount_opts & EXT4_DEFM_ACL)) | 816 | if (!test_opt(sb, POSIX_ACL) && (def_mount_opts & EXT4_DEFM_ACL)) |
804 | seq_puts(seq, ",noacl"); | 817 | seq_puts(seq, ",noacl"); |
805 | #endif | 818 | #endif |
806 | if (!test_opt(sb, RESERVATION)) | ||
807 | seq_puts(seq, ",noreservation"); | ||
808 | if (sbi->s_commit_interval != JBD2_DEFAULT_MAX_COMMIT_AGE*HZ) { | 819 | if (sbi->s_commit_interval != JBD2_DEFAULT_MAX_COMMIT_AGE*HZ) { |
809 | seq_printf(seq, ",commit=%u", | 820 | seq_printf(seq, ",commit=%u", |
810 | (unsigned) (sbi->s_commit_interval / HZ)); | 821 | (unsigned) (sbi->s_commit_interval / HZ)); |
@@ -855,6 +866,9 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
855 | if (test_opt(sb, DATA_ERR_ABORT)) | 866 | if (test_opt(sb, DATA_ERR_ABORT)) |
856 | seq_puts(seq, ",data_err=abort"); | 867 | seq_puts(seq, ",data_err=abort"); |
857 | 868 | ||
869 | if (test_opt(sb, NO_AUTO_DA_ALLOC)) | ||
870 | seq_puts(seq, ",noauto_da_alloc"); | ||
871 | |||
858 | ext4_show_quota_options(seq, sb); | 872 | ext4_show_quota_options(seq, sb); |
859 | return 0; | 873 | return 0; |
860 | } | 874 | } |
@@ -1004,7 +1018,7 @@ enum { | |||
1004 | Opt_resgid, Opt_resuid, Opt_sb, Opt_err_cont, Opt_err_panic, Opt_err_ro, | 1018 | Opt_resgid, Opt_resuid, Opt_sb, Opt_err_cont, Opt_err_panic, Opt_err_ro, |
1005 | Opt_nouid32, Opt_debug, Opt_oldalloc, Opt_orlov, | 1019 | Opt_nouid32, Opt_debug, Opt_oldalloc, Opt_orlov, |
1006 | Opt_user_xattr, Opt_nouser_xattr, Opt_acl, Opt_noacl, | 1020 | Opt_user_xattr, Opt_nouser_xattr, Opt_acl, Opt_noacl, |
1007 | Opt_reservation, Opt_noreservation, Opt_noload, Opt_nobh, Opt_bh, | 1021 | Opt_auto_da_alloc, Opt_noauto_da_alloc, Opt_noload, Opt_nobh, Opt_bh, |
1008 | Opt_commit, Opt_min_batch_time, Opt_max_batch_time, | 1022 | Opt_commit, Opt_min_batch_time, Opt_max_batch_time, |
1009 | Opt_journal_update, Opt_journal_dev, | 1023 | Opt_journal_update, Opt_journal_dev, |
1010 | Opt_journal_checksum, Opt_journal_async_commit, | 1024 | Opt_journal_checksum, Opt_journal_async_commit, |
@@ -1012,8 +1026,8 @@ enum { | |||
1012 | Opt_data_err_abort, Opt_data_err_ignore, | 1026 | Opt_data_err_abort, Opt_data_err_ignore, |
1013 | Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota, | 1027 | Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota, |
1014 | Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_quota, Opt_noquota, | 1028 | Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_quota, Opt_noquota, |
1015 | Opt_ignore, Opt_barrier, Opt_err, Opt_resize, Opt_usrquota, | 1029 | Opt_ignore, Opt_barrier, Opt_nobarrier, Opt_err, Opt_resize, |
1016 | Opt_grpquota, Opt_i_version, | 1030 | Opt_usrquota, Opt_grpquota, Opt_i_version, |
1017 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, | 1031 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, |
1018 | Opt_inode_readahead_blks, Opt_journal_ioprio | 1032 | Opt_inode_readahead_blks, Opt_journal_ioprio |
1019 | }; | 1033 | }; |
@@ -1039,8 +1053,6 @@ static const match_table_t tokens = { | |||
1039 | {Opt_nouser_xattr, "nouser_xattr"}, | 1053 | {Opt_nouser_xattr, "nouser_xattr"}, |
1040 | {Opt_acl, "acl"}, | 1054 | {Opt_acl, "acl"}, |
1041 | {Opt_noacl, "noacl"}, | 1055 | {Opt_noacl, "noacl"}, |
1042 | {Opt_reservation, "reservation"}, | ||
1043 | {Opt_noreservation, "noreservation"}, | ||
1044 | {Opt_noload, "noload"}, | 1056 | {Opt_noload, "noload"}, |
1045 | {Opt_nobh, "nobh"}, | 1057 | {Opt_nobh, "nobh"}, |
1046 | {Opt_bh, "bh"}, | 1058 | {Opt_bh, "bh"}, |
@@ -1068,6 +1080,8 @@ static const match_table_t tokens = { | |||
1068 | {Opt_quota, "quota"}, | 1080 | {Opt_quota, "quota"}, |
1069 | {Opt_usrquota, "usrquota"}, | 1081 | {Opt_usrquota, "usrquota"}, |
1070 | {Opt_barrier, "barrier=%u"}, | 1082 | {Opt_barrier, "barrier=%u"}, |
1083 | {Opt_barrier, "barrier"}, | ||
1084 | {Opt_nobarrier, "nobarrier"}, | ||
1071 | {Opt_i_version, "i_version"}, | 1085 | {Opt_i_version, "i_version"}, |
1072 | {Opt_stripe, "stripe=%u"}, | 1086 | {Opt_stripe, "stripe=%u"}, |
1073 | {Opt_resize, "resize"}, | 1087 | {Opt_resize, "resize"}, |
@@ -1075,6 +1089,9 @@ static const match_table_t tokens = { | |||
1075 | {Opt_nodelalloc, "nodelalloc"}, | 1089 | {Opt_nodelalloc, "nodelalloc"}, |
1076 | {Opt_inode_readahead_blks, "inode_readahead_blks=%u"}, | 1090 | {Opt_inode_readahead_blks, "inode_readahead_blks=%u"}, |
1077 | {Opt_journal_ioprio, "journal_ioprio=%u"}, | 1091 | {Opt_journal_ioprio, "journal_ioprio=%u"}, |
1092 | {Opt_auto_da_alloc, "auto_da_alloc=%u"}, | ||
1093 | {Opt_auto_da_alloc, "auto_da_alloc"}, | ||
1094 | {Opt_noauto_da_alloc, "noauto_da_alloc"}, | ||
1078 | {Opt_err, NULL}, | 1095 | {Opt_err, NULL}, |
1079 | }; | 1096 | }; |
1080 | 1097 | ||
@@ -1207,12 +1224,6 @@ static int parse_options(char *options, struct super_block *sb, | |||
1207 | "not supported\n"); | 1224 | "not supported\n"); |
1208 | break; | 1225 | break; |
1209 | #endif | 1226 | #endif |
1210 | case Opt_reservation: | ||
1211 | set_opt(sbi->s_mount_opt, RESERVATION); | ||
1212 | break; | ||
1213 | case Opt_noreservation: | ||
1214 | clear_opt(sbi->s_mount_opt, RESERVATION); | ||
1215 | break; | ||
1216 | case Opt_journal_update: | 1227 | case Opt_journal_update: |
1217 | /* @@@ FIXME */ | 1228 | /* @@@ FIXME */ |
1218 | /* Eventually we will want to be able to create | 1229 | /* Eventually we will want to be able to create |
@@ -1415,9 +1426,14 @@ set_qf_format: | |||
1415 | case Opt_abort: | 1426 | case Opt_abort: |
1416 | set_opt(sbi->s_mount_opt, ABORT); | 1427 | set_opt(sbi->s_mount_opt, ABORT); |
1417 | break; | 1428 | break; |
1429 | case Opt_nobarrier: | ||
1430 | clear_opt(sbi->s_mount_opt, BARRIER); | ||
1431 | break; | ||
1418 | case Opt_barrier: | 1432 | case Opt_barrier: |
1419 | if (match_int(&args[0], &option)) | 1433 | if (match_int(&args[0], &option)) { |
1420 | return 0; | 1434 | set_opt(sbi->s_mount_opt, BARRIER); |
1435 | break; | ||
1436 | } | ||
1421 | if (option) | 1437 | if (option) |
1422 | set_opt(sbi->s_mount_opt, BARRIER); | 1438 | set_opt(sbi->s_mount_opt, BARRIER); |
1423 | else | 1439 | else |
@@ -1463,6 +1479,11 @@ set_qf_format: | |||
1463 | return 0; | 1479 | return 0; |
1464 | if (option < 0 || option > (1 << 30)) | 1480 | if (option < 0 || option > (1 << 30)) |
1465 | return 0; | 1481 | return 0; |
1482 | if (option & (option - 1)) { | ||
1483 | printk(KERN_ERR "EXT4-fs: inode_readahead_blks" | ||
1484 | " must be a power of 2\n"); | ||
1485 | return 0; | ||
1486 | } | ||
1466 | sbi->s_inode_readahead_blks = option; | 1487 | sbi->s_inode_readahead_blks = option; |
1467 | break; | 1488 | break; |
1468 | case Opt_journal_ioprio: | 1489 | case Opt_journal_ioprio: |
@@ -1473,6 +1494,19 @@ set_qf_format: | |||
1473 | *journal_ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, | 1494 | *journal_ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, |
1474 | option); | 1495 | option); |
1475 | break; | 1496 | break; |
1497 | case Opt_noauto_da_alloc: | ||
1498 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); | ||
1499 | break; | ||
1500 | case Opt_auto_da_alloc: | ||
1501 | if (match_int(&args[0], &option)) { | ||
1502 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); | ||
1503 | break; | ||
1504 | } | ||
1505 | if (option) | ||
1506 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); | ||
1507 | else | ||
1508 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); | ||
1509 | break; | ||
1476 | default: | 1510 | default: |
1477 | printk(KERN_ERR | 1511 | printk(KERN_ERR |
1478 | "EXT4-fs: Unrecognized mount option \"%s\" " | 1512 | "EXT4-fs: Unrecognized mount option \"%s\" " |
@@ -1612,10 +1646,12 @@ static int ext4_fill_flex_info(struct super_block *sb) | |||
1612 | gdp = ext4_get_group_desc(sb, i, &bh); | 1646 | gdp = ext4_get_group_desc(sb, i, &bh); |
1613 | 1647 | ||
1614 | flex_group = ext4_flex_group(sbi, i); | 1648 | flex_group = ext4_flex_group(sbi, i); |
1615 | sbi->s_flex_groups[flex_group].free_inodes += | 1649 | atomic_set(&sbi->s_flex_groups[flex_group].free_inodes, |
1616 | ext4_free_inodes_count(sb, gdp); | 1650 | ext4_free_inodes_count(sb, gdp)); |
1617 | sbi->s_flex_groups[flex_group].free_blocks += | 1651 | atomic_set(&sbi->s_flex_groups[flex_group].free_blocks, |
1618 | ext4_free_blks_count(sb, gdp); | 1652 | ext4_free_blks_count(sb, gdp)); |
1653 | atomic_set(&sbi->s_flex_groups[flex_group].used_dirs, | ||
1654 | ext4_used_dirs_count(sb, gdp)); | ||
1619 | } | 1655 | } |
1620 | 1656 | ||
1621 | return 1; | 1657 | return 1; |
@@ -1991,6 +2027,181 @@ static unsigned long ext4_get_stripe_size(struct ext4_sb_info *sbi) | |||
1991 | return 0; | 2027 | return 0; |
1992 | } | 2028 | } |
1993 | 2029 | ||
2030 | /* sysfs supprt */ | ||
2031 | |||
2032 | struct ext4_attr { | ||
2033 | struct attribute attr; | ||
2034 | ssize_t (*show)(struct ext4_attr *, struct ext4_sb_info *, char *); | ||
2035 | ssize_t (*store)(struct ext4_attr *, struct ext4_sb_info *, | ||
2036 | const char *, size_t); | ||
2037 | int offset; | ||
2038 | }; | ||
2039 | |||
2040 | static int parse_strtoul(const char *buf, | ||
2041 | unsigned long max, unsigned long *value) | ||
2042 | { | ||
2043 | char *endp; | ||
2044 | |||
2045 | while (*buf && isspace(*buf)) | ||
2046 | buf++; | ||
2047 | *value = simple_strtoul(buf, &endp, 0); | ||
2048 | while (*endp && isspace(*endp)) | ||
2049 | endp++; | ||
2050 | if (*endp || *value > max) | ||
2051 | return -EINVAL; | ||
2052 | |||
2053 | return 0; | ||
2054 | } | ||
2055 | |||
2056 | static ssize_t delayed_allocation_blocks_show(struct ext4_attr *a, | ||
2057 | struct ext4_sb_info *sbi, | ||
2058 | char *buf) | ||
2059 | { | ||
2060 | return snprintf(buf, PAGE_SIZE, "%llu\n", | ||
2061 | (s64) percpu_counter_sum(&sbi->s_dirtyblocks_counter)); | ||
2062 | } | ||
2063 | |||
2064 | static ssize_t session_write_kbytes_show(struct ext4_attr *a, | ||
2065 | struct ext4_sb_info *sbi, char *buf) | ||
2066 | { | ||
2067 | struct super_block *sb = sbi->s_buddy_cache->i_sb; | ||
2068 | |||
2069 | return snprintf(buf, PAGE_SIZE, "%lu\n", | ||
2070 | (part_stat_read(sb->s_bdev->bd_part, sectors[1]) - | ||
2071 | sbi->s_sectors_written_start) >> 1); | ||
2072 | } | ||
2073 | |||
2074 | static ssize_t lifetime_write_kbytes_show(struct ext4_attr *a, | ||
2075 | struct ext4_sb_info *sbi, char *buf) | ||
2076 | { | ||
2077 | struct super_block *sb = sbi->s_buddy_cache->i_sb; | ||
2078 | |||
2079 | return snprintf(buf, PAGE_SIZE, "%llu\n", | ||
2080 | sbi->s_kbytes_written + | ||
2081 | ((part_stat_read(sb->s_bdev->bd_part, sectors[1]) - | ||
2082 | EXT4_SB(sb)->s_sectors_written_start) >> 1)); | ||
2083 | } | ||
2084 | |||
2085 | static ssize_t inode_readahead_blks_store(struct ext4_attr *a, | ||
2086 | struct ext4_sb_info *sbi, | ||
2087 | const char *buf, size_t count) | ||
2088 | { | ||
2089 | unsigned long t; | ||
2090 | |||
2091 | if (parse_strtoul(buf, 0x40000000, &t)) | ||
2092 | return -EINVAL; | ||
2093 | |||
2094 | /* inode_readahead_blks must be a power of 2 */ | ||
2095 | if (t & (t-1)) | ||
2096 | return -EINVAL; | ||
2097 | |||
2098 | sbi->s_inode_readahead_blks = t; | ||
2099 | return count; | ||
2100 | } | ||
2101 | |||
2102 | static ssize_t sbi_ui_show(struct ext4_attr *a, | ||
2103 | struct ext4_sb_info *sbi, char *buf) | ||
2104 | { | ||
2105 | unsigned int *ui = (unsigned int *) (((char *) sbi) + a->offset); | ||
2106 | |||
2107 | return snprintf(buf, PAGE_SIZE, "%u\n", *ui); | ||
2108 | } | ||
2109 | |||
2110 | static ssize_t sbi_ui_store(struct ext4_attr *a, | ||
2111 | struct ext4_sb_info *sbi, | ||
2112 | const char *buf, size_t count) | ||
2113 | { | ||
2114 | unsigned int *ui = (unsigned int *) (((char *) sbi) + a->offset); | ||
2115 | unsigned long t; | ||
2116 | |||
2117 | if (parse_strtoul(buf, 0xffffffff, &t)) | ||
2118 | return -EINVAL; | ||
2119 | *ui = t; | ||
2120 | return count; | ||
2121 | } | ||
2122 | |||
2123 | #define EXT4_ATTR_OFFSET(_name,_mode,_show,_store,_elname) \ | ||
2124 | static struct ext4_attr ext4_attr_##_name = { \ | ||
2125 | .attr = {.name = __stringify(_name), .mode = _mode }, \ | ||
2126 | .show = _show, \ | ||
2127 | .store = _store, \ | ||
2128 | .offset = offsetof(struct ext4_sb_info, _elname), \ | ||
2129 | } | ||
2130 | #define EXT4_ATTR(name, mode, show, store) \ | ||
2131 | static struct ext4_attr ext4_attr_##name = __ATTR(name, mode, show, store) | ||
2132 | |||
2133 | #define EXT4_RO_ATTR(name) EXT4_ATTR(name, 0444, name##_show, NULL) | ||
2134 | #define EXT4_RW_ATTR(name) EXT4_ATTR(name, 0644, name##_show, name##_store) | ||
2135 | #define EXT4_RW_ATTR_SBI_UI(name, elname) \ | ||
2136 | EXT4_ATTR_OFFSET(name, 0644, sbi_ui_show, sbi_ui_store, elname) | ||
2137 | #define ATTR_LIST(name) &ext4_attr_##name.attr | ||
2138 | |||
2139 | EXT4_RO_ATTR(delayed_allocation_blocks); | ||
2140 | EXT4_RO_ATTR(session_write_kbytes); | ||
2141 | EXT4_RO_ATTR(lifetime_write_kbytes); | ||
2142 | EXT4_ATTR_OFFSET(inode_readahead_blks, 0644, sbi_ui_show, | ||
2143 | inode_readahead_blks_store, s_inode_readahead_blks); | ||
2144 | EXT4_RW_ATTR_SBI_UI(mb_stats, s_mb_stats); | ||
2145 | EXT4_RW_ATTR_SBI_UI(mb_max_to_scan, s_mb_max_to_scan); | ||
2146 | EXT4_RW_ATTR_SBI_UI(mb_min_to_scan, s_mb_min_to_scan); | ||
2147 | EXT4_RW_ATTR_SBI_UI(mb_order2_req, s_mb_order2_reqs); | ||
2148 | EXT4_RW_ATTR_SBI_UI(mb_stream_req, s_mb_stream_request); | ||
2149 | EXT4_RW_ATTR_SBI_UI(mb_group_prealloc, s_mb_group_prealloc); | ||
2150 | |||
2151 | static struct attribute *ext4_attrs[] = { | ||
2152 | ATTR_LIST(delayed_allocation_blocks), | ||
2153 | ATTR_LIST(session_write_kbytes), | ||
2154 | ATTR_LIST(lifetime_write_kbytes), | ||
2155 | ATTR_LIST(inode_readahead_blks), | ||
2156 | ATTR_LIST(mb_stats), | ||
2157 | ATTR_LIST(mb_max_to_scan), | ||
2158 | ATTR_LIST(mb_min_to_scan), | ||
2159 | ATTR_LIST(mb_order2_req), | ||
2160 | ATTR_LIST(mb_stream_req), | ||
2161 | ATTR_LIST(mb_group_prealloc), | ||
2162 | NULL, | ||
2163 | }; | ||
2164 | |||
2165 | static ssize_t ext4_attr_show(struct kobject *kobj, | ||
2166 | struct attribute *attr, char *buf) | ||
2167 | { | ||
2168 | struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info, | ||
2169 | s_kobj); | ||
2170 | struct ext4_attr *a = container_of(attr, struct ext4_attr, attr); | ||
2171 | |||
2172 | return a->show ? a->show(a, sbi, buf) : 0; | ||
2173 | } | ||
2174 | |||
2175 | static ssize_t ext4_attr_store(struct kobject *kobj, | ||
2176 | struct attribute *attr, | ||
2177 | const char *buf, size_t len) | ||
2178 | { | ||
2179 | struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info, | ||
2180 | s_kobj); | ||
2181 | struct ext4_attr *a = container_of(attr, struct ext4_attr, attr); | ||
2182 | |||
2183 | return a->store ? a->store(a, sbi, buf, len) : 0; | ||
2184 | } | ||
2185 | |||
2186 | static void ext4_sb_release(struct kobject *kobj) | ||
2187 | { | ||
2188 | struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info, | ||
2189 | s_kobj); | ||
2190 | complete(&sbi->s_kobj_unregister); | ||
2191 | } | ||
2192 | |||
2193 | |||
2194 | static struct sysfs_ops ext4_attr_ops = { | ||
2195 | .show = ext4_attr_show, | ||
2196 | .store = ext4_attr_store, | ||
2197 | }; | ||
2198 | |||
2199 | static struct kobj_type ext4_ktype = { | ||
2200 | .default_attrs = ext4_attrs, | ||
2201 | .sysfs_ops = &ext4_attr_ops, | ||
2202 | .release = ext4_sb_release, | ||
2203 | }; | ||
2204 | |||
1994 | static int ext4_fill_super(struct super_block *sb, void *data, int silent) | 2205 | static int ext4_fill_super(struct super_block *sb, void *data, int silent) |
1995 | __releases(kernel_lock) | 2206 | __releases(kernel_lock) |
1996 | __acquires(kernel_lock) | 2207 | __acquires(kernel_lock) |
@@ -2021,12 +2232,21 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2021 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); | 2232 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); |
2022 | if (!sbi) | 2233 | if (!sbi) |
2023 | return -ENOMEM; | 2234 | return -ENOMEM; |
2235 | |||
2236 | sbi->s_blockgroup_lock = | ||
2237 | kzalloc(sizeof(struct blockgroup_lock), GFP_KERNEL); | ||
2238 | if (!sbi->s_blockgroup_lock) { | ||
2239 | kfree(sbi); | ||
2240 | return -ENOMEM; | ||
2241 | } | ||
2024 | sb->s_fs_info = sbi; | 2242 | sb->s_fs_info = sbi; |
2025 | sbi->s_mount_opt = 0; | 2243 | sbi->s_mount_opt = 0; |
2026 | sbi->s_resuid = EXT4_DEF_RESUID; | 2244 | sbi->s_resuid = EXT4_DEF_RESUID; |
2027 | sbi->s_resgid = EXT4_DEF_RESGID; | 2245 | sbi->s_resgid = EXT4_DEF_RESGID; |
2028 | sbi->s_inode_readahead_blks = EXT4_DEF_INODE_READAHEAD_BLKS; | 2246 | sbi->s_inode_readahead_blks = EXT4_DEF_INODE_READAHEAD_BLKS; |
2029 | sbi->s_sb_block = sb_block; | 2247 | sbi->s_sb_block = sb_block; |
2248 | sbi->s_sectors_written_start = part_stat_read(sb->s_bdev->bd_part, | ||
2249 | sectors[1]); | ||
2030 | 2250 | ||
2031 | unlock_kernel(); | 2251 | unlock_kernel(); |
2032 | 2252 | ||
@@ -2064,6 +2284,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2064 | sb->s_magic = le16_to_cpu(es->s_magic); | 2284 | sb->s_magic = le16_to_cpu(es->s_magic); |
2065 | if (sb->s_magic != EXT4_SUPER_MAGIC) | 2285 | if (sb->s_magic != EXT4_SUPER_MAGIC) |
2066 | goto cantfind_ext4; | 2286 | goto cantfind_ext4; |
2287 | sbi->s_kbytes_written = le64_to_cpu(es->s_kbytes_written); | ||
2067 | 2288 | ||
2068 | /* Set defaults before we parse the mount options */ | 2289 | /* Set defaults before we parse the mount options */ |
2069 | def_mount_opts = le32_to_cpu(es->s_default_mount_opts); | 2290 | def_mount_opts = le32_to_cpu(es->s_default_mount_opts); |
@@ -2101,7 +2322,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2101 | sbi->s_min_batch_time = EXT4_DEF_MIN_BATCH_TIME; | 2322 | sbi->s_min_batch_time = EXT4_DEF_MIN_BATCH_TIME; |
2102 | sbi->s_max_batch_time = EXT4_DEF_MAX_BATCH_TIME; | 2323 | sbi->s_max_batch_time = EXT4_DEF_MAX_BATCH_TIME; |
2103 | 2324 | ||
2104 | set_opt(sbi->s_mount_opt, RESERVATION); | ||
2105 | set_opt(sbi->s_mount_opt, BARRIER); | 2325 | set_opt(sbi->s_mount_opt, BARRIER); |
2106 | 2326 | ||
2107 | /* | 2327 | /* |
@@ -2325,14 +2545,9 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2325 | #ifdef CONFIG_PROC_FS | 2545 | #ifdef CONFIG_PROC_FS |
2326 | if (ext4_proc_root) | 2546 | if (ext4_proc_root) |
2327 | sbi->s_proc = proc_mkdir(sb->s_id, ext4_proc_root); | 2547 | sbi->s_proc = proc_mkdir(sb->s_id, ext4_proc_root); |
2328 | |||
2329 | if (sbi->s_proc) | ||
2330 | proc_create_data("inode_readahead_blks", 0644, sbi->s_proc, | ||
2331 | &ext4_ui_proc_fops, | ||
2332 | &sbi->s_inode_readahead_blks); | ||
2333 | #endif | 2548 | #endif |
2334 | 2549 | ||
2335 | bgl_lock_init(&sbi->s_blockgroup_lock); | 2550 | bgl_lock_init(sbi->s_blockgroup_lock); |
2336 | 2551 | ||
2337 | for (i = 0; i < db_count; i++) { | 2552 | for (i = 0; i < db_count; i++) { |
2338 | block = descriptor_loc(sb, logical_sb_block, i); | 2553 | block = descriptor_loc(sb, logical_sb_block, i); |
@@ -2564,6 +2779,16 @@ no_journal: | |||
2564 | goto failed_mount4; | 2779 | goto failed_mount4; |
2565 | } | 2780 | } |
2566 | 2781 | ||
2782 | sbi->s_kobj.kset = ext4_kset; | ||
2783 | init_completion(&sbi->s_kobj_unregister); | ||
2784 | err = kobject_init_and_add(&sbi->s_kobj, &ext4_ktype, NULL, | ||
2785 | "%s", sb->s_id); | ||
2786 | if (err) { | ||
2787 | ext4_mb_release(sb); | ||
2788 | ext4_ext_release(sb); | ||
2789 | goto failed_mount4; | ||
2790 | }; | ||
2791 | |||
2567 | /* | 2792 | /* |
2568 | * akpm: core read_super() calls in here with the superblock locked. | 2793 | * akpm: core read_super() calls in here with the superblock locked. |
2569 | * That deadlocks, because orphan cleanup needs to lock the superblock | 2794 | * That deadlocks, because orphan cleanup needs to lock the superblock |
@@ -2618,7 +2843,6 @@ failed_mount2: | |||
2618 | kfree(sbi->s_group_desc); | 2843 | kfree(sbi->s_group_desc); |
2619 | failed_mount: | 2844 | failed_mount: |
2620 | if (sbi->s_proc) { | 2845 | if (sbi->s_proc) { |
2621 | remove_proc_entry("inode_readahead_blks", sbi->s_proc); | ||
2622 | remove_proc_entry(sb->s_id, ext4_proc_root); | 2846 | remove_proc_entry(sb->s_id, ext4_proc_root); |
2623 | } | 2847 | } |
2624 | #ifdef CONFIG_QUOTA | 2848 | #ifdef CONFIG_QUOTA |
@@ -2913,6 +3137,10 @@ static int ext4_commit_super(struct super_block *sb, | |||
2913 | set_buffer_uptodate(sbh); | 3137 | set_buffer_uptodate(sbh); |
2914 | } | 3138 | } |
2915 | es->s_wtime = cpu_to_le32(get_seconds()); | 3139 | es->s_wtime = cpu_to_le32(get_seconds()); |
3140 | es->s_kbytes_written = | ||
3141 | cpu_to_le64(EXT4_SB(sb)->s_kbytes_written + | ||
3142 | ((part_stat_read(sb->s_bdev->bd_part, sectors[1]) - | ||
3143 | EXT4_SB(sb)->s_sectors_written_start) >> 1)); | ||
2916 | ext4_free_blocks_count_set(es, percpu_counter_sum_positive( | 3144 | ext4_free_blocks_count_set(es, percpu_counter_sum_positive( |
2917 | &EXT4_SB(sb)->s_freeblocks_counter)); | 3145 | &EXT4_SB(sb)->s_freeblocks_counter)); |
2918 | es->s_free_inodes_count = cpu_to_le32(percpu_counter_sum_positive( | 3146 | es->s_free_inodes_count = cpu_to_le32(percpu_counter_sum_positive( |
@@ -3647,45 +3875,6 @@ static int ext4_get_sb(struct file_system_type *fs_type, | |||
3647 | return get_sb_bdev(fs_type, flags, dev_name, data, ext4_fill_super, mnt); | 3875 | return get_sb_bdev(fs_type, flags, dev_name, data, ext4_fill_super, mnt); |
3648 | } | 3876 | } |
3649 | 3877 | ||
3650 | #ifdef CONFIG_PROC_FS | ||
3651 | static int ext4_ui_proc_show(struct seq_file *m, void *v) | ||
3652 | { | ||
3653 | unsigned int *p = m->private; | ||
3654 | |||
3655 | seq_printf(m, "%u\n", *p); | ||
3656 | return 0; | ||
3657 | } | ||
3658 | |||
3659 | static int ext4_ui_proc_open(struct inode *inode, struct file *file) | ||
3660 | { | ||
3661 | return single_open(file, ext4_ui_proc_show, PDE(inode)->data); | ||
3662 | } | ||
3663 | |||
3664 | static ssize_t ext4_ui_proc_write(struct file *file, const char __user *buf, | ||
3665 | size_t cnt, loff_t *ppos) | ||
3666 | { | ||
3667 | unsigned long *p = PDE(file->f_path.dentry->d_inode)->data; | ||
3668 | char str[32]; | ||
3669 | |||
3670 | if (cnt >= sizeof(str)) | ||
3671 | return -EINVAL; | ||
3672 | if (copy_from_user(str, buf, cnt)) | ||
3673 | return -EFAULT; | ||
3674 | |||
3675 | *p = simple_strtoul(str, NULL, 0); | ||
3676 | return cnt; | ||
3677 | } | ||
3678 | |||
3679 | const struct file_operations ext4_ui_proc_fops = { | ||
3680 | .owner = THIS_MODULE, | ||
3681 | .open = ext4_ui_proc_open, | ||
3682 | .read = seq_read, | ||
3683 | .llseek = seq_lseek, | ||
3684 | .release = single_release, | ||
3685 | .write = ext4_ui_proc_write, | ||
3686 | }; | ||
3687 | #endif | ||
3688 | |||
3689 | static struct file_system_type ext4_fs_type = { | 3878 | static struct file_system_type ext4_fs_type = { |
3690 | .owner = THIS_MODULE, | 3879 | .owner = THIS_MODULE, |
3691 | .name = "ext4", | 3880 | .name = "ext4", |
@@ -3719,6 +3908,9 @@ static int __init init_ext4_fs(void) | |||
3719 | { | 3908 | { |
3720 | int err; | 3909 | int err; |
3721 | 3910 | ||
3911 | ext4_kset = kset_create_and_add("ext4", NULL, fs_kobj); | ||
3912 | if (!ext4_kset) | ||
3913 | return -ENOMEM; | ||
3722 | ext4_proc_root = proc_mkdir("fs/ext4", NULL); | 3914 | ext4_proc_root = proc_mkdir("fs/ext4", NULL); |
3723 | err = init_ext4_mballoc(); | 3915 | err = init_ext4_mballoc(); |
3724 | if (err) | 3916 | if (err) |
@@ -3760,6 +3952,7 @@ static void __exit exit_ext4_fs(void) | |||
3760 | exit_ext4_xattr(); | 3952 | exit_ext4_xattr(); |
3761 | exit_ext4_mballoc(); | 3953 | exit_ext4_mballoc(); |
3762 | remove_proc_entry("fs/ext4", NULL); | 3954 | remove_proc_entry("fs/ext4", NULL); |
3955 | kset_unregister(ext4_kset); | ||
3763 | } | 3956 | } |
3764 | 3957 | ||
3765 | MODULE_AUTHOR("Remy Card, Stephen Tweedie, Andrew Morton, Andreas Dilger, Theodore Ts'o and others"); | 3958 | MODULE_AUTHOR("Remy Card, Stephen Tweedie, Andrew Morton, Andreas Dilger, Theodore Ts'o and others"); |