diff options
author | Theodore Ts'o <tytso@mit.edu> | 2010-07-29 15:06:10 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2010-07-29 15:06:10 -0400 |
commit | 4538821993f4486c76090dfb377c60c0a0e71ba3 (patch) | |
tree | d196075a963896c25df9ceb983a19ce82f5eab9b /fs/ext4 | |
parent | f613dfcb3345dacb8cf99b7bb359acc1c18a1157 (diff) |
ext4: drop inode from orphan list if ext4_delete_inode() fails
There were some error paths in ext4_delete_inode() which was not
dropping the inode from the orphan list. This could lead to a BUG_ON
on umount when the orphan list is discovered to be non-empty.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
-rw-r--r-- | fs/ext4/inode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index a52d5af99187..533b607f9cb5 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -221,6 +221,7 @@ void ext4_delete_inode(struct inode *inode) | |||
221 | "couldn't extend journal (err %d)", err); | 221 | "couldn't extend journal (err %d)", err); |
222 | stop_handle: | 222 | stop_handle: |
223 | ext4_journal_stop(handle); | 223 | ext4_journal_stop(handle); |
224 | ext4_orphan_del(NULL, inode); | ||
224 | goto no_delete; | 225 | goto no_delete; |
225 | } | 226 | } |
226 | } | 227 | } |