diff options
author | Kirill Korotaev <dev@openvz.org> | 2007-06-23 20:16:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-06-24 11:59:12 -0400 |
commit | e5d2861f31474b373ce7754dc5122b414a176c64 (patch) | |
tree | 17daf2e4c81af9adc74912fb4cc15a2a16d819ff /fs/ext4 | |
parent | e4a10a362cd1df6c23fe46f449d36b3f712e2824 (diff) |
ext4: lost brelse in ext4_read_inode()
One of error path in ext4_read_inode() leaks bh since brelse is forgoten.
Signed-off-by: Kirill Korotaev <dev@openvz.org>
Acked-by: Vasily Averin <vvs@sw.ru>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ext4')
-rw-r--r-- | fs/ext4/inode.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0bcf62a750ff..8416fa28c422 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -2673,8 +2673,10 @@ void ext4_read_inode(struct inode * inode) | |||
2673 | */ | 2673 | */ |
2674 | ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize); | 2674 | ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize); |
2675 | if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize > | 2675 | if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize > |
2676 | EXT4_INODE_SIZE(inode->i_sb)) | 2676 | EXT4_INODE_SIZE(inode->i_sb)) { |
2677 | brelse (bh); | ||
2677 | goto bad_inode; | 2678 | goto bad_inode; |
2679 | } | ||
2678 | if (ei->i_extra_isize == 0) { | 2680 | if (ei->i_extra_isize == 0) { |
2679 | /* The extra space is currently unused. Use it. */ | 2681 | /* The extra space is currently unused. Use it. */ |
2680 | ei->i_extra_isize = sizeof(struct ext4_inode) - | 2682 | ei->i_extra_isize = sizeof(struct ext4_inode) - |