diff options
author | Jan Kara <jack@suse.cz> | 2012-07-22 20:29:31 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2012-07-22 20:29:31 -0400 |
commit | 97a7406880f61d7f89d613cf72e87682420e66b0 (patch) | |
tree | cb6a314383e5279718eaa66c6d549d90e85aee99 /fs/ext4 | |
parent | 254706056be7e4e161ae9675ead6cd4e269be966 (diff) |
ext4: remove useless marking of superblock dirty
Commit a0375156 properly notes that superblock doesn't need to be marked
as dirty when only number of free inodes / blocks / number of directories
changes since that is recomputed on each mount anyway. However that comment
leaves some unnecessary markings as dirty in place. Remove these.
Artem: tested using xfstests for both journalled and non-journalled ext4.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Tested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Diffstat (limited to 'fs/ext4')
-rw-r--r-- | fs/ext4/ialloc.c | 2 | ||||
-rw-r--r-- | fs/ext4/mballoc.c | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 6866bc233e94..26154b81b836 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c | |||
@@ -315,7 +315,6 @@ out: | |||
315 | err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh); | 315 | err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh); |
316 | if (!fatal) | 316 | if (!fatal) |
317 | fatal = err; | 317 | fatal = err; |
318 | ext4_mark_super_dirty(sb); | ||
319 | } else | 318 | } else |
320 | ext4_error(sb, "bit already cleared for inode %lu", ino); | 319 | ext4_error(sb, "bit already cleared for inode %lu", ino); |
321 | 320 | ||
@@ -830,7 +829,6 @@ got: | |||
830 | percpu_counter_dec(&sbi->s_freeinodes_counter); | 829 | percpu_counter_dec(&sbi->s_freeinodes_counter); |
831 | if (S_ISDIR(mode)) | 830 | if (S_ISDIR(mode)) |
832 | percpu_counter_inc(&sbi->s_dirs_counter); | 831 | percpu_counter_inc(&sbi->s_dirs_counter); |
833 | ext4_mark_super_dirty(sb); | ||
834 | 832 | ||
835 | if (sbi->s_log_groups_per_flex) { | 833 | if (sbi->s_log_groups_per_flex) { |
836 | flex_group = ext4_flex_group(sbi, group); | 834 | flex_group = ext4_flex_group(sbi, group); |
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index ca376e7d716a..8eae94771c45 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
@@ -2831,7 +2831,6 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, | |||
2831 | err = ext4_handle_dirty_metadata(handle, NULL, gdp_bh); | 2831 | err = ext4_handle_dirty_metadata(handle, NULL, gdp_bh); |
2832 | 2832 | ||
2833 | out_err: | 2833 | out_err: |
2834 | ext4_mark_super_dirty(sb); | ||
2835 | brelse(bitmap_bh); | 2834 | brelse(bitmap_bh); |
2836 | return err; | 2835 | return err; |
2837 | } | 2836 | } |
@@ -4700,7 +4699,6 @@ do_more: | |||
4700 | put_bh(bitmap_bh); | 4699 | put_bh(bitmap_bh); |
4701 | goto do_more; | 4700 | goto do_more; |
4702 | } | 4701 | } |
4703 | ext4_mark_super_dirty(sb); | ||
4704 | error_return: | 4702 | error_return: |
4705 | brelse(bitmap_bh); | 4703 | brelse(bitmap_bh); |
4706 | ext4_std_error(sb, err); | 4704 | ext4_std_error(sb, err); |