diff options
author | Jan Kara <jack@suse.cz> | 2013-06-04 14:46:12 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2013-06-04 14:46:12 -0400 |
commit | 5dc23bdd5f846ef868e82f789dfd9b13093f9ba6 (patch) | |
tree | 1d505a49148313179dbddcbce110caee9ab0569a /fs/ext4/page-io.c | |
parent | c724585b62411f7abdea5b1054b9f1e1e7c964be (diff) |
ext4: remove ext4_ioend_wait()
Now that we clear PageWriteback after extent conversion, there's no
need to wait for io_end processing in ext4_evict_inode(). Running
AIO/DIO keeps file reference until aio_complete() is called so
ext4_evict_inode() cannot be called. For io_end structures resulting
from buffered IO waiting is happening because we wait for
PageWriteback in truncate_inode_pages().
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/page-io.c')
-rw-r--r-- | fs/ext4/page-io.c | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 6ee5bd389405..ce8c15a7eabc 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c | |||
@@ -46,25 +46,6 @@ void ext4_exit_pageio(void) | |||
46 | } | 46 | } |
47 | 47 | ||
48 | /* | 48 | /* |
49 | * This function is called by ext4_evict_inode() to make sure there is | ||
50 | * no more pending I/O completion work left to do. | ||
51 | */ | ||
52 | void ext4_ioend_shutdown(struct inode *inode) | ||
53 | { | ||
54 | wait_queue_head_t *wq = ext4_ioend_wq(inode); | ||
55 | |||
56 | wait_event(*wq, (atomic_read(&EXT4_I(inode)->i_ioend_count) == 0)); | ||
57 | /* | ||
58 | * We need to make sure the work structure is finished being | ||
59 | * used before we let the inode get destroyed. | ||
60 | */ | ||
61 | if (work_pending(&EXT4_I(inode)->i_rsv_conversion_work)) | ||
62 | cancel_work_sync(&EXT4_I(inode)->i_rsv_conversion_work); | ||
63 | if (work_pending(&EXT4_I(inode)->i_unrsv_conversion_work)) | ||
64 | cancel_work_sync(&EXT4_I(inode)->i_unrsv_conversion_work); | ||
65 | } | ||
66 | |||
67 | /* | ||
68 | * Print an buffer I/O error compatible with the fs/buffer.c. This | 49 | * Print an buffer I/O error compatible with the fs/buffer.c. This |
69 | * provides compatibility with dmesg scrapers that look for a specific | 50 | * provides compatibility with dmesg scrapers that look for a specific |
70 | * buffer I/O error message. We really need a unified error reporting | 51 | * buffer I/O error message. We really need a unified error reporting |