diff options
author | Yasunori Goto <y-goto@jp.fujitsu.com> | 2008-12-17 00:48:39 -0500 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2008-12-17 00:48:39 -0500 |
commit | ff7ef329b268b603ea4a2303241ef1c3829fd574 (patch) | |
tree | 5f95f4828ef7e68c06996b18c405bc0526e2bb34 /fs/ext4/mballoc.c | |
parent | 93c0d86371a5b2e68473752a6e54ff03185c473e (diff) |
ext4: Widen type of ext4_sb_info.s_mb_maxs[]
I chased the cause of following ext4 oops report which is tested on
ia64 box.
http://bugzilla.kernel.org/show_bug.cgi?id=12018
The cause is the size of s_mb_maxs array that is defined as "unsigned
short" in ext4_sb_info structure. If the file system's block size is
8k or greater, an unsigned short is not wide enough to contain the
value fs->blocksize << 3.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Miao Xie <miaox@cn.fujitsu.com>
Cc: stable@kernel.org
Diffstat (limited to 'fs/ext4/mballoc.c')
-rw-r--r-- | fs/ext4/mballoc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 444ad998f72e..7beab7141dd5 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
@@ -2493,6 +2493,8 @@ int ext4_mb_init(struct super_block *sb, int needs_recovery) | |||
2493 | if (sbi->s_mb_offsets == NULL) { | 2493 | if (sbi->s_mb_offsets == NULL) { |
2494 | return -ENOMEM; | 2494 | return -ENOMEM; |
2495 | } | 2495 | } |
2496 | |||
2497 | i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int); | ||
2496 | sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL); | 2498 | sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL); |
2497 | if (sbi->s_mb_maxs == NULL) { | 2499 | if (sbi->s_mb_maxs == NULL) { |
2498 | kfree(sbi->s_mb_maxs); | 2500 | kfree(sbi->s_mb_maxs); |