aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/inode.c
diff options
context:
space:
mode:
authorEric Dumazet <dada1@cosmosbay.com>2009-01-06 17:41:04 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2009-01-06 18:59:13 -0500
commit179f7ebff6be45738c6e2fa68c8d2cc5c2c6308e (patch)
tree3d48b5f825cfa29f5b39656503c5157872454e9f /fs/ext4/inode.c
parente3d5a27d5862b6425d0879272e24abecf7245105 (diff)
percpu_counter: FBC_BATCH should be a variable
For NR_CPUS >= 16 values, FBC_BATCH is 2*NR_CPUS Considering more and more distros are using high NR_CPUS values, it makes sense to use a more sensible value for FBC_BATCH, and get rid of NR_CPUS. A sensible value is 2*num_online_cpus(), with a minimum value of 32 (This minimum value helps branch prediction in __percpu_counter_add()) We already have a hotcpu notifier, so we can adjust FBC_BATCH dynamically. We rename FBC_BATCH to percpu_counter_batch since its not a constant anymore. Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> Acked-by: David S. Miller <davem@davemloft.net> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ext4/inode.c')
-rw-r--r--fs/ext4/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 6702a49992a6..98d3fe7057ef 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2498,7 +2498,7 @@ static int ext4_nonda_switch(struct super_block *sb)
2498 /* 2498 /*
2499 * switch to non delalloc mode if we are running low 2499 * switch to non delalloc mode if we are running low
2500 * on free block. The free block accounting via percpu 2500 * on free block. The free block accounting via percpu
2501 * counters can get slightly wrong with FBC_BATCH getting 2501 * counters can get slightly wrong with percpu_counter_batch getting
2502 * accumulated on each CPU without updating global counters 2502 * accumulated on each CPU without updating global counters
2503 * Delalloc need an accurate free block accounting. So switch 2503 * Delalloc need an accurate free block accounting. So switch
2504 * to non delalloc when we are near to error range. 2504 * to non delalloc when we are near to error range.