diff options
author | Christoph Hellwig <hch@lst.de> | 2010-06-04 05:29:53 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2010-08-09 16:47:29 -0400 |
commit | eafdc7d190a944c755a9fe68573c193e6e0217e7 (patch) | |
tree | 915c3cc8004706fabf88eae1ab123a3fa0147516 /fs/ext4/inode.c | |
parent | 256249584bda1a9357e2d29987a37f5b2df035f6 (diff) |
sort out blockdev_direct_IO variants
Move the call to vmtruncate to get rid of accessive blocks to the callers
in prepearation of the new truncate calling sequence. This was only done
for DIO_LOCKING filesystems, so the __blockdev_direct_IO_newtrunc variant
was not needed anyway. Get rid of blockdev_direct_IO_no_locking and
its _newtrunc variant while at it as just opencoding the two additional
paramters is shorted than the name suffix.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ext4/inode.c')
-rw-r--r-- | fs/ext4/inode.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0afc8c1d8cf3..d6a7701018a6 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -3545,15 +3545,24 @@ static ssize_t ext4_ind_direct_IO(int rw, struct kiocb *iocb, | |||
3545 | 3545 | ||
3546 | retry: | 3546 | retry: |
3547 | if (rw == READ && ext4_should_dioread_nolock(inode)) | 3547 | if (rw == READ && ext4_should_dioread_nolock(inode)) |
3548 | ret = blockdev_direct_IO_no_locking(rw, iocb, inode, | 3548 | ret = __blockdev_direct_IO(rw, iocb, inode, |
3549 | inode->i_sb->s_bdev, iov, | 3549 | inode->i_sb->s_bdev, iov, |
3550 | offset, nr_segs, | 3550 | offset, nr_segs, |
3551 | ext4_get_block, NULL); | 3551 | ext4_get_block, NULL, NULL, 0); |
3552 | else | 3552 | else { |
3553 | ret = blockdev_direct_IO(rw, iocb, inode, | 3553 | ret = blockdev_direct_IO(rw, iocb, inode, |
3554 | inode->i_sb->s_bdev, iov, | 3554 | inode->i_sb->s_bdev, iov, |
3555 | offset, nr_segs, | 3555 | offset, nr_segs, |
3556 | ext4_get_block, NULL); | 3556 | ext4_get_block, NULL); |
3557 | |||
3558 | if (unlikely((rw & WRITE) && ret < 0)) { | ||
3559 | loff_t isize = i_size_read(inode); | ||
3560 | loff_t end = offset + iov_length(iov, nr_segs); | ||
3561 | |||
3562 | if (end > isize) | ||
3563 | vmtruncate(inode, isize); | ||
3564 | } | ||
3565 | } | ||
3557 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) | 3566 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) |
3558 | goto retry; | 3567 | goto retry; |
3559 | 3568 | ||