diff options
author | Nick Piggin <npiggin@suse.de> | 2009-03-31 18:23:21 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-01 11:59:14 -0400 |
commit | c2ec175c39f62949438354f603f4aa170846aabb (patch) | |
tree | f2c9bf1bec2deabe2d3a5092405b027637b6ead3 /fs/ext4/inode.c | |
parent | c2fdf3a9b2d52842808a8e551b53b55dd9b45030 (diff) |
mm: page_mkwrite change prototype to match fault
Change the page_mkwrite prototype to take a struct vm_fault, and return
VM_FAULT_xxx flags. There should be no functional change.
This makes it possible to return much more detailed error information to
the VM (and also can provide more information eg. virtual_address to the
driver, which might be important in some special cases).
This is required for a subsequent fix. And will also make it easier to
merge page_mkwrite() with fault() in future.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Artem Bityutskiy <dedekind@infradead.org>
Cc: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ext4/inode.c')
-rw-r--r-- | fs/ext4/inode.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 71d3ecd5db79..dd82ff390067 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -5146,8 +5146,9 @@ static int ext4_bh_unmapped(handle_t *handle, struct buffer_head *bh) | |||
5146 | return !buffer_mapped(bh); | 5146 | return !buffer_mapped(bh); |
5147 | } | 5147 | } |
5148 | 5148 | ||
5149 | int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page) | 5149 | int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) |
5150 | { | 5150 | { |
5151 | struct page *page = vmf->page; | ||
5151 | loff_t size; | 5152 | loff_t size; |
5152 | unsigned long len; | 5153 | unsigned long len; |
5153 | int ret = -EINVAL; | 5154 | int ret = -EINVAL; |
@@ -5199,6 +5200,8 @@ int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page) | |||
5199 | goto out_unlock; | 5200 | goto out_unlock; |
5200 | ret = 0; | 5201 | ret = 0; |
5201 | out_unlock: | 5202 | out_unlock: |
5203 | if (ret) | ||
5204 | ret = VM_FAULT_SIGBUS; | ||
5202 | up_read(&inode->i_alloc_sem); | 5205 | up_read(&inode->i_alloc_sem); |
5203 | return ret; | 5206 | return ret; |
5204 | } | 5207 | } |