diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-02-01 20:07:21 -0500 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2013-02-01 20:07:21 -0500 |
commit | 524c19ebc961799b1ec126e4b063b941a70275e5 (patch) | |
tree | 7307132472ee3f01fae5d04cdce66bc84dfa3b87 /fs/ext4/indirect.c | |
parent | e7b04ac00ee273cb2c699ed14139fc072add4097 (diff) |
ext4: use WARN in ext4_alloc_blocks
Use WARN rather than printk followed by WARN_ON(1), for conciseness.
A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression list es;
@@
-printk(
+WARN(1,
es);
-WARN_ON(1);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/indirect.c')
-rw-r--r-- | fs/ext4/indirect.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c index bdd20231e66c..193281098fb6 100644 --- a/fs/ext4/indirect.c +++ b/fs/ext4/indirect.c | |||
@@ -358,9 +358,8 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode, | |||
358 | * for the first direct block | 358 | * for the first direct block |
359 | */ | 359 | */ |
360 | new_blocks[index] = current_block; | 360 | new_blocks[index] = current_block; |
361 | printk(KERN_INFO "%s returned more blocks than " | 361 | WARN(1, KERN_INFO "%s returned more blocks than " |
362 | "requested\n", __func__); | 362 | "requested\n", __func__); |
363 | WARN_ON(1); | ||
364 | break; | 363 | break; |
365 | } | 364 | } |
366 | } | 365 | } |