aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/extents.c
diff options
context:
space:
mode:
authorMingming <cmm@us.ibm.com>2009-11-10 10:48:08 -0500
committerTheodore Ts'o <tytso@mit.edu>2009-11-10 10:48:08 -0500
commit109f55651954def97fa41ee71c464d268c512ab0 (patch)
tree7c4aa2d8cb10c100bbd252e657ac410d30844bac /fs/ext4/extents.c
parentfa5d11133b07053270e18fa9c18560e66e79217e (diff)
ext4: fix ext4_ext_direct_IO()'s return value after converting uninit extents
After a direct I/O request covering an uninitalized extent (i.e., created using the fallocate system call) or a hole in a file, ext4 will convert the uninitialized extent so it is marked as initialized by calling ext4_convert_unwritten_extents(). This function returns zero on success. This return value was getting returned by ext4_direct_IO(); however the file system's direct_IO function is supposed to return the number of bytes read or written on a success. By returning zero, it confused the direct I/O code into falling back to buffered I/O unnecessarily. Signed-off-by: Mingming Cao <cmm@us.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/extents.c')
-rw-r--r--fs/ext4/extents.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 10539e364283..441716f33b4a 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3519,6 +3519,7 @@ retry:
3519 * 3519 *
3520 * This function is called from the direct IO end io call back 3520 * This function is called from the direct IO end io call back
3521 * function, to convert the fallocated extents after IO is completed. 3521 * function, to convert the fallocated extents after IO is completed.
3522 * Returns 0 on success.
3522 */ 3523 */
3523int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, 3524int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset,
3524 loff_t len) 3525 loff_t len)