aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/extents.c
diff options
context:
space:
mode:
authorEric Sandeen <sandeen@redhat.com>2010-02-04 23:58:38 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2010-04-26 10:48:04 -0400
commit4c08f09270bdf83ca42a058970613cabe3fc8b41 (patch)
tree1e82f713ce8501bdca352693bdb793e3810a6424 /fs/ext4/extents.c
parentc081243f7a9278f093bbc87bc5c56f1f2d203904 (diff)
ext4: fix async i/o writes beyond 4GB to a sparse file
commit a1de02dccf906faba2ee2d99cac56799bda3b96a upstream. The "offset" member in ext4_io_end holds bytes, not blocks, so ext4_lblk_t is wrong - and too small (u32). This caused the async i/o writes to sparse files beyond 4GB to fail when they wrapped around to 0. Also fix up the type of arguments to ext4_convert_unwritten_extents(), it gets ssize_t from ext4_end_aio_dio_nolock() and ext4_ext_direct_IO(). Reported-by: Giel de Nijs <giel@vectorwise.com> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Cc: maximilian attems <max@stro.at> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/ext4/extents.c')
-rw-r--r--fs/ext4/extents.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 765a4826b118..c56877972b0e 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3603,7 +3603,7 @@ retry:
3603 * Returns 0 on success. 3603 * Returns 0 on success.
3604 */ 3604 */
3605int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, 3605int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset,
3606 loff_t len) 3606 ssize_t len)
3607{ 3607{
3608 handle_t *handle; 3608 handle_t *handle;
3609 ext4_lblk_t block; 3609 ext4_lblk_t block;