aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/ext4_jbd2.h
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2009-11-24 11:05:59 -0500
committerTheodore Ts'o <tytso@mit.edu>2009-11-24 11:05:59 -0500
commite4684b3fbb848446683feecb4aee133344c93933 (patch)
treec3e695ff304a8114e9efad460c30e9948665da66 /fs/ext4/ext4_jbd2.h
parentd6797d14b1640d088652c72508b529a3aea479e3 (diff)
ext4: fold ext4_journal_revoke() into ext4_forget()
The only caller of ext4_journal_revoke() is ext4_forget(), so we can fold ext4_journal_revoke() into ext4_forget() to simplify the code and shorten the call stack. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ext4_jbd2.h')
-rw-r--r--fs/ext4/ext4_jbd2.h12
1 files changed, 1 insertions, 11 deletions
diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h
index dc0b34a903eb..f9fb4bb69577 100644
--- a/fs/ext4/ext4_jbd2.h
+++ b/fs/ext4/ext4_jbd2.h
@@ -116,12 +116,8 @@ int ext4_reserve_inode_write(handle_t *handle, struct inode *inode,
116int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode); 116int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode);
117 117
118/* 118/*
119 * Wrapper functions with which ext4 calls into JBD. The intent here is 119 * Wrapper functions with which ext4 calls into JBD.
120 * to allow these to be turned into appropriate stubs so ext4 can control
121 * ext2 filesystems, so ext2+ext4 systems only nee one fs. This work hasn't
122 * been done yet.
123 */ 120 */
124
125void ext4_journal_abort_handle(const char *caller, const char *err_fn, 121void ext4_journal_abort_handle(const char *caller, const char *err_fn,
126 struct buffer_head *bh, handle_t *handle, int err); 122 struct buffer_head *bh, handle_t *handle, int err);
127 123
@@ -135,10 +131,6 @@ int __ext4_journal_get_write_access(const char *where, handle_t *handle,
135int __ext4_journal_forget(const char *where, handle_t *handle, 131int __ext4_journal_forget(const char *where, handle_t *handle,
136 struct buffer_head *bh); 132 struct buffer_head *bh);
137 133
138/* When called with an invalid handle, this will still do a put on the BH */
139int __ext4_journal_revoke(const char *where, handle_t *handle,
140 ext4_fsblk_t blocknr, struct buffer_head *bh);
141
142int __ext4_forget(const char *where, handle_t *handle, int is_metadata, 134int __ext4_forget(const char *where, handle_t *handle, int is_metadata,
143 struct inode *inode, struct buffer_head *bh, 135 struct inode *inode, struct buffer_head *bh,
144 ext4_fsblk_t blocknr); 136 ext4_fsblk_t blocknr);
@@ -153,8 +145,6 @@ int __ext4_handle_dirty_metadata(const char *where, handle_t *handle,
153 __ext4_journal_get_undo_access(__func__, (handle), (bh)) 145 __ext4_journal_get_undo_access(__func__, (handle), (bh))
154#define ext4_journal_get_write_access(handle, bh) \ 146#define ext4_journal_get_write_access(handle, bh) \
155 __ext4_journal_get_write_access(__func__, (handle), (bh)) 147 __ext4_journal_get_write_access(__func__, (handle), (bh))
156#define ext4_journal_revoke(handle, blocknr, bh) \
157 __ext4_journal_revoke(__func__, (handle), (blocknr), (bh))
158#define ext4_forget(handle, is_metadata, inode, bh, block_nr) \ 148#define ext4_forget(handle, is_metadata, inode, bh, block_nr) \
159 __ext4_forget(__func__, (handle), (is_metadata), (inode), (bh),\ 149 __ext4_forget(__func__, (handle), (is_metadata), (inode), (bh),\
160 (block_nr)) 150 (block_nr))