aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/ext4.h
diff options
context:
space:
mode:
authorLukas Czerner <lczerner@redhat.com>2014-04-20 23:44:47 -0400
committerTheodore Ts'o <tytso@mit.edu>2014-04-20 23:44:47 -0400
commit090f32ee4ef0a59c738963c6b0a6948cc5dee84c (patch)
tree1607ea017a0ba3d4373dd91a5b0d39c6bd64377f /fs/ext4/ext4.h
parent9ac03675010a69507c0a9d832d6a722e07d35cc6 (diff)
ext4: get rid of EXT4_MAP_UNINIT flag
Currently EXT4_MAP_UNINIT is used in dioread_nolock case to mark the cases where we're using dioread_nolock and we're writing into either unallocated, or unwritten extent, because we need to make sure that any DIO write into that inode will wait for the extent conversion. However EXT4_MAP_UNINIT is not only entirely misleading name but also unnecessary because we can check for EXT4_MAP_UNWRITTEN in the dioread_nolock case instead. This commit removes EXT4_MAP_UNINIT flag. Signed-off-by: Lukas Czerner <lczerner@redhat.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ext4.h')
-rw-r--r--fs/ext4/ext4.h8
1 files changed, 3 insertions, 5 deletions
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 66946aa62127..b681d90b1e87 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -158,7 +158,6 @@ struct ext4_allocation_request {
158#define EXT4_MAP_MAPPED (1 << BH_Mapped) 158#define EXT4_MAP_MAPPED (1 << BH_Mapped)
159#define EXT4_MAP_UNWRITTEN (1 << BH_Unwritten) 159#define EXT4_MAP_UNWRITTEN (1 << BH_Unwritten)
160#define EXT4_MAP_BOUNDARY (1 << BH_Boundary) 160#define EXT4_MAP_BOUNDARY (1 << BH_Boundary)
161#define EXT4_MAP_UNINIT (1 << BH_Uninit)
162/* Sometimes (in the bigalloc case, from ext4_da_get_block_prep) the caller of 161/* Sometimes (in the bigalloc case, from ext4_da_get_block_prep) the caller of
163 * ext4_map_blocks wants to know whether or not the underlying cluster has 162 * ext4_map_blocks wants to know whether or not the underlying cluster has
164 * already been accounted for. EXT4_MAP_FROM_CLUSTER conveys to the caller that 163 * already been accounted for. EXT4_MAP_FROM_CLUSTER conveys to the caller that
@@ -169,7 +168,7 @@ struct ext4_allocation_request {
169#define EXT4_MAP_FROM_CLUSTER (1 << BH_AllocFromCluster) 168#define EXT4_MAP_FROM_CLUSTER (1 << BH_AllocFromCluster)
170#define EXT4_MAP_FLAGS (EXT4_MAP_NEW | EXT4_MAP_MAPPED |\ 169#define EXT4_MAP_FLAGS (EXT4_MAP_NEW | EXT4_MAP_MAPPED |\
171 EXT4_MAP_UNWRITTEN | EXT4_MAP_BOUNDARY |\ 170 EXT4_MAP_UNWRITTEN | EXT4_MAP_BOUNDARY |\
172 EXT4_MAP_UNINIT | EXT4_MAP_FROM_CLUSTER) 171 EXT4_MAP_FROM_CLUSTER)
173 172
174struct ext4_map_blocks { 173struct ext4_map_blocks {
175 ext4_fsblk_t m_pblk; 174 ext4_fsblk_t m_pblk;
@@ -2784,10 +2783,9 @@ extern int ext4_mmp_csum_verify(struct super_block *sb,
2784 * See EXT4_MAP_... to see where this is used. 2783 * See EXT4_MAP_... to see where this is used.
2785 */ 2784 */
2786enum ext4_state_bits { 2785enum ext4_state_bits {
2787 BH_Uninit /* blocks are allocated but uninitialized on disk */ 2786 BH_AllocFromCluster /* allocated blocks were part of already
2788 = BH_JBDPrivateStart,
2789 BH_AllocFromCluster, /* allocated blocks were part of already
2790 * allocated cluster. */ 2787 * allocated cluster. */
2788 = BH_JBDPrivateStart
2791}; 2789};
2792 2790
2793/* 2791/*