aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/balloc.c
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2009-01-05 22:18:16 -0500
committerTheodore Ts'o <tytso@mit.edu>2009-01-05 22:18:16 -0500
commita9df9a49102f3578909cba7bd33784eb3b9caaa4 (patch)
tree1d383d422bf7185e8e87c1bcfc80f9beb3074cf8 /fs/ext4/balloc.c
parentcde6436004ad9cd8cab5a874b6fa8b01f1da91bf (diff)
ext4: Make ext4_group_t be an unsigned int
Nearly all places in the ext3/4 code which uses "unsigned long" is probably a bug, since on 32-bit systems a ulong a 32-bits, which means we are wasting stack space on 64-bit systems. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/balloc.c')
-rw-r--r--fs/ext4/balloc.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 0cb1c4572f54..a711898923f0 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -100,7 +100,7 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh,
100 * essentially implementing a per-group read-only flag. */ 100 * essentially implementing a per-group read-only flag. */
101 if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { 101 if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) {
102 ext4_error(sb, __func__, 102 ext4_error(sb, __func__,
103 "Checksum bad for group %lu", block_group); 103 "Checksum bad for group %u", block_group);
104 gdp->bg_free_blocks_count = 0; 104 gdp->bg_free_blocks_count = 0;
105 gdp->bg_free_inodes_count = 0; 105 gdp->bg_free_inodes_count = 0;
106 gdp->bg_itable_unused = 0; 106 gdp->bg_itable_unused = 0;
@@ -213,7 +213,7 @@ struct ext4_group_desc * ext4_get_group_desc(struct super_block *sb,
213 if (block_group >= sbi->s_groups_count) { 213 if (block_group >= sbi->s_groups_count) {
214 ext4_error(sb, "ext4_get_group_desc", 214 ext4_error(sb, "ext4_get_group_desc",
215 "block_group >= groups_count - " 215 "block_group >= groups_count - "
216 "block_group = %lu, groups_count = %lu", 216 "block_group = %u, groups_count = %u",
217 block_group, sbi->s_groups_count); 217 block_group, sbi->s_groups_count);
218 218
219 return NULL; 219 return NULL;
@@ -225,7 +225,7 @@ struct ext4_group_desc * ext4_get_group_desc(struct super_block *sb,
225 if (!sbi->s_group_desc[group_desc]) { 225 if (!sbi->s_group_desc[group_desc]) {
226 ext4_error(sb, "ext4_get_group_desc", 226 ext4_error(sb, "ext4_get_group_desc",
227 "Group descriptor not loaded - " 227 "Group descriptor not loaded - "
228 "block_group = %lu, group_desc = %lu, desc = %lu", 228 "block_group = %u, group_desc = %lu, desc = %lu",
229 block_group, group_desc, offset); 229 block_group, group_desc, offset);
230 return NULL; 230 return NULL;
231 } 231 }
@@ -315,7 +315,7 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group)
315 if (unlikely(!bh)) { 315 if (unlikely(!bh)) {
316 ext4_error(sb, __func__, 316 ext4_error(sb, __func__,
317 "Cannot read block bitmap - " 317 "Cannot read block bitmap - "
318 "block_group = %lu, block_bitmap = %llu", 318 "block_group = %u, block_bitmap = %llu",
319 block_group, bitmap_blk); 319 block_group, bitmap_blk);
320 return NULL; 320 return NULL;
321 } 321 }
@@ -337,7 +337,7 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group)
337 put_bh(bh); 337 put_bh(bh);
338 ext4_error(sb, __func__, 338 ext4_error(sb, __func__,
339 "Cannot read block bitmap - " 339 "Cannot read block bitmap - "
340 "block_group = %lu, block_bitmap = %llu", 340 "block_group = %u, block_bitmap = %llu",
341 block_group, bitmap_blk); 341 block_group, bitmap_blk);
342 return NULL; 342 return NULL;
343 } 343 }