aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/balloc.c
diff options
context:
space:
mode:
authorEric Sandeen <sandeen@redhat.com>2008-08-02 21:21:02 -0400
committerTheodore Ts'o <tytso@mit.edu>2008-08-02 21:21:02 -0400
commite29d1cde63be0b5f1739416b5574a83c34bf8eeb (patch)
tree86f2951e96888a1bd9cdb39ad4b2cb4e88893d95 /fs/ext4/balloc.c
parent8a266467b8c4841ca994d0fe59f39e584650e3df (diff)
ext4: sync up block and inode bitmap reading functions
ext4_read_block_bitmap and read_inode_bitmap do essentially the same thing, and yet they are structured quite differently. I came across this difference while looking at doing bg locking during bg initialization. This patch: * removes unnecessary casts in the error messages * renames read_inode_bitmap to ext4_read_inode_bitmap * and more substantially, restructures the inode bitmap reading function to be more like the block bitmap counterpart. The change to the inode bitmap reader simplifies the locking to be applied in the next patch. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/balloc.c')
-rw-r--r--fs/ext4/balloc.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 495ab21b9832..386cb79ac4b6 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -314,8 +314,8 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group)
314 if (unlikely(!bh)) { 314 if (unlikely(!bh)) {
315 ext4_error(sb, __func__, 315 ext4_error(sb, __func__,
316 "Cannot read block bitmap - " 316 "Cannot read block bitmap - "
317 "block_group = %d, block_bitmap = %llu", 317 "block_group = %lu, block_bitmap = %llu",
318 (int)block_group, (unsigned long long)bitmap_blk); 318 block_group, bitmap_blk);
319 return NULL; 319 return NULL;
320 } 320 }
321 if (bh_uptodate_or_lock(bh)) 321 if (bh_uptodate_or_lock(bh))
@@ -331,8 +331,8 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group)
331 put_bh(bh); 331 put_bh(bh);
332 ext4_error(sb, __func__, 332 ext4_error(sb, __func__,
333 "Cannot read block bitmap - " 333 "Cannot read block bitmap - "
334 "block_group = %d, block_bitmap = %llu", 334 "block_group = %lu, block_bitmap = %llu",
335 (int)block_group, (unsigned long long)bitmap_blk); 335 block_group, bitmap_blk);
336 return NULL; 336 return NULL;
337 } 337 }
338 ext4_valid_block_bitmap(sb, desc, block_group, bh); 338 ext4_valid_block_bitmap(sb, desc, block_group, bh);