diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-02-21 03:58:54 -0500 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2014-03-03 05:31:00 -0500 |
commit | f8cb556fdbc36855ef884061a1beec6124314c89 (patch) | |
tree | 72759be92241397da5a9f3017720a87b94460a8a /fs/ext3 | |
parent | 7d6c2113505eb88a09949ed671d51c8c01cf7bb6 (diff) |
ext3: remove unneeded check in ext3_ordered_writepage()
We already know "ret" is zero so there is no need to do:
if (!ret)
ret = err;
We can just assign ret directly instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext3')
-rw-r--r-- | fs/ext3/inode.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 384b6ebb655f..491f022c476a 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
@@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page, | |||
1673 | * block_write_full_page() succeeded. Otherwise they are unmapped, | 1673 | * block_write_full_page() succeeded. Otherwise they are unmapped, |
1674 | * and generally junk. | 1674 | * and generally junk. |
1675 | */ | 1675 | */ |
1676 | if (ret == 0) { | 1676 | if (ret == 0) |
1677 | err = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE, | 1677 | ret = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE, |
1678 | NULL, journal_dirty_data_fn); | 1678 | NULL, journal_dirty_data_fn); |
1679 | if (!ret) | ||
1680 | ret = err; | ||
1681 | } | ||
1682 | walk_page_buffers(handle, page_bufs, 0, | 1679 | walk_page_buffers(handle, page_bufs, 0, |
1683 | PAGE_CACHE_SIZE, NULL, bput_one); | 1680 | PAGE_CACHE_SIZE, NULL, bput_one); |
1684 | err = ext3_journal_stop(handle); | 1681 | err = ext3_journal_stop(handle); |