diff options
author | Kirill Korotaev <dev@openvz.org> | 2007-06-23 20:16:48 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-06-24 11:59:12 -0400 |
commit | e4a10a362cd1df6c23fe46f449d36b3f712e2824 (patch) | |
tree | 2e926ca5225e8b6f52d9fc4dd3886cff7f235721 /fs/ext3 | |
parent | 7b018b2888b32284e09bba9cccb5cd2e12199feb (diff) |
ext3: lost brelse in ext3_read_inode()
One of error path in ext3_read_inode() leaks bh since brelse is forgoten.
Signed-off-by: Kirill Korotaev <dev@openvz.org>
Acked-by: Vasily Averin <vvs@sw.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ext3')
-rw-r--r-- | fs/ext3/inode.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index a6cb6171c3af..2a85ddee4740 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
@@ -2677,8 +2677,10 @@ void ext3_read_inode(struct inode * inode) | |||
2677 | */ | 2677 | */ |
2678 | ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize); | 2678 | ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize); |
2679 | if (EXT3_GOOD_OLD_INODE_SIZE + ei->i_extra_isize > | 2679 | if (EXT3_GOOD_OLD_INODE_SIZE + ei->i_extra_isize > |
2680 | EXT3_INODE_SIZE(inode->i_sb)) | 2680 | EXT3_INODE_SIZE(inode->i_sb)) { |
2681 | brelse (bh); | ||
2681 | goto bad_inode; | 2682 | goto bad_inode; |
2683 | } | ||
2682 | if (ei->i_extra_isize == 0) { | 2684 | if (ei->i_extra_isize == 0) { |
2683 | /* The extra space is currently unused. Use it. */ | 2685 | /* The extra space is currently unused. Use it. */ |
2684 | ei->i_extra_isize = sizeof(struct ext3_inode) - | 2686 | ei->i_extra_isize = sizeof(struct ext3_inode) - |