diff options
author | Jan Kara <jack@suse.cz> | 2011-07-28 11:47:10 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2011-08-17 05:41:20 -0400 |
commit | 5a0143a4f00517ea433bf459a80742ccc623a665 (patch) | |
tree | 8fa567ed44259489d4f30259f571f0a520c05f6b /fs/ext3 | |
parent | ab7e2dbf9b5da4d4eb4fdb019cc8881fbeb1299b (diff) |
ext3: Remove i_mutex from ext3_sync_file()
ext3_sync_file() does not need i_mutex for anything so just drop it.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext3')
-rw-r--r-- | fs/ext3/fsync.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/fs/ext3/fsync.c b/fs/ext3/fsync.c index d494c554c6e6..1860ed356323 100644 --- a/fs/ext3/fsync.c +++ b/fs/ext3/fsync.c | |||
@@ -61,13 +61,6 @@ int ext3_sync_file(struct file *file, loff_t start, loff_t end, int datasync) | |||
61 | if (ret) | 61 | if (ret) |
62 | goto out; | 62 | goto out; |
63 | 63 | ||
64 | /* | ||
65 | * Taking the mutex here just to keep consistent with how fsync was | ||
66 | * called previously, however it looks like we don't need to take | ||
67 | * i_mutex at all. | ||
68 | */ | ||
69 | mutex_lock(&inode->i_mutex); | ||
70 | |||
71 | J_ASSERT(ext3_journal_current_handle() == NULL); | 64 | J_ASSERT(ext3_journal_current_handle() == NULL); |
72 | 65 | ||
73 | /* | 66 | /* |
@@ -85,7 +78,6 @@ int ext3_sync_file(struct file *file, loff_t start, loff_t end, int datasync) | |||
85 | * safe in-journal, which is all fsync() needs to ensure. | 78 | * safe in-journal, which is all fsync() needs to ensure. |
86 | */ | 79 | */ |
87 | if (ext3_should_journal_data(inode)) { | 80 | if (ext3_should_journal_data(inode)) { |
88 | mutex_unlock(&inode->i_mutex); | ||
89 | ret = ext3_force_commit(inode->i_sb); | 81 | ret = ext3_force_commit(inode->i_sb); |
90 | goto out; | 82 | goto out; |
91 | } | 83 | } |
@@ -108,8 +100,6 @@ int ext3_sync_file(struct file *file, loff_t start, loff_t end, int datasync) | |||
108 | */ | 100 | */ |
109 | if (needs_barrier) | 101 | if (needs_barrier) |
110 | blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL); | 102 | blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL); |
111 | |||
112 | mutex_unlock(&inode->i_mutex); | ||
113 | out: | 103 | out: |
114 | trace_ext3_sync_file_exit(inode, ret); | 104 | trace_ext3_sync_file_exit(inode, ret); |
115 | return ret; | 105 | return ret; |