diff options
author | Christoph Hellwig <hch@lst.de> | 2010-06-07 04:20:39 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2010-07-21 10:01:47 -0400 |
commit | 4c4d3901225518ed1a4c938ba15ba09842a00770 (patch) | |
tree | 0ed9eb0ad123174ebdd6ea507ac06b388d0d0b20 /fs/ext3/super.c | |
parent | 0411ba7902e09111d6f2041b4697a597d2cf7736 (diff) |
ext3: remove vestiges of nobh support
The nobh option was only supported for writeback mode, but given that all
write paths (except mmapped writed) actually create buffer heads, it
effectively was a no-op already.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext3/super.c')
-rw-r--r-- | fs/ext3/super.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 6c953bb255e7..9650a956fd0e 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -661,9 +661,6 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
661 | */ | 661 | */ |
662 | seq_puts(seq, ",barrier="); | 662 | seq_puts(seq, ",barrier="); |
663 | seq_puts(seq, test_opt(sb, BARRIER) ? "1" : "0"); | 663 | seq_puts(seq, test_opt(sb, BARRIER) ? "1" : "0"); |
664 | if (test_opt(sb, NOBH)) | ||
665 | seq_puts(seq, ",nobh"); | ||
666 | |||
667 | seq_printf(seq, ",data=%s", data_mode_string(test_opt(sb, DATA_FLAGS))); | 664 | seq_printf(seq, ",data=%s", data_mode_string(test_opt(sb, DATA_FLAGS))); |
668 | if (test_opt(sb, DATA_ERR_ABORT)) | 665 | if (test_opt(sb, DATA_ERR_ABORT)) |
669 | seq_puts(seq, ",data_err=abort"); | 666 | seq_puts(seq, ",data_err=abort"); |
@@ -1255,10 +1252,12 @@ set_qf_format: | |||
1255 | *n_blocks_count = option; | 1252 | *n_blocks_count = option; |
1256 | break; | 1253 | break; |
1257 | case Opt_nobh: | 1254 | case Opt_nobh: |
1258 | set_opt(sbi->s_mount_opt, NOBH); | 1255 | ext3_msg(sb, KERN_WARNING, |
1256 | "warning: ignoring deprecated nobh option"); | ||
1259 | break; | 1257 | break; |
1260 | case Opt_bh: | 1258 | case Opt_bh: |
1261 | clear_opt(sbi->s_mount_opt, NOBH); | 1259 | ext3_msg(sb, KERN_WARNING, |
1260 | "warning: ignoring deprecated bh option"); | ||
1262 | break; | 1261 | break; |
1263 | default: | 1262 | default: |
1264 | ext3_msg(sb, KERN_ERR, | 1263 | ext3_msg(sb, KERN_ERR, |
@@ -2001,14 +2000,6 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
2001 | break; | 2000 | break; |
2002 | } | 2001 | } |
2003 | 2002 | ||
2004 | if (test_opt(sb, NOBH)) { | ||
2005 | if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) { | ||
2006 | ext3_msg(sb, KERN_WARNING, | ||
2007 | "warning: ignoring nobh option - " | ||
2008 | "it is supported only with writeback mode"); | ||
2009 | clear_opt(sbi->s_mount_opt, NOBH); | ||
2010 | } | ||
2011 | } | ||
2012 | /* | 2003 | /* |
2013 | * The journal_load will have done any necessary log recovery, | 2004 | * The journal_load will have done any necessary log recovery, |
2014 | * so we can safely mount the rest of the filesystem now. | 2005 | * so we can safely mount the rest of the filesystem now. |