diff options
author | Dmitry Monakhov <dmonakhov@openvz.org> | 2011-10-19 06:16:23 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2011-10-31 18:43:59 -0400 |
commit | 6360e21f943172bb71772ec150b96a9e787a535f (patch) | |
tree | 20eaacab68cf2c9644a4cb0ff2bd03d66761c0aa /fs/ext3/balloc.c | |
parent | 23cc94eaea4436d37c0b7f1f264a319e8f11088f (diff) |
ext3: Allow quota file use root reservation
Quota file is fs's metadata, so it is reasonable to permit use
root resevation if necessary. This patch fix 265'th xfstest failure
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext3/balloc.c')
-rw-r--r-- | fs/ext3/balloc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index a7fceaba87f1..a2038928f9a3 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c | |||
@@ -1440,14 +1440,14 @@ out: | |||
1440 | * | 1440 | * |
1441 | * Check if filesystem has at least 1 free block available for allocation. | 1441 | * Check if filesystem has at least 1 free block available for allocation. |
1442 | */ | 1442 | */ |
1443 | static int ext3_has_free_blocks(struct ext3_sb_info *sbi) | 1443 | static int ext3_has_free_blocks(struct ext3_sb_info *sbi, int use_reservation) |
1444 | { | 1444 | { |
1445 | ext3_fsblk_t free_blocks, root_blocks; | 1445 | ext3_fsblk_t free_blocks, root_blocks; |
1446 | 1446 | ||
1447 | free_blocks = percpu_counter_read_positive(&sbi->s_freeblocks_counter); | 1447 | free_blocks = percpu_counter_read_positive(&sbi->s_freeblocks_counter); |
1448 | root_blocks = le32_to_cpu(sbi->s_es->s_r_blocks_count); | 1448 | root_blocks = le32_to_cpu(sbi->s_es->s_r_blocks_count); |
1449 | if (free_blocks < root_blocks + 1 && !capable(CAP_SYS_RESOURCE) && | 1449 | if (free_blocks < root_blocks + 1 && !capable(CAP_SYS_RESOURCE) && |
1450 | sbi->s_resuid != current_fsuid() && | 1450 | !use_reservation && sbi->s_resuid != current_fsuid() && |
1451 | (sbi->s_resgid == 0 || !in_group_p (sbi->s_resgid))) { | 1451 | (sbi->s_resgid == 0 || !in_group_p (sbi->s_resgid))) { |
1452 | return 0; | 1452 | return 0; |
1453 | } | 1453 | } |
@@ -1468,7 +1468,7 @@ static int ext3_has_free_blocks(struct ext3_sb_info *sbi) | |||
1468 | */ | 1468 | */ |
1469 | int ext3_should_retry_alloc(struct super_block *sb, int *retries) | 1469 | int ext3_should_retry_alloc(struct super_block *sb, int *retries) |
1470 | { | 1470 | { |
1471 | if (!ext3_has_free_blocks(EXT3_SB(sb)) || (*retries)++ > 3) | 1471 | if (!ext3_has_free_blocks(EXT3_SB(sb), 0) || (*retries)++ > 3) |
1472 | return 0; | 1472 | return 0; |
1473 | 1473 | ||
1474 | jbd_debug(1, "%s: retrying operation after ENOSPC\n", sb->s_id); | 1474 | jbd_debug(1, "%s: retrying operation after ENOSPC\n", sb->s_id); |
@@ -1546,7 +1546,7 @@ ext3_fsblk_t ext3_new_blocks(handle_t *handle, struct inode *inode, | |||
1546 | if (block_i && ((windowsz = block_i->rsv_window_node.rsv_goal_size) > 0)) | 1546 | if (block_i && ((windowsz = block_i->rsv_window_node.rsv_goal_size) > 0)) |
1547 | my_rsv = &block_i->rsv_window_node; | 1547 | my_rsv = &block_i->rsv_window_node; |
1548 | 1548 | ||
1549 | if (!ext3_has_free_blocks(sbi)) { | 1549 | if (!ext3_has_free_blocks(sbi, IS_NOQUOTA(inode))) { |
1550 | *errp = -ENOSPC; | 1550 | *errp = -ENOSPC; |
1551 | goto out; | 1551 | goto out; |
1552 | } | 1552 | } |