diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2012-02-06 12:45:27 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-03-20 21:29:32 -0400 |
commit | 8de52778798fe39660a8d6b26f290e0c93202761 (patch) | |
tree | 56384beb7863c1f338f2b66b509bf58eea5a99c2 /fs/ext2 | |
parent | c16fa4f2ad19908a47c63d8fa436a1178438c7e7 (diff) |
vfs: check i_nlink limits in vfs_{mkdir,rename_dir,link}
New field of struct super_block - ->s_max_links. Maximal allowed
value of ->i_nlink or 0; in the latter case all checks still need
to be done in ->link/->mkdir/->rename instances. Note that this
limit applies both to directoris and to non-directories.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ext2')
-rw-r--r-- | fs/ext2/namei.c | 13 | ||||
-rw-r--r-- | fs/ext2/super.c | 1 |
2 files changed, 2 insertions, 12 deletions
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c index 080419814bae..dffb86536285 100644 --- a/fs/ext2/namei.c +++ b/fs/ext2/namei.c | |||
@@ -195,9 +195,6 @@ static int ext2_link (struct dentry * old_dentry, struct inode * dir, | |||
195 | struct inode *inode = old_dentry->d_inode; | 195 | struct inode *inode = old_dentry->d_inode; |
196 | int err; | 196 | int err; |
197 | 197 | ||
198 | if (inode->i_nlink >= EXT2_LINK_MAX) | ||
199 | return -EMLINK; | ||
200 | |||
201 | dquot_initialize(dir); | 198 | dquot_initialize(dir); |
202 | 199 | ||
203 | inode->i_ctime = CURRENT_TIME_SEC; | 200 | inode->i_ctime = CURRENT_TIME_SEC; |
@@ -217,10 +214,7 @@ static int ext2_link (struct dentry * old_dentry, struct inode * dir, | |||
217 | static int ext2_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) | 214 | static int ext2_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) |
218 | { | 215 | { |
219 | struct inode * inode; | 216 | struct inode * inode; |
220 | int err = -EMLINK; | 217 | int err; |
221 | |||
222 | if (dir->i_nlink >= EXT2_LINK_MAX) | ||
223 | goto out; | ||
224 | 218 | ||
225 | dquot_initialize(dir); | 219 | dquot_initialize(dir); |
226 | 220 | ||
@@ -346,11 +340,6 @@ static int ext2_rename (struct inode * old_dir, struct dentry * old_dentry, | |||
346 | drop_nlink(new_inode); | 340 | drop_nlink(new_inode); |
347 | inode_dec_link_count(new_inode); | 341 | inode_dec_link_count(new_inode); |
348 | } else { | 342 | } else { |
349 | if (dir_de) { | ||
350 | err = -EMLINK; | ||
351 | if (new_dir->i_nlink >= EXT2_LINK_MAX) | ||
352 | goto out_dir; | ||
353 | } | ||
354 | err = ext2_add_link(new_dentry, old_inode); | 343 | err = ext2_add_link(new_dentry, old_inode); |
355 | if (err) | 344 | if (err) |
356 | goto out_dir; | 345 | goto out_dir; |
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 0090595beb28..9f6766a3ac1e 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c | |||
@@ -919,6 +919,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
919 | } | 919 | } |
920 | 920 | ||
921 | sb->s_maxbytes = ext2_max_size(sb->s_blocksize_bits); | 921 | sb->s_maxbytes = ext2_max_size(sb->s_blocksize_bits); |
922 | sb->s_max_links = EXT2_LINK_MAX; | ||
922 | 923 | ||
923 | if (le32_to_cpu(es->s_rev_level) == EXT2_GOOD_OLD_REV) { | 924 | if (le32_to_cpu(es->s_rev_level) == EXT2_GOOD_OLD_REV) { |
924 | sbi->s_inode_size = EXT2_GOOD_OLD_INODE_SIZE; | 925 | sbi->s_inode_size = EXT2_GOOD_OLD_INODE_SIZE; |