[PATCH] remove ext2 xattr permission checks

)

From: Christoph Hellwig <hch@lst.de>

remove checks now in the VFS

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 0 insertions, 14 deletions

diff --git a/fs/ext2/xattr_user.c b/fs/ext2/xattr_user.c
index 0c03ea131a94..f383e7c3a7b5 100644
--- a/fs/ext2/xattr_user.c
+++ b/fs/ext2/xattr_user.c
@@ -35,16 +35,10 @@ static int
 ext2_xattr_user_get(struct inode *inode, const char *name,
                     void *buffer, size_t size)
 {
-        int error;
-
         if (strcmp(name, "") == 0)
                 return -EINVAL;
         if (!test_opt(inode->i_sb, XATTR_USER))
                 return -EOPNOTSUPP;
-        error = permission(inode, MAY_READ, NULL);
-        if (error)
-                return error;
-
         return ext2_xattr_get(inode, EXT2_XATTR_INDEX_USER, name, buffer, size);
 }
 
@@ -52,18 +46,10 @@ static int
 ext2_xattr_user_set(struct inode *inode, const char *name,
                     const void *value, size_t size, int flags)
 {
-        int error;
-
         if (strcmp(name, "") == 0)
                 return -EINVAL;
         if (!test_opt(inode->i_sb, XATTR_USER))
                 return -EOPNOTSUPP;
-        if ( !S_ISREG(inode->i_mode) &&
-            (!S_ISDIR(inode->i_mode) || inode->i_mode & S_ISVTX))
-                return -EPERM;
-        error = permission(inode, MAY_WRITE, NULL);
-        if (error)
-                return error;
 
         return ext2_xattr_set(inode, EXT2_XATTR_INDEX_USER, name,
                               value, size, flags);