diff options
author | Jan Kara <jack@suse.cz> | 2012-03-31 08:22:10 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2012-04-11 05:12:45 -0400 |
commit | b838ec2232b764a4903707e212c62f681b32cd51 (patch) | |
tree | 31967c9821f019d97fdb6882a0b31d41db3d10e5 /fs/ext2/super.c | |
parent | f2b2242081314ee4385f3b49d92b0adff8324d80 (diff) |
ext2: Remove s_dirt handling
Places which modify superblock feature / state fields mark the superblock
buffer dirty so it is written out by flusher thread. Thus there's no need to
set s_dirt there.
The only other fields changing in the superblock are the numbers of free
blocks, free inodes and s_wtime. There's no real need to write (or even
compute) these periodically. Free blocks / inodes counters are recomputed on
every mount from group counters anyway and value of s_wtime is only
informational and imprecise anyway. So it should be enough to write these
opportunistically on mount, remount, umount, and sync_fs times.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext2/super.c')
-rw-r--r-- | fs/ext2/super.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 12a7916cfa9d..a43f9adcc811 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c | |||
@@ -1158,7 +1158,6 @@ static void ext2_sync_super(struct super_block *sb, struct ext2_super_block *es, | |||
1158 | mark_buffer_dirty(EXT2_SB(sb)->s_sbh); | 1158 | mark_buffer_dirty(EXT2_SB(sb)->s_sbh); |
1159 | if (wait) | 1159 | if (wait) |
1160 | sync_dirty_buffer(EXT2_SB(sb)->s_sbh); | 1160 | sync_dirty_buffer(EXT2_SB(sb)->s_sbh); |
1161 | sb->s_dirt = 0; | ||
1162 | } | 1161 | } |
1163 | 1162 | ||
1164 | /* | 1163 | /* |
@@ -1191,8 +1190,6 @@ void ext2_write_super(struct super_block *sb) | |||
1191 | { | 1190 | { |
1192 | if (!(sb->s_flags & MS_RDONLY)) | 1191 | if (!(sb->s_flags & MS_RDONLY)) |
1193 | ext2_sync_fs(sb, 1); | 1192 | ext2_sync_fs(sb, 1); |
1194 | else | ||
1195 | sb->s_dirt = 0; | ||
1196 | } | 1193 | } |
1197 | 1194 | ||
1198 | static int ext2_remount (struct super_block * sb, int * flags, char * data) | 1195 | static int ext2_remount (struct super_block * sb, int * flags, char * data) |