diff options
author | Julia Lawall <julia@diku.dk> | 2008-04-28 05:16:02 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-28 11:58:43 -0400 |
commit | 2c11619a590e13fecc801c9c50859cba29740f38 (patch) | |
tree | 016c01a5a9558b1540514e5159444cec3614d1ca /fs/ext2/dir.c | |
parent | 4c8b3125f8dcefd1ee2990113fe69cfa9e9fa609 (diff) |
fs/ext2: use BUG_ON
if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@ disable unlikely @ expression E,f; @@
(
if (<... f(...) ...>) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)
@@ expression E,f; @@
(
if (<... f(...) ...>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ext2/dir.c')
-rw-r--r-- | fs/ext2/dir.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c index a0995eb2dc23..dd9dbb25eab2 100644 --- a/fs/ext2/dir.c +++ b/fs/ext2/dir.c | |||
@@ -41,8 +41,8 @@ static inline __le16 ext2_rec_len_to_disk(unsigned len) | |||
41 | { | 41 | { |
42 | if (len == (1 << 16)) | 42 | if (len == (1 << 16)) |
43 | return cpu_to_le16(EXT2_MAX_REC_LEN); | 43 | return cpu_to_le16(EXT2_MAX_REC_LEN); |
44 | else if (len > (1 << 16)) | 44 | else |
45 | BUG(); | 45 | BUG_ON(len > (1 << 16)); |
46 | return cpu_to_le16(len); | 46 | return cpu_to_le16(len); |
47 | } | 47 | } |
48 | 48 | ||